extcon: arizona: Always use pm_runtime_get_sync() when we need the device to be awake
authorHans de Goede <hdegoede@redhat.com>
Sun, 7 Mar 2021 15:17:59 +0000 (16:17 +0100)
committerLee Jones <lee.jones@linaro.org>
Thu, 18 Mar 2021 11:46:15 +0000 (11:46 +0000)
Before this commit the extcon-arizona code was mixing pm_runtime_get()
and pm_runtime_get_sync() in different places.

In all places where pm_runtime_get[_sync]() is called, the code
makes use of the device immediately after the call.
This means that we should always use pm_runtime_get_sync().

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Tested-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/extcon/extcon-arizona.c

index 72d23b1..56d2ce0 100644 (file)
@@ -290,7 +290,7 @@ static void arizona_start_mic(struct arizona_extcon_info *info)
        unsigned int mode;
 
        /* Microphone detection can't use idle mode */
-       pm_runtime_get(info->dev);
+       pm_runtime_get_sync(info->dev);
 
        if (info->detecting) {
                ret = regulator_allow_bypass(info->micvdd, false);
@@ -695,7 +695,7 @@ static void arizona_identify_headphone(struct arizona_extcon_info *info)
        dev_dbg(arizona->dev, "Starting HPDET\n");
 
        /* Make sure we keep the device enabled during the measurement */
-       pm_runtime_get(info->dev);
+       pm_runtime_get_sync(info->dev);
 
        info->hpdet_active = true;