mfd: abx500-core: Improve two size determinations in abx500_register_ops()
authorMarkus Elfring <elfring@users.sourceforge.net>
Thu, 8 Mar 2018 11:46:47 +0000 (12:46 +0100)
committerLee Jones <lee.jones@linaro.org>
Wed, 16 May 2018 08:21:48 +0000 (09:21 +0100)
Replace the specification of two data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/abx500-core.c

index c8c9d41..17176e9 100644 (file)
@@ -37,14 +37,12 @@ int abx500_register_ops(struct device *dev, struct abx500_ops *ops)
 {
        struct abx500_device_entry *dev_entry;
 
-       dev_entry = devm_kzalloc(dev,
-                                sizeof(struct abx500_device_entry),
-                                GFP_KERNEL);
+       dev_entry = devm_kzalloc(dev, sizeof(*dev_entry), GFP_KERNEL);
        if (!dev_entry)
                return -ENOMEM;
 
        dev_entry->dev = dev;
-       memcpy(&dev_entry->ops, ops, sizeof(struct abx500_ops));
+       memcpy(&dev_entry->ops, ops, sizeof(*ops));
 
        list_add_tail(&dev_entry->list, &abx500_list);
        return 0;