Cynara: fix helper common functions

Change-Id: Ie8866504e459ff299d408851db7c0b476d108f03

diff --git a/src/cynara-tests/common/cynara_test_helpers.cpp b/src/cynara-tests/common/cynara_test_helpers.cpp
index da39c409b9ed16c0c66b04956026b8ee6fe0ab43..ffb96280591288403cc86b170dd7ba6bed60e45d 100644 (file)
--- a/src/cynara-tests/common/cynara_test_helpers.cpp
+++ b/src/cynara-tests/common/cynara_test_helpers.cpp
@@ -31,7 +31,7 @@
 namespace CynaraHelperCredentials {
 
 char *socketGetClient(int sock, cynara_client_creds method, int expectedResult) {
-    char *buff;
+    char *buff = nullptr;
     auto ret = cynara_creds_socket_get_client(sock, method, &buff);
     RUNNER_ASSERT_MSG(ret == expectedResult,
                       "cynara_creds_socket_get_client failed, ret = " << ret
@@ -40,7 +40,7 @@ char *socketGetClient(int sock, cynara_client_creds method, int expectedResult)
 }
 
 char *socketGetUser(int sock, cynara_user_creds method, int expectedResult) {
-    char *buff;
+    char *buff = nullptr;
     auto ret = cynara_creds_socket_get_user(sock, method, &buff);
     RUNNER_ASSERT_MSG(ret == expectedResult,
                       "cynara_creds_socket_get_user failed, ret = " << ret
@@ -49,7 +49,7 @@ char *socketGetUser(int sock, cynara_user_creds method, int expectedResult) {
 }
 
 pid_t socketGetPid(int sock, int expectedResult) {
-    pid_t pid;
+    pid_t pid = -1;
     auto ret = cynara_creds_socket_get_pid(sock, &pid);
     RUNNER_ASSERT_MSG(ret == expectedResult,
                       "cynara_creds_socket_get_pid failed, ret = " << ret << "; expected = "
@@ -59,7 +59,7 @@ pid_t socketGetPid(int sock, int expectedResult) {
 
 char *dbusGetClient(DBusConnectionPtr connection, const char *uniqueName,
                     cynara_client_creds method, int expectedResult) {
-    char *buff;
+    char *buff = nullptr;
     auto ret = cynara_creds_dbus_get_client(connection.get(), uniqueName, method, &buff);
     RUNNER_ASSERT_MSG(ret == expectedResult,
                       "cynara_creds_dbus_get_client failed, ret = " << ret
@@ -69,7 +69,7 @@ char *dbusGetClient(DBusConnectionPtr connection, const char *uniqueName,
 
 char *dbusGetUser(DBusConnectionPtr connection, const char *uniqueName, cynara_user_creds method,
                   int expectedResult) {
-    char *buff;
+    char *buff = nullptr;
     auto ret = cynara_creds_dbus_get_user(connection.get(), uniqueName, method, &buff);
     RUNNER_ASSERT_MSG(ret == expectedResult,
                       "cynara_creds_dbus_get_user failed, ret = " << ret
@@ -78,7 +78,7 @@ char *dbusGetUser(DBusConnectionPtr connection, const char *uniqueName, cynara_u
 }
 
 pid_t dbusGetPid(DBusConnectionPtr connection, const char *uniqueName, int expectedResult) {
-    pid_t pid;
+    pid_t pid = -1;
     auto ret = cynara_creds_dbus_get_pid(connection.get(), uniqueName, &pid);
     RUNNER_ASSERT_MSG(ret == expectedResult, "cynara_creds_dbus_get_pid failed, ret = " << ret
                                              << "; expected = " << expectedResult);
@@ -87,7 +87,7 @@ pid_t dbusGetPid(DBusConnectionPtr connection, const char *uniqueName, int expec
 
 char *gdbusGetClient(GDBusConnectionPtr connection, const char *uniqueName,
                      cynara_client_creds method, int expectedResult) {
-    char *buff;
+    char *buff = nullptr;
     auto ret = cynara_creds_gdbus_get_client(connection.get(), uniqueName, method, &buff);
     RUNNER_ASSERT_MSG(ret == expectedResult,
                       "cynara_creds_gdbus_get_client failed, ret = " << ret
@@ -97,7 +97,7 @@ char *gdbusGetClient(GDBusConnectionPtr connection, const char *uniqueName,
 
 char *gdbusGetUser(GDBusConnectionPtr connection, const char *uniqueName, cynara_user_creds method,
                    int expectedResult) {
-    char *buff;
+    char *buff = nullptr;
     auto ret = cynara_creds_gdbus_get_user(connection.get(), uniqueName, method, &buff);
     RUNNER_ASSERT_MSG(ret == expectedResult,
                       "cynara_creds_gdbus_get_user failed, ret = " << ret
@@ -106,7 +106,7 @@ char *gdbusGetUser(GDBusConnectionPtr connection, const char *uniqueName, cynara
 }
 
 pid_t gdbusGetPid(GDBusConnectionPtr connection, const char *uniqueName) {
-    pid_t pid;
+    pid_t pid = -1;
     auto ret = cynara_creds_gdbus_get_pid(connection.get(), uniqueName, &pid);
     RUNNER_ASSERT_MSG(ret == CYNARA_API_SUCCESS,
                       "cynara_creds_gdbus_get_pid failed, ret = " << ret);