sun4i-csi: call _vb2_fop_release instead of v4l2_fh_release
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Tue, 7 Jul 2020 13:36:47 +0000 (15:36 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Sun, 19 Jul 2020 05:45:55 +0000 (07:45 +0200)
This driver didn't call _vb2_fop_release in the sun4i_csi_release
function. Without that call the vb2 queue is not properly canceled and
buffers may not be freed.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c

index 06bf0d1..8f4e254 100644 (file)
@@ -242,7 +242,8 @@ static int sun4i_csi_release(struct file *file)
 
        mutex_lock(&csi->lock);
 
-       v4l2_fh_release(file);
+       _vb2_fop_release(file, NULL);
+
        v4l2_pipeline_pm_put(&csi->vdev.entity);
        pm_runtime_put(csi->dev);