service: Default service notifier is called too many times

The default service notifier is invoked even when the default
service has not been changed. This causes unnecessary dbus
signal traffic.

Fixes BMC#25030

diff --git a/src/service.c b/src/service.c
index b76b0a9..35e88d0 100644 (file)
--- a/src/service.c
+++ b/src/service.c
@@ -42,8 +42,8 @@ static DBusConnection *connection = NULL;
 static GSequence *service_list = NULL;
 static GHashTable *service_hash = NULL;
 static GSList *counter_list = NULL;
-
 static unsigned int autoconnect_timeout = 0;
+static struct connman_service *current_default = NULL;
 
 struct connman_stats {
        connman_bool_t valid;
@@ -1256,6 +1256,11 @@ static void default_changed(void)
 {
        struct connman_service *service = __connman_service_get_default();
 
+       if (service == current_default)
+               return;
+
+       current_default = service;
+
        __connman_notifier_default_changed(service);
 }