Fix static analysis issues

The following issues are fixed:
 - INEFFECTIVE_MOVE
 - HFA
 - AUTO_CAUSES_COPY
 - UNINIT_CTOR

Change-Id: I3372b6578b80f91331d0da3b3a6dc8df8aea5a6f
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>

diff --git a/parser/src/pkgmgr_parser.c b/parser/src/pkgmgr_parser.c
index 3d87fe241bc081249d244cd6e64d5bdc3ffd036f..5c78b18201ef0b676f4dc4a71faff488082bf787 100644 (file)
--- a/parser/src/pkgmgr_parser.c
+++ b/parser/src/pkgmgr_parser.c
@@ -23,7 +23,6 @@
 #include <dlfcn.h>
 #include <string.h>
 #include <unistd.h>
-#include <string.h>
 #include <libxml/parser.h>
 #include <libxml/xmlschemas.h>
 #include <glib.h>

diff --git a/parser/src/pkgmgr_parser_db.c b/parser/src/pkgmgr_parser_db.c
index 503484987bd422e69973935e3f9a63ffff63758f..16faf6dbe9b3e9ddc1aad31cae63b25b48fc6085 100644 (file)
--- a/parser/src/pkgmgr_parser_db.c
+++ b/parser/src/pkgmgr_parser_db.c
@@ -36,7 +36,6 @@
 #include "pkgmgr-info.h"
 #include "pkgmgrinfo_basic.h"
 #include "pkgmgr_parser.h"
-#include "pkgmgr_parser_db_queries.h"
 #include "pkgmgr_parser_debug.h"
 #include "pkgmgr_parser_internal.h"
 #include "manager/pkginfo_manager.h"

diff --git a/src/manager/pkginfo_manager.cc b/src/manager/pkginfo_manager.cc
index 2b72d05409b2ba30e262e97aa98c3404d7f36b9b..0515e47ca022ccf763a47733ef6ba6308c65a537 100644 (file)
--- a/src/manager/pkginfo_manager.cc
+++ b/src/manager/pkginfo_manager.cc
@@ -566,7 +566,7 @@ extern "C" EXPORT_API int _get_pkg_updateinfo(const char* pkgid,
   }
 
   std::shared_ptr<pcp::AbstractParcelable> parcelable(
-      new pcp::QueryParcelable(uid, std::move(info),
+      new pcp::QueryParcelable(uid, info,
           pkgmgr_common::DBType::DB_TYPE_FILE_PKGDB,
           pkgmgr_common::DBOperationType::OPERATION_TYPE_READ));
 
@@ -790,7 +790,7 @@ extern "C" EXPORT_API int _parser_execute_write_queries(
   }
 
   std::shared_ptr<pcp::AbstractParcelable> parcelable(
-      new pcp::QueryParcelable(uid, std::move(queries),
+      new pcp::QueryParcelable(uid, queries,
           pkgmgr_common::DBType::DB_TYPE_FILE_PKGDB,
           pkgmgr_common::DBOperationType::OPERATION_TYPE_WRITE));
 

diff --git a/src/pkgmgrinfo_certinfo.c b/src/pkgmgrinfo_certinfo.c
index 7ba0be55c62ea6724ff28695deb44c07769d2498..8024fc24582e5b0fb23b9a654f74710732a70bb1 100644 (file)
--- a/src/pkgmgrinfo_certinfo.c
+++ b/src/pkgmgrinfo_certinfo.c
@@ -11,7 +11,6 @@
 #include "pkgmgr-info.h"
 #include "pkgmgrinfo_debug.h"
 #include "pkgmgrinfo_private.h"
-#include "pkgmgr_parser.h"
 
 API int pkgmgrinfo_pkginfo_create_certinfo(pkgmgrinfo_certinfo_h *handle)
 {

diff --git a/src/pkgmgrinfo_db.c b/src/pkgmgrinfo_db.c
index 3f304081f77201a664bb86ffe7686e2185411822..f175cdeac34d4f2d623d5115ae38c3ada360e17e 100644 (file)
--- a/src/pkgmgrinfo_db.c
+++ b/src/pkgmgrinfo_db.c
@@ -17,7 +17,6 @@
 #include "pkgmgrinfo_debug.h"
 #include "pkgmgrinfo_private.h"
 #include "pkgmgr_parser.h"
-#include "pkgmgr_parser_db.h"
 #include "manager/pkginfo_manager.h"
 
 typedef int (*sqlite_query_callback)(void *data, int ncols,

diff --git a/src/pkgmgrinfo_pkginfo.c b/src/pkgmgrinfo_pkginfo.c
index 247ee17d1d25420c1d860b4883647952dd77d865..ea5a3a45222749304e9c35822884edb3d50342b1 100644 (file)
--- a/src/pkgmgrinfo_pkginfo.c
+++ b/src/pkgmgrinfo_pkginfo.c
@@ -29,7 +29,6 @@
 #include <ctype.h>
 #include <sys/smack.h>
 #include <linux/limits.h>
-#include <libgen.h>
 #include <sys/stat.h>
 
 #include <glib.h>

diff --git a/src/server/certinfo_internal.c b/src/server/certinfo_internal.c
index 2d2cd8db5307a04ee4a7894e9b815f7b65767cb5..549f39b889d4b186b15800101eaeb0c8cf0bcf0e 100644 (file)
--- a/src/server/certinfo_internal.c
+++ b/src/server/certinfo_internal.c
@@ -23,7 +23,6 @@
 #include <ctype.h>
 #include <sys/smack.h>
 #include <linux/limits.h>
-#include <libgen.h>
 #include <sys/stat.h>
 
 #include <sqlite3.h>

diff --git a/src/server/database/abstract_db_handler.cc b/src/server/database/abstract_db_handler.cc
index 1e5781563598773ce9b254e766e9031f69b107a7..05500cd5b0cc44d14a2487a3e47636ad930374fa 100644 (file)
--- a/src/server/database/abstract_db_handler.cc
+++ b/src/server/database/abstract_db_handler.cc
@@ -215,7 +215,7 @@ bool AbstractDBHandler::Connect() {
 }
 
 void AbstractDBHandler::ClearDBHandle() {
-  for (auto db_handle : db_handle_list_)
+  for (const auto& db_handle : db_handle_list_)
     sqlite3_close_v2(db_handle.first);
 
   db_handle_list_.clear();

diff --git a/src/server/pkginfo_internal.c b/src/server/pkginfo_internal.c
index 3873f4cdcb76f695ce6abfce6291691a1392319c..cb46059bf1e9957b6593637a1d756dae9cc7a3fa 100644 (file)
--- a/src/server/pkginfo_internal.c
+++ b/src/server/pkginfo_internal.c
@@ -23,7 +23,6 @@
 #include <ctype.h>
 #include <sys/smack.h>
 #include <linux/limits.h>
-#include <libgen.h>
 #include <sys/stat.h>
 
 #include <sqlite3.h>

diff --git a/src/server/request_handler/abstract_request_handler.hh b/src/server/request_handler/abstract_request_handler.hh
index 5c093e70f3ebc89c8555bd6cd4e4ffb498b2e9b7..1a54cd65e1718347ce587a0c87a7e55a67e3599c 100644 (file)
--- a/src/server/request_handler/abstract_request_handler.hh
+++ b/src/server/request_handler/abstract_request_handler.hh
@@ -39,8 +39,8 @@ class EXPORT_API AbstractRequestHandler {
   uid_t GetUID();
 
  private:
-  pid_t pid_;
-  uid_t uid_;
+  pid_t pid_ = -1;
+  uid_t uid_ = 0;
 };
 
 }  // namespace request_handler

diff --git a/test/unit_tests/test_parcel.cc b/test/unit_tests/test_parcel.cc
index 093f72f3c36bf1e6de4896e43d924c51c8deeb4b..8dd603fca61dad3f62c0d8a05838a57399113409 100644 (file)
--- a/test/unit_tests/test_parcel.cc
+++ b/test/unit_tests/test_parcel.cc
@@ -201,7 +201,7 @@ TEST_F(ParcelTest, QueryParcelable) {
     { 2, { nullptr, "arg2" } }
   };
 
-  pp::QueryParcelable origin_parcelable(0, std::move(query_args),
+  pp::QueryParcelable origin_parcelable(0, query_args,
       pkgmgr_common::DBType::DB_TYPE_FILE_PKGDB,
       pkgmgr_common::DBOperationType::OPERATION_TYPE_READ);
   pp::QueryParcelable new_parcelable;