phy: renesas: r8a779f0-eth-serdes: Remove retry code in .init()
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Mon, 26 Dec 2022 06:53:16 +0000 (15:53 +0900)
committerVinod Koul <vkoul@kernel.org>
Fri, 13 Jan 2023 18:03:56 +0000 (23:33 +0530)
Remove retry code in r8a779f0_eth_serdes_init() because
r8a779f0_eth_serdes_chan_setting() was fixed so that no timeout
happened in the initializing procedure.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Link: https://lore.kernel.org/r/20221226065316.3895480-3-yoshihiro.shimoda.uh@renesas.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/renesas/r8a779f0-ether-serdes.c

index ba4ca63..49524db 100644 (file)
@@ -18,7 +18,6 @@
 #define R8A779F0_ETH_SERDES_BANK_SELECT                0x03fc
 #define R8A779F0_ETH_SERDES_TIMEOUT_US         100000
 #define R8A779F0_ETH_SERDES_NUM_RETRY_LINKUP   3
-#define R8A779F0_ETH_SERDES_NUM_RETRY_INIT     3
 
 struct r8a779f0_eth_serdes_drv_data;
 struct r8a779f0_eth_serdes_channel {
@@ -248,16 +247,11 @@ static int r8a779f0_eth_serdes_hw_init(struct r8a779f0_eth_serdes_channel *chann
 static int r8a779f0_eth_serdes_init(struct phy *p)
 {
        struct r8a779f0_eth_serdes_channel *channel = phy_get_drvdata(p);
-       int i, ret;
+       int ret;
 
-       for (i = 0; i < R8A779F0_ETH_SERDES_NUM_RETRY_INIT; i++) {
-               ret = r8a779f0_eth_serdes_hw_init(channel);
-               if (!ret) {
-                       channel->dd->initialized = true;
-                       break;
-               }
-               usleep_range(1000, 2000);
-       }
+       ret = r8a779f0_eth_serdes_hw_init(channel);
+       if (!ret)
+               channel->dd->initialized = true;
 
        return ret;
 }