MIPS/ld/testsuite: Limit export class call reloc tests to DSO targets
authorMaciej W. Rozycki <macro@mips.com>
Tue, 10 Jul 2018 23:56:46 +0000 (16:56 -0700)
committerMaciej W. Rozycki <macro@mips.com>
Tue, 10 Jul 2018 23:57:36 +0000 (00:57 +0100)
Only run MIPS/LD export class call relocation tests with shared library
targets, avoiding:

.../ld/ld-new: -shared not supported

linker errors and removing:

FAIL: MIPS export class call relocation test (o32)

regressions with `mipsel-ps2-elf' and `mips64el-ps2-elf' targets.

ld/
* testsuite/ld-mips-elf/mips-elf.exp: Limit export class call
relocation tests to shared library targets.

ld/ChangeLog
ld/testsuite/ld-mips-elf/mips-elf.exp

index 09ddc21..01e9465 100644 (file)
@@ -1,3 +1,8 @@
+2018-07-10  Maciej W. Rozycki  <macro@mips.com>
+
+       * testsuite/ld-mips-elf/mips-elf.exp: Limit export class call
+       relocation tests to shared library targets.
+
 2018-07-10  Alan Modra  <amodra@gmail.com>
 
        * testsuite/lib/ld-lib.exp (check_gc_sections_available): Return 0
index 1a56340..6aae2f9 100644 (file)
@@ -1050,23 +1050,27 @@ run_dump_test "mips16-and-micromips"
 
 # Export class call relocation tests.
 set abis [concat o32 [expr {$has_newabi ? "n32 n64" : ""}]]
-foreach { abi } $abis {
-    set loadaddr [string map \
-       {o32 0x12340000 n32 0x12340000 n64 0x123456789abc0000} $abi]
-    set suff [subst \
-       [expr { $irix \
-               ? [string map {o32 o32-irix n32 n32 n64 n64} $abi] \
-               : $abi }]]
-    run_ld_link_tests [list \
-       [list \
-           "MIPS export class call relocation test ($abi)" \
-           "$abi_ldflags($abi) -shared -Ttext $loadaddr -T export-class-call16.ld" "" \
-           "$abi_asflags($abi) -mips3 -KPIC" \
-           [list export-class-call16-${abi}.s export-class-call16-def.s] \
+if [check_shared_lib_support] {
+    foreach { abi } $abis {
+       set loadaddr [string map \
+           {o32 0x12340000 n32 0x12340000 n64 0x123456789abc0000} $abi]
+       set suff [subst \
+           [expr { $irix \
+                   ? [string map {o32 o32-irix n32 n32 n64 n64} $abi] \
+                   : $abi }]]
+       run_ld_link_tests [list \
            [list \
-               "objdump -d export-class-call16-${suff}.dd" \
-               "readelf -A export-class-call16-${abi}.gd"] \
-           "export-class-call16-${abi}.so"]]
+               "MIPS export class call relocation test ($abi)" \
+               "$abi_ldflags($abi) -shared -Ttext $loadaddr\
+                -T export-class-call16.ld" \
+               "" \
+               "$abi_asflags($abi) -mips3 -KPIC" \
+               [list export-class-call16-${abi}.s export-class-call16-def.s] \
+               [list \
+                   "objdump -d export-class-call16-${suff}.dd" \
+                   "readelf -A export-class-call16-${abi}.gd"] \
+               "export-class-call16-${abi}.so"]]
+    }
 }
 
 # Magic __ehdr_start symbol tests.