Re-enable netfx testing for Microsoft.VisualBasic.Core (dotnet/corefx#39871)

Commit migrated from https://github.com/dotnet/corefx/commit/da0ebf17b2c0e7e707e4555242f170e2146d98be

diff --git a/src/libraries/Microsoft.VisualBasic.Core/tests/Configurations.props b/src/libraries/Microsoft.VisualBasic.Core/tests/Configurations.props
index acf56fa..0ea07aa 100644 (file)
--- a/src/libraries/Microsoft.VisualBasic.Core/tests/Configurations.props
+++ b/src/libraries/Microsoft.VisualBasic.Core/tests/Configurations.props
@@ -3,6 +3,7 @@
     <BuildConfigurations>
       netcoreapp;
       uap;
+      netfx;
     </BuildConfigurations>
   </PropertyGroup>
 </Project>
\ No newline at end of file

diff --git a/src/libraries/Microsoft.VisualBasic.Core/tests/FinancialTests.cs b/src/libraries/Microsoft.VisualBasic.Core/tests/FinancialTests.cs
index 9622a72..3ce4c4e 100644 (file)
--- a/src/libraries/Microsoft.VisualBasic.Core/tests/FinancialTests.cs
+++ b/src/libraries/Microsoft.VisualBasic.Core/tests/FinancialTests.cs
@@ -7,6 +7,7 @@ using Xunit;
 
 namespace Microsoft.VisualBasic.Tests
 {
+    [ActiveIssue(39888, TargetFrameworkMonikers.NetFramework)]
     public class FinancialTests
     {
         private static bool IsNotArmOrAlpine() => !PlatformDetection.IsArmOrArm64Process && !PlatformDetection.IsAlpine;

diff --git a/src/libraries/Microsoft.VisualBasic.Core/tests/Microsoft.VisualBasic.Core.Tests.csproj b/src/libraries/Microsoft.VisualBasic.Core/tests/Microsoft.VisualBasic.Core.Tests.csproj
index 08c6610..4546250 100644 (file)
--- a/src/libraries/Microsoft.VisualBasic.Core/tests/Microsoft.VisualBasic.Core.Tests.csproj
+++ b/src/libraries/Microsoft.VisualBasic.Core/tests/Microsoft.VisualBasic.Core.Tests.csproj
@@ -2,7 +2,7 @@
   <PropertyGroup>
     <ProjectGuid>{325260D6-D5DD-4E06-9DA2-9AF2AD9DE8C8}</ProjectGuid>
     <IncludeRemoteExecutor>true</IncludeRemoteExecutor>
-    <Configurations>netcoreapp-Debug;netcoreapp-Release;uap-Debug;uap-Release</Configurations>
+    <Configurations>netcoreapp-Debug;netcoreapp-Release;uap-Debug;uap-Release;netfx-Debug;netfx-Release</Configurations>
   </PropertyGroup>
   <ItemGroup>
     <Compile Include="AssemblyAttributes.cs" />

diff --git a/src/libraries/Microsoft.VisualBasic.Core/tests/Microsoft/VisualBasic/ApplicationServices/ApplicationBaseTests.cs b/src/libraries/Microsoft.VisualBasic.Core/tests/Microsoft/VisualBasic/ApplicationServices/ApplicationBaseTests.cs
index 0ea36a7..4d75ed9 100644 (file)
--- a/src/libraries/Microsoft.VisualBasic.Core/tests/Microsoft/VisualBasic/ApplicationServices/ApplicationBaseTests.cs
+++ b/src/libraries/Microsoft.VisualBasic.Core/tests/Microsoft/VisualBasic/ApplicationServices/ApplicationBaseTests.cs
@@ -58,6 +58,7 @@ namespace Microsoft.VisualBasic.ApplicationServices.Tests
         }
 
         [Fact]
+        [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Different entry assembly")]
         public void Info()
         {
             var app = new ApplicationBase();

diff --git a/src/libraries/Microsoft.VisualBasic.Core/tests/Microsoft/VisualBasic/FileIO/SpecialDirectoriesTests.cs b/src/libraries/Microsoft.VisualBasic.Core/tests/Microsoft/VisualBasic/FileIO/SpecialDirectoriesTests.cs
index 3094a61..26f74e4 100644 (file)
--- a/src/libraries/Microsoft.VisualBasic.Core/tests/Microsoft/VisualBasic/FileIO/SpecialDirectoriesTests.cs
+++ b/src/libraries/Microsoft.VisualBasic.Core/tests/Microsoft/VisualBasic/FileIO/SpecialDirectoriesTests.cs
@@ -24,12 +24,14 @@ namespace Microsoft.VisualBasic.FileIO.Tests
         }
 
         [Fact]
+        [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Supported on netfx")]
         public static void AllUsersApplicationDataFolderTest()
         {
             Assert.Throws<PlatformNotSupportedException>(() => SpecialDirectories.AllUsersApplicationData);
         }
 
         [Fact]
+        [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Supported on netfx")]
         public static void CurrentUserApplicationDataFolderTest()
         {
             Assert.Throws<PlatformNotSupportedException>(() => SpecialDirectories.CurrentUserApplicationData);

diff --git a/src/libraries/Microsoft.VisualBasic.Core/tests/OperatorsTests.cs b/src/libraries/Microsoft.VisualBasic.Core/tests/OperatorsTests.cs
index e72917c..f26705e 100644 (file)
--- a/src/libraries/Microsoft.VisualBasic.Core/tests/OperatorsTests.cs
+++ b/src/libraries/Microsoft.VisualBasic.Core/tests/OperatorsTests.cs
@@ -3332,6 +3332,7 @@ namespace Microsoft.VisualBasic.CompilerServices.Tests
 
         [Theory]
         [MemberData(nameof(ModObject_DivideByZeroObject_TestData))]
+        [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Unfixed JIT bug in the .NET Framework")]
         public void ModObject_DivideByZeroObject_ThrowsDivideByZeroException(object left, object right)
         {
             Assert.Throws<DivideByZeroException>(() => Operators.ModObject(left, right));

diff --git a/src/libraries/Microsoft.VisualBasic.Core/tests/StringsTests.cs b/src/libraries/Microsoft.VisualBasic.Core/tests/StringsTests.cs
index db731bb..84da19d 100644 (file)
--- a/src/libraries/Microsoft.VisualBasic.Core/tests/StringsTests.cs
+++ b/src/libraries/Microsoft.VisualBasic.Core/tests/StringsTests.cs
@@ -134,6 +134,7 @@ namespace Microsoft.VisualBasic.Tests
             }, charCode.ToString(), expected.ToString()).Dispose();
         }
 
+        [ActiveIssue(39888, TargetFrameworkMonikers.NetFramework)]
         [Theory]
         [InlineData(0, 0)]
         [InlineData(33, 33)]