ACPICA: Check that EBDA pointer is in valid memory
authorVit Kabele <vit@kabele.me>
Thu, 27 Oct 2022 17:50:06 +0000 (19:50 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 28 Oct 2022 15:28:22 +0000 (17:28 +0200)
ACPICA commit cc9e7763ceb2e2649fe3422130416d84a3c6854a

If the memory at 0x40e is uninitialized, the retrieved physical_memory
address of EBDA may be beyond the low memory (i.e. above 640K).

If so, the kernel may unintentionally access the VGA memory, that
might not be decoded or even present in case of virtualization.

Link: https://github.com/acpica/acpica/commit/cc9e7763
Signed-off-by: Vit Kabele <vit@kabele.me>
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/acpica/tbxfroot.c

index 3d09e3f..ede2745 100644 (file)
@@ -139,7 +139,11 @@ acpi_find_root_pointer(acpi_physical_address *table_address)
 
        /* EBDA present? */
 
-       if (physical_address > 0x400) {
+       /*
+        * Check that the EBDA pointer from memory is sane and does not point
+        * above valid low memory
+        */
+       if (physical_address > 0x400 && physical_address < 0xA0000) {
                /*
                 * 1b) Search EBDA paragraphs (EBDA is required to be a
                 *     minimum of 1K length)