drm/msm/dpu: inline MERGE_3D_BLK macros

To simplify making changes to the hardware block definitions, expand
corresponding macros. This way making all the changes are more obvious
and visible in the source files.

Tested-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/545382/
Link: https://lore.kernel.org/r/20230704022136.130522-15-dmitry.baryshkov@linaro.org

diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h
index 0b68f2f..0665cfb 100644 (file)
--- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_0_sm8150.h
@@ -239,9 +239,19 @@ static const struct dpu_pingpong_cfg sm8150_pp[] = {
 };
 
 static const struct dpu_merge_3d_cfg sm8150_merge_3d[] = {
-       MERGE_3D_BLK("merge_3d_0", MERGE_3D_0, 0x83000),
-       MERGE_3D_BLK("merge_3d_1", MERGE_3D_1, 0x83100),
-       MERGE_3D_BLK("merge_3d_2", MERGE_3D_2, 0x83200),
+       {
+               .name = "merge_3d_0", .id = MERGE_3D_0,
+               .base = 0x83000, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       }, {
+               .name = "merge_3d_1", .id = MERGE_3D_1,
+               .base = 0x83100, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       }, {
+               .name = "merge_3d_2", .id = MERGE_3D_2,
+               .base = 0x83200, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       },
 };
 
 static const struct dpu_dsc_cfg sm8150_dsc[] = {

diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h
index 5b36baf..4babe9b 100644 (file)
--- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h
@@ -238,9 +238,19 @@ static const struct dpu_pingpong_cfg sc8180x_pp[] = {
 };
 
 static const struct dpu_merge_3d_cfg sc8180x_merge_3d[] = {
-       MERGE_3D_BLK("merge_3d_0", MERGE_3D_0, 0x83000),
-       MERGE_3D_BLK("merge_3d_1", MERGE_3D_1, 0x83100),
-       MERGE_3D_BLK("merge_3d_2", MERGE_3D_2, 0x83200),
+       {
+               .name = "merge_3d_0", .id = MERGE_3D_0,
+               .base = 0x83000, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       }, {
+               .name = "merge_3d_1", .id = MERGE_3D_1,
+               .base = 0x83100, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       }, {
+               .name = "merge_3d_2", .id = MERGE_3D_2,
+               .base = 0x83200, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       },
 };
 
 static const struct dpu_dsc_cfg sc8180x_dsc[] = {

diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_0_sm8250.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_0_sm8250.h
index e226f19..77586b4 100644 (file)
--- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_0_sm8250.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_6_0_sm8250.h
@@ -239,9 +239,19 @@ static const struct dpu_pingpong_cfg sm8250_pp[] = {
 };
 
 static const struct dpu_merge_3d_cfg sm8250_merge_3d[] = {
-       MERGE_3D_BLK("merge_3d_0", MERGE_3D_0, 0x83000),
-       MERGE_3D_BLK("merge_3d_1", MERGE_3D_1, 0x83100),
-       MERGE_3D_BLK("merge_3d_2", MERGE_3D_2, 0x83200),
+       {
+               .name = "merge_3d_0", .id = MERGE_3D_0,
+               .base = 0x83000, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       }, {
+               .name = "merge_3d_1", .id = MERGE_3D_1,
+               .base = 0x83100, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       }, {
+               .name = "merge_3d_2", .id = MERGE_3D_2,
+               .base = 0x83200, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       },
 };
 
 static const struct dpu_dsc_cfg sm8250_dsc[] = {

diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_0_sm8350.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_0_sm8350.h
index a0456bb..696aa70 100644 (file)
--- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_0_sm8350.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_0_sm8350.h
@@ -237,9 +237,19 @@ static const struct dpu_pingpong_cfg sm8350_pp[] = {
 };
 
 static const struct dpu_merge_3d_cfg sm8350_merge_3d[] = {
-       MERGE_3D_BLK("merge_3d_0", MERGE_3D_0, 0x4e000),
-       MERGE_3D_BLK("merge_3d_1", MERGE_3D_1, 0x4f000),
-       MERGE_3D_BLK("merge_3d_2", MERGE_3D_2, 0x50000),
+       {
+               .name = "merge_3d_0", .id = MERGE_3D_0,
+               .base = 0x4e000, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       }, {
+               .name = "merge_3d_1", .id = MERGE_3D_1,
+               .base = 0x4f000, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       }, {
+               .name = "merge_3d_2", .id = MERGE_3D_2,
+               .base = 0x50000, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       },
 };
 
 /*

diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h
index 63bbe0c..ae43dad 100644 (file)
--- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h
@@ -235,9 +235,19 @@ static const struct dpu_pingpong_cfg sc8280xp_pp[] = {
 };
 
 static const struct dpu_merge_3d_cfg sc8280xp_merge_3d[] = {
-       MERGE_3D_BLK("merge_3d_0", MERGE_3D_0, 0x4e000),
-       MERGE_3D_BLK("merge_3d_1", MERGE_3D_1, 0x4f000),
-       MERGE_3D_BLK("merge_3d_2", MERGE_3D_2, 0x50000),
+       {
+               .name = "merge_3d_0", .id = MERGE_3D_0,
+               .base = 0x4e000, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       }, {
+               .name = "merge_3d_1", .id = MERGE_3D_1,
+               .base = 0x4f000, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       }, {
+               .name = "merge_3d_2", .id = MERGE_3D_2,
+               .base = 0x50000, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       },
 };
 
 /*

diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_1_sm8450.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_1_sm8450.h
index a7408d0..21a9fa7 100644 (file)
--- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_1_sm8450.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_1_sm8450.h
@@ -247,10 +247,23 @@ static const struct dpu_pingpong_cfg sm8450_pp[] = {
 };
 
 static const struct dpu_merge_3d_cfg sm8450_merge_3d[] = {
-       MERGE_3D_BLK("merge_3d_0", MERGE_3D_0, 0x4e000),
-       MERGE_3D_BLK("merge_3d_1", MERGE_3D_1, 0x4f000),
-       MERGE_3D_BLK("merge_3d_2", MERGE_3D_2, 0x50000),
-       MERGE_3D_BLK("merge_3d_3", MERGE_3D_3, 0x65f00),
+       {
+               .name = "merge_3d_0", .id = MERGE_3D_0,
+               .base = 0x4e000, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       }, {
+               .name = "merge_3d_1", .id = MERGE_3D_1,
+               .base = 0x4f000, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       }, {
+               .name = "merge_3d_2", .id = MERGE_3D_2,
+               .base = 0x50000, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       }, {
+               .name = "merge_3d_3", .id = MERGE_3D_3,
+               .base = 0x65f00, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       },
 };
 
 /*

diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_0_sm8550.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_0_sm8550.h
index a1fd282..eea51a1 100644 (file)
--- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_0_sm8550.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_0_sm8550.h
@@ -261,10 +261,23 @@ static const struct dpu_pingpong_cfg sm8550_pp[] = {
 };
 
 static const struct dpu_merge_3d_cfg sm8550_merge_3d[] = {
-       MERGE_3D_BLK("merge_3d_0", MERGE_3D_0, 0x4e000),
-       MERGE_3D_BLK("merge_3d_1", MERGE_3D_1, 0x4f000),
-       MERGE_3D_BLK("merge_3d_2", MERGE_3D_2, 0x50000),
-       MERGE_3D_BLK("merge_3d_3", MERGE_3D_3, 0x66700),
+       {
+               .name = "merge_3d_0", .id = MERGE_3D_0,
+               .base = 0x4e000, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       }, {
+               .name = "merge_3d_1", .id = MERGE_3D_1,
+               .base = 0x4f000, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       }, {
+               .name = "merge_3d_2", .id = MERGE_3D_2,
+               .base = 0x50000, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       }, {
+               .name = "merge_3d_3", .id = MERGE_3D_3,
+               .base = 0x66700, .len = 0x8,
+               .features = MERGE_3D_SM8150_MASK,
+       },
 };
 
 /*

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
index e81fbd1..b1c96cd 100644 (file)
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
@@ -472,17 +472,6 @@ static const struct dpu_pingpong_sub_blks sc7280_pp_sblk = {
        }
 
 /*************************************************************
- * MERGE_3D sub blocks config
- *************************************************************/
-#define MERGE_3D_BLK(_name, _id, _base) \
-       {\
-       .name = _name, .id = _id, \
-       .base = _base, .len = 0x8, \
-       .features = MERGE_3D_SM8150_MASK, \
-       .sblk = NULL \
-       }
-
-/*************************************************************
  * DSC sub blocks config
  *************************************************************/
 static const struct dpu_dsc_sub_blks dsc_sblk_0 = {