ALSA: hda: remove redundant variable in snd_hdac_stream_start()

This 2nd variables are all set as true in treewide. So I think
it can be removed for easy understanding.

Signed-off-by: Zhang Yiqun <zhangyiqun@phytium.com.cn>
Acked-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20230209121723.14328-1-zhangyiqun@phytium.com.cn
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h
index a687253..536612c 100644 (file)
--- a/include/sound/hdaudio.h
+++ b/include/sound/hdaudio.h
@@ -575,7 +575,7 @@ void snd_hdac_stream_cleanup(struct hdac_stream *azx_dev);
 int snd_hdac_stream_setup_periods(struct hdac_stream *azx_dev);
 int snd_hdac_stream_set_params(struct hdac_stream *azx_dev,
                                unsigned int format_val);
-void snd_hdac_stream_start(struct hdac_stream *azx_dev, bool fresh_start);
+void snd_hdac_stream_start(struct hdac_stream *azx_dev);
 void snd_hdac_stream_stop(struct hdac_stream *azx_dev);
 void snd_hdac_stop_streams(struct hdac_bus *bus);
 void snd_hdac_stop_streams_and_chip(struct hdac_bus *bus);

diff --git a/sound/hda/hdac_stream.c b/sound/hda/hdac_stream.c
index 547adbc..1f56fd3 100644 (file)
--- a/sound/hda/hdac_stream.c
+++ b/sound/hda/hdac_stream.c
@@ -124,11 +124,10 @@ EXPORT_SYMBOL_GPL(snd_hdac_stream_init);
 /**
  * snd_hdac_stream_start - start a stream
  * @azx_dev: HD-audio core stream to start
- * @fresh_start: false = wallclock timestamp relative to period wallclock
  *
  * Start a stream, set start_wallclk and set the running flag.
  */
-void snd_hdac_stream_start(struct hdac_stream *azx_dev, bool fresh_start)
+void snd_hdac_stream_start(struct hdac_stream *azx_dev)
 {
        struct hdac_bus *bus = azx_dev->bus;
        int stripe_ctl;
@@ -136,8 +135,6 @@ void snd_hdac_stream_start(struct hdac_stream *azx_dev, bool fresh_start)
        trace_snd_hdac_stream_start(bus, azx_dev);
 
        azx_dev->start_wallclk = snd_hdac_chip_readl(bus, WALLCLK);
-       if (!fresh_start)
-               azx_dev->start_wallclk -= azx_dev->period_wallclk;
 
        /* enable SIE */
        snd_hdac_chip_updatel(bus, INTCTL,
@@ -966,7 +963,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_dsp_prepare);
 void snd_hdac_dsp_trigger(struct hdac_stream *azx_dev, bool start)
 {
        if (start)
-               snd_hdac_stream_start(azx_dev, true);
+               snd_hdac_stream_start(azx_dev);
        else
                snd_hdac_stream_stop(azx_dev);
 }

diff --git a/sound/pci/hda/hda_controller.c b/sound/pci/hda/hda_controller.c
index 083df28..4067796 100644 (file)
--- a/sound/pci/hda/hda_controller.c
+++ b/sound/pci/hda/hda_controller.c
@@ -257,7 +257,7 @@ static int azx_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
                azx_dev = get_azx_dev(s);
                if (start) {
                        azx_dev->insufficient = 1;
-                       snd_hdac_stream_start(azx_stream(azx_dev), true);
+                       snd_hdac_stream_start(azx_stream(azx_dev));
                } else {
                        snd_hdac_stream_stop(azx_stream(azx_dev));
                }

diff --git a/sound/soc/intel/avs/pcm.c b/sound/soc/intel/avs/pcm.c
index f930c5e..b673b84 100644 (file)
--- a/sound/soc/intel/avs/pcm.c
+++ b/sound/soc/intel/avs/pcm.c
@@ -647,7 +647,7 @@ static int avs_dai_fe_trigger(struct snd_pcm_substream *substream, int cmd, stru
        case SNDRV_PCM_TRIGGER_START:
        case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
                spin_lock_irqsave(&bus->reg_lock, flags);
-               snd_hdac_stream_start(hdac_stream(host_stream), true);
+               snd_hdac_stream_start(hdac_stream(host_stream));
                spin_unlock_irqrestore(&bus->reg_lock, flags);
 
                /* Timeout on DRSM poll shall not stop the resume so ignore the result. */

diff --git a/sound/soc/intel/avs/probes.c b/sound/soc/intel/avs/probes.c
index 29d63f2..741565c 100644 (file)
--- a/sound/soc/intel/avs/probes.c
+++ b/sound/soc/intel/avs/probes.c
@@ -190,7 +190,7 @@ static int avs_probe_compr_trigger(struct snd_compr_stream *cstream, int cmd,
        case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
        case SNDRV_PCM_TRIGGER_RESUME:
                spin_lock_irqsave(&bus->reg_lock, cookie);
-               snd_hdac_stream_start(hdac_stream(host_stream), true);
+               snd_hdac_stream_start(hdac_stream(host_stream));
                spin_unlock_irqrestore(&bus->reg_lock, cookie);
                break;
 

diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c
index dc627d1..a4209d8 100644 (file)
--- a/sound/soc/intel/skylake/skl-pcm.c
+++ b/sound/soc/intel/skylake/skl-pcm.c
@@ -449,7 +449,7 @@ static int skl_decoupled_trigger(struct snd_pcm_substream *substream,
        spin_lock_irqsave(&bus->reg_lock, cookie);
 
        if (start) {
-               snd_hdac_stream_start(hdac_stream(stream), true);
+               snd_hdac_stream_start(hdac_stream(stream));
                snd_hdac_stream_timecounter_init(hstr, 0);
        } else {
                snd_hdac_stream_stop(hdac_stream(stream));
@@ -1134,7 +1134,7 @@ static int skl_coupled_trigger(struct snd_pcm_substream *substream,
                        continue;
                stream = get_hdac_ext_stream(s);
                if (start)
-                       snd_hdac_stream_start(hdac_stream(stream), true);
+                       snd_hdac_stream_start(hdac_stream(stream));
                else
                        snd_hdac_stream_stop(hdac_stream(stream));
        }