net: hinic: Make use of the helper function dev_err_probe()
authorCai Huoqing <caihuoqing@baidu.com>
Wed, 15 Sep 2021 14:58:34 +0000 (22:58 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 16 Sep 2021 12:35:35 +0000 (13:35 +0100)
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and simplify the code.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/huawei/hinic/hinic_main.c

index ae707e3..9965e8d 100644 (file)
@@ -1379,10 +1379,8 @@ static int hinic_probe(struct pci_dev *pdev,
 {
        int err = pci_enable_device(pdev);
 
-       if (err) {
-               dev_err(&pdev->dev, "Failed to enable PCI device\n");
-               return err;
-       }
+       if (err)
+               return dev_err_probe(&pdev->dev, err, "Failed to enable PCI device\n");
 
        err = pci_request_regions(pdev, HINIC_DRV_NAME);
        if (err) {