Test: remove QSKIP from tst_LargeFile::mapOffsetOverflow

Instead omit the whole test when Q_OS_MAC is defined.

Change-Id: I7d35c99ecd69b3c5bb8f8590342edd9665300709
Reviewed-by: J-P Nurmi <jpnurmi@digia.com>
Reviewed-by: Sergio Ahumada <sergio.ahumada@digia.com>

diff --git a/tests/auto/corelib/io/largefile/tst_largefile.cpp b/tests/auto/corelib/io/largefile/tst_largefile.cpp
index 25b3c05..ce5da82 100644 (file)
--- a/tests/auto/corelib/io/largefile/tst_largefile.cpp
+++ b/tests/auto/corelib/io/largefile/tst_largefile.cpp
@@ -121,7 +121,9 @@ private slots:
 
     // Map/unmap large file
     void mapFile();
+#ifndef Q_OS_MAC
     void mapOffsetOverflow();
+#endif
 
     void closeFile() { largeFile.close(); }
 
@@ -510,12 +512,10 @@ void tst_LargeFile::mapFile()
     QVERIFY( largeFile.unmap( baseAddress ) );
 }
 
+//Mac: memory-mapping beyond EOF may succeed but it could generate bus error on access
+#ifndef Q_OS_MAC
 void tst_LargeFile::mapOffsetOverflow()
 {
-#if defined(Q_OS_MAC)
-    QSKIP("mmap'ping beyond EOF may succeed; generate bus error on access");
-#endif
-
     // Out-of-range mappings should fail, and not silently clip the offset
     for (int i = 50; i < 63; ++i) {
         uchar *address = 0;
@@ -530,6 +530,7 @@ void tst_LargeFile::mapOffsetOverflow()
         QVERIFY( !address );
     }
 }
+#endif
 
 QTEST_APPLESS_MAIN(tst_LargeFile)
 #include "tst_largefile.moc"