- Add FREE(x) to fix memory leak.
- Add return check when calling APIs.
- Add NULL check.
Change-Id: Ib38253ca6f2654105b86c48b5d4899f76bcd62ae
Signed-off-by: jinwang.an <jinwang.an@samsung.com>
src/setting-vibration.c
src/setting-connection.c
src/setting-clock.c
- src/setting-homescreen.c
+# src/setting-homescreen.c
# src/setting-volume.c
src/setting-volume-page.c
src/setting-info.c
src/setting-language.c
src/setting-safety.c
# src/setting-reset.c
- src/setting-battery.c
+# src/setting-battery.c
src/setting-common-sound.c
src/util.c
src/setting_data_vconf.c
static Evas_Object *g_font_genlist = NULL;
-static char *font_name = NULL;
static int font_size_index = 1; /* default: normal */
static Elm_Object_Item *font_style_item = NULL;
/*elm_radio_value_set(g_app_context->font_style_rdg, id->index); */
-
- if (id->font_name) {
- FREE(font_name);
- font_name = strdup(id->font_name);
+ if (id && id->font_name) {
+ system_settings_set_value_string(SYSTEM_SETTINGS_KEY_FONT_TYPE, id->font_name);
}
/*elm_genlist_realized_items_update(g_font_style_genlist); */
g_app_context->font_style_rdg = NULL;
}
- if (font_name) {
- system_settings_set_value_string(SYSTEM_SETTINGS_KEY_FONT_TYPE, font_name);
- FREE(font_name);
- } else {
- ERR("font_name is null");
- }
g_font_style_genlist = NULL;
back_key_generic_cb(g_app_context, obj, event_info);
if (system_settings_get_value_int(SYSTEM_SETTINGS_KEY_FONT_SIZE, &old_font_size)
!= SYSTEM_SETTINGS_ERROR_NONE) {
- DBG("Setting - system_settings_get_value_int() is failed.");
+ DBG("Setting - system_settings_get_value_int(SYSTEM_SETTINGS_KEY_FONT_SIZE) is failed.");
+ back_key_generic_cb(g_app_context, obj, event_info);
return;
}
DBG("Setting - old font size is %d.", old_font_size);
if (old_font_size != font_size_index) {
DBG("Setting - font size is same with old.");
- system_settings_set_value_int(SYSTEM_SETTINGS_KEY_FONT_SIZE, font_size_index);
+ if (system_settings_set_value_int(SYSTEM_SETTINGS_KEY_FONT_SIZE, font_size_index)
+ != SYSTEM_SETTINGS_ERROR_NONE){
+ ERR("Setting - system_settings_set_value_int(SYSTEM_SETTINGS_KEY_FONT_SIZE) is failed.");
+ back_key_generic_cb(g_app_context, obj, event_info);
+ return;
+ }
if (font_size_item) {
elm_genlist_item_update(font_size_item);
}
if (eina_list_data_find(list, family_result) == NULL) {
- list = eina_list_append(list, strdup(family_result));
- DBG("-------- ADDED FONT - family result = %s", (char *)family_result);
+ if (family_result) {
+ list = eina_list_append(list, strdup(family_result));
+ DBG("-------- ADDED FONT - family result = %s", (char *)family_result);
+ } else {
+ ERR("ADD FONT FAIL, family_result is null");
+ }
}
}
elm_genlist_item_class_free(title_item);
- FREE(font_name);
ret = system_settings_get_value_string(SYSTEM_SETTINGS_KEY_FONT_TYPE, &tmp_name);
if (ret != SYSTEM_SETTINGS_ERROR_NONE) {
ERR("failed to call system_setting_get_value_string with err %d", ret);
Font_Style_Item_Data *id_default = calloc(sizeof(Font_Style_Item_Data), 1);
if (default_font_name && tmp_name && !strcmp(tmp_name, default_font_name)) {
matched_idx = idx;
- font_name = strdup(tmp_name);
}
if (id_default) {
id_default->index = idx++;
Font_Style_Item_Data *id = calloc(sizeof(Font_Style_Item_Data), 1);
if (tmp_name && !strcmp((const char *)tmp_name, (const char *)font_data)) {
matched_idx = idx;
- font_name = strdup(tmp_name);
}
DBG("font_data -------> %s", (const char *)font_data);
itc->func.content_get = _gl_font_style_ridio_get;
itc->func.del = _font_style_gl_del;
- FREE(font_name);
ret = system_settings_get_value_string(SYSTEM_SETTINGS_KEY_FONT_TYPE, &tmp_name);
if (ret != SYSTEM_SETTINGS_ERROR_NONE) {
ERR("failed to call system_setting_get_value_string with err %d", ret);
Font_Style_Item_Data *id_default = calloc(sizeof(Font_Style_Item_Data), 1);
if (default_font_name && tmp_name && !strcmp(tmp_name, default_font_name)) {
matched_idx = idx;
- font_name = strdup(tmp_name);
}
if (id_default) {
id_default->index = idx++;
Font_Style_Item_Data *id = calloc(sizeof(Font_Style_Item_Data), 1);
if (tmp_name && !strcmp((const char *)tmp_name, (const char *)font_data)) {
matched_idx = idx;
- font_name = strdup(tmp_name);
}
DBG("Font1: %s, Font2: %s", tmp_name, font_data);
int get_sound_type(sound_stream_type_e stream_type)
{
sound_stream_info_h stream_info = NULL;
- sound_manager_create_stream_information(stream_type, NULL, NULL, &stream_info);
+ int ret = sound_manager_create_stream_information(stream_type, NULL, NULL, &stream_info);
+ if (ret != SOUND_MANAGER_ERROR_NONE) {
+ ERR("sound_manager_create_stream_information() get failed with err[%d, 0x%x]", ret, ret);
+ return ret;
+ }
sound_type_e type;
sound_manager_get_sound_type(stream_info, &type);
sound_manager_destroy_stream_information(stream_info);
int get_sound_internal_type(sound_stream_type_internal_e stream_type)
{
sound_stream_info_h stream_info = NULL;
- sound_manager_create_stream_information_internal(stream_type, NULL, NULL, &stream_info);
+ int ret = sound_manager_create_stream_information_internal(stream_type, NULL, NULL, &stream_info);
+ if (ret != SOUND_MANAGER_ERROR_NONE) {
+ ERR("sound_manager_create_stream_information_internal() get failed with err[%d, 0x%x]", ret, ret);
+ return ret;
+ }
sound_type_e type;
sound_manager_get_sound_type(stream_info, &type);
sound_manager_destroy_stream_information(stream_info);
DBG("Setting - profile_play_sound is creating.");
sound_stream_info_h stream_info = NULL;
- if (stream_type == SOUND_STREAM_TYPE_RINGTONE_CALL)
- sound_manager_create_stream_information_internal(stream_type, NULL, NULL, &stream_info);
- else
- sound_manager_create_stream_information(stream_type, NULL, NULL, &stream_info);
+ if (stream_type == SOUND_STREAM_TYPE_RINGTONE_CALL) {
+ int ret = sound_manager_create_stream_information_internal(stream_type, NULL, NULL, &stream_info);
+ if (ret != SOUND_MANAGER_ERROR_NONE) {
+ ERR("sound_manager_create_stream_information_internal() get failed with err[%d, 0x%x]", ret, ret);
+ return ret;
+ }
+ } else {
+ int ret = sound_manager_create_stream_information(stream_type, NULL, NULL, &stream_info);
+ if (ret != SOUND_MANAGER_ERROR_NONE) {
+ ERR("sound_manager_create_stream_information() get failed with err[%d, 0x%x]", ret, ret);
+ return ret;
+ }
+ }
int err = 0;
err = player_create(&player);
if (err != PLAYER_ERROR_NONE) {
- DBG("Setting - creating the player handle failed[%d]", err);
+ ERR("Setting - creating the player handle failed[%d]", err);
return 0;
}
err = player_set_sound_stream_info(player, stream_info);
if (err != PLAYER_ERROR_NONE) {
- DBG("Setting - error to set stream_info[%d]", err);
+ ERR("Setting - error to set stream_info[%d]", err);
player_destroy(player);
is_player_created = 0;
sound_manager_destroy_stream_information(stream_info);
err = player_set_uri(player, ringtone_file);
if (err != PLAYER_ERROR_NONE) {
- DBG("Setting - error to set attribute---profile_uri[%d]", err);
+ ERR("Setting - error to set attribute---profile_uri[%d]", err);
player_destroy(player);
is_player_created = 0;
sound_manager_destroy_stream_information(stream_info);
err = player_prepare_async(player, _profile_player_prepare_cb, NULL);
if (err != PLAYER_ERROR_NONE) {
- DBG("Setting - realizing the player handle failed[%d]", err);
+ ERR("Setting - realizing the player handle failed[%d]", err);
player_destroy(player);
is_player_created = 0;
sound_manager_destroy_stream_information(stream_info);
layout = elm_layout_add(popup);
elm_layout_theme_set(layout, "layout", "popup", "content/circle/buttons2");
- char *txt = strdup(buf);
- elm_object_text_set(layout, txt);
+ elm_object_text_set(layout, buf);
elm_object_content_set(popup, layout);
- FREE(txt);
btn1 = elm_button_add(popup);
elm_object_style_set(btn1, "popup/circle/left");
char buf[1024];
char *font_size_frame = "<text_class=tizen><align=center><font_size=28>%s</font_size></align></text_class>";
- snprintf(buf, sizeof(buf) - 1, font_size_frame, elm_entry_utf8_to_markup(_("WDS_ST_POP_OPEN_THE_LAST_APP_YOU_USED_BY_PRESSING_THE_HOME_KEY_TWICE_ON_WATCH_FACE_ABB")));
+ char *out_string = elm_entry_utf8_to_markup(_("WDS_ST_POP_OPEN_THE_LAST_APP_YOU_USED_BY_PRESSING_THE_HOME_KEY_TWICE_ON_WATCH_FACE_ABB"));
+ snprintf(buf, sizeof(buf) - 1, font_size_frame, out_string);
- char *txt = strdup(buf);
- elm_object_text_set(popup, txt);
- FREE(txt);
+ FREE(out_string);
+
+ elm_object_text_set(popup, buf);
_screen_reader_information_set(popup);
btn = elm_button_add(popup);
/* Main display list item */
static Elm_Object_Item *lang_item = NULL;
static Elm_Object_Item *wake_up_item = NULL;
-static Elm_Object_Item *edit_icon_item = NULL;
static Elm_Object_Item *g_screen_time_item = NULL;
static void change_language_enabling(keynode_t *key, void *data);
} else if (!strcmp(part, "elm.text.1")) {
char *text_color = "<font color=#4DCFFFC9>%s</font>";
const char *curr_lang = setting_get_lang_title();
- if (id->item == edit_icon_item) {
- char *str = _get_homeview_type_subtitle();
- snprintf(buf, sizeof(buf) - 1, text_color, str);
- FREE(str);
- } else if (id->item == lang_item) {
+ if (id->item == lang_item) {
if (curr_lang) {
if (is_connected_GM()) {
snprintf(buf, sizeof(buf) - 1, "<font color=#515151>%s</font>", curr_lang);
Elm_Genlist_Item_Class *itc_tmp = NULL;
if (menu_its[idx].type == SETTING_DISPLAY_GESTURE
- || menu_its[idx].type == SETTING_DISPLAY_ICON_SIZE
|| menu_its[idx].type == SETTING_DISPLAY_LANG
|| menu_its[idx].type == SETTING_DISPLAY_SCREEN_TIME) {
itc_tmp = itc2;
} else if (menu_its[idx].type == SETTING_DISPLAY_GESTURE) {
DBG("wakeup item@!!!");
wake_up_item = id->item;
- } else if (menu_its[idx].type == SETTING_DISPLAY_ICON_SIZE) {
- DBG("edit icon item@!!!");
- edit_icon_item = id->item;
} else if (menu_its[idx].type == SETTING_DISPLAY_SCREEN_TIME) {
DBG("screen time item@!!!");
g_screen_time_item = id->item;
} else {
snprintf(buf, sizeof(buf) - 1, "%s", device_info);
}
+ FREE(device_info);
break;
case ABOUT_DEVICE_SOFTWARE_VERSION:
/*#endif */
if (system_info_get_platform_string("http://tizen.org/system/build.string", &device_info)
!= SYSTEM_INFO_ERROR_NONE) {
DBG("Setting - Version name do not get!! error!!");
- snprintf(buf, sizeof(buf) - 1, "%s", "V700XXUAMJ1");
+ snprintf(buf, sizeof(buf) - 1, "%s", _("IDS_ST_BODY_UNKNOWN"));
} else {
snprintf(buf, sizeof(buf) - 1, "%s", device_info);
}
+ FREE(device_info);
break;
case ABOUT_DEVICE_BLUETOOTH_ADDRESS:
_get_bluetooth_address_string(buf, sizeof(buf)-1);
} else {
snprintf(buf, sizeof(buf) - 1, "%s", device_info);
}
+ FREE(device_info);
break;
/*#ifndef FEATURE_SETTING_SDK */
case ABOUT_DEVICE_SERIAL_NUMBER:
struct _lang_menu_item *pitem = (struct _lang_menu_item *)calloc(1, sizeof(struct _lang_menu_item));
if (pitem) {
- pitem->id = id;
+ pitem->id = strdup(id);
pitem->name = strdup(name);
sub_name = strdup(name);
s_langlist = eina_list_append(s_langlist, pitem);
}
+ FREE(id);
FREE(name);
}
}
static char *
_gl_menu_title_text_get(void *data, Evas_Object *obj, const char *part)
{
- char buf[1024];
+ char buf[1024] = {0,};
int title_idx = (uintptr_t)data;
switch (title_idx) {
case VIBRATION_TITLE_VIBRATION:
switch (index) {
case 0:
vibrate_type = get_vibration_level();
- snprintf(buf, sizeof(buf) - 1, text_color, _(vibration_power_str[vibrate_type % 3]));
+ snprintf(buf, sizeof(buf) - 1, text_color, _(vibration_power_str[vibrate_type % 2]));
break;
case 1:
snprintf(buf, sizeof(buf) - 1, text_color, "For notifications");
printf("Added : %d\n", i);
elm_index_item_append(pd->index, NULL, NULL, (void *)(uintptr_t)i);
}
- pd->min_page = pd->cur_page;
pd->min_page = pd->cur_page + num_index - 1;
} else {
for (i = pd->cur_page - num_index + 1; i < pd->cur_page + 1 ; i++) {
printf("Added : %d\n", i);
elm_index_item_append(pd->index, NULL, NULL, (void *)(uintptr_t)i);
}
- pd->min_page = pd->cur_page - num_index;
pd->min_page = pd->cur_page - 1;
}
elm_index_level_go(pd->index, 0);
const char *sound_path = NULL;
int temp_volume_index = 0;
switch (sound_type) {
- case SOUND_STREAM_TYPE_RINGTONE_CALL:
- temp_volume_index = volume_index;
+ case SOUND_STREAM_TYPE_RINGTONE_CALL: {
+ temp_volume_index = volume_index;
- int ret_vconf = vconf_set_int(VCONFKEY_SETAPPL_CALL_RINGTONE_SOUND_VOLUME_INT, temp_volume_index);
- vconf_set_int("db/setting/sound/call/rmd_ringtone_volume", temp_volume_index); /* backup ringtone volume */
+ int ret_vconf = vconf_set_int(VCONFKEY_SETAPPL_CALL_RINGTONE_SOUND_VOLUME_INT, temp_volume_index);
+ vconf_set_int("db/setting/sound/call/rmd_ringtone_volume", temp_volume_index); /* backup ringtone volume */
- /*_set_volumn(sound_type, volume_index, VCONFKEY_SETAPPL_CALL_RINGTONE_SOUND_VOLUME_INT); */
+ /*_set_volumn(sound_type, volume_index, VCONFKEY_SETAPPL_CALL_RINGTONE_SOUND_VOLUME_INT); */
- ERR("vconf_name SET INT : %s = %d, ret %d", VCONFKEY_SETAPPL_CALL_RINGTONE_SOUND_VOLUME_INT, temp_volume_index, ret_vconf);
+ ERR("vconf_name SET INT : %s = %d, ret %d", VCONFKEY_SETAPPL_CALL_RINGTONE_SOUND_VOLUME_INT, temp_volume_index, ret_vconf);
- sound_path = vconf_get_str(VCONFKEY_SETAPPL_CALL_RINGTONE_PATH_STR);
- if (sound_path) {
- snprintf(buf, sizeof(buf)-1, "%s", sound_path);
- } else {
- snprintf(buf, sizeof(buf)-1, "%s", VCONFKEY_SETAPPL_CALL_RINGTONE_DEFAULT_PATH_STR);
- }
+ sound_path = vconf_get_str(VCONFKEY_SETAPPL_CALL_RINGTONE_PATH_STR);
+ if (sound_path) {
+ snprintf(buf, sizeof(buf)-1, "%s", sound_path);
+ } else {
+ snprintf(buf, sizeof(buf)-1, "%s", VCONFKEY_SETAPPL_CALL_RINGTONE_DEFAULT_PATH_STR);
+ }
- break;
+ break;
+ }
case SOUND_STREAM_TYPE_MEDIA:
_set_volumn(sound_type, volume_index, VCONFKEY_SETAPPL_MEDIA_SOUND_VOLUME_INT);
#include "setting-sound.h"
#include "setting-volume.h"
#include "setting-clock.h"
-#include "setting-homescreen.h"
#include "setting-info.h"
#include "setting-bluetooth.h"
#include "setting-motion.h"
#include "setting-display.h"
#include "setting-language.h"
-#include "setting-battery.h"
#include "setting-device.h"
#include "setting-privacy.h"
#include "setting-connection.h"
eext_circle_surface_del(ad->circle_surface);
- int ret = system_settings_unset_changed_cb(SYSTEM_SETTINGS_KEY_LOCALE_TIMEZONE);
- DBG("locale tzone unset cb ret = %s", get_error_message(ret));
+ /*int ret = system_settings_unset_changed_cb(SYSTEM_SETTINGS_KEY_LOCALE_TIMEZONE); */
+ /*DBG("locale tzone unset cb ret = %s", get_error_message(ret)); */
}
void app_pause(void *data)
} else if (ad->MENU_TYPE == SETTING_SOUND_RINGTONE ||
ad->MENU_TYPE == SETTING_SOUND_NOTIFICATION) {
_stop_all_sound_play();
- } else if (ad->MENU_TYPE == SETTING_BATTERY) {
- _clear_battery_cb(NULL, NULL, NULL, NULL);
} else if (ad->MENU_TYPE == SETTING_SOUND) {
_stop_all_sound_play();
}
event_callback.app_control = app_reset;
ui_app_add_event_handler(&handlers[APP_EVENT_LOW_MEMORY], APP_EVENT_LOW_MEMORY, NULL, NULL);
- ui_app_add_event_handler(&handlers[APP_EVENT_LOW_BATTERY], APP_EVENT_LOW_BATTERY, NULL, NULL);
ui_app_add_event_handler(&handlers[APP_EVENT_LANGUAGE_CHANGED], APP_EVENT_LANGUAGE_CHANGED, _lang_changed, NULL);
ui_app_add_event_handler(&handlers[APP_EVENT_REGION_FORMAT_CHANGED], APP_EVENT_REGION_FORMAT_CHANGED, NULL, NULL);
ui_app_add_event_handler(&handlers[APP_EVENT_DEVICE_ORIENTATION_CHANGED], APP_EVENT_DEVICE_ORIENTATION_CHANGED, NULL, NULL);