Call init_cpu_features only if SHARED is defined
authorH.J. Lu <hjl.tools@gmail.com>
Fri, 13 May 2016 15:29:22 +0000 (08:29 -0700)
committerH.J. Lu <hjl.tools@gmail.com>
Fri, 13 May 2016 15:29:33 +0000 (08:29 -0700)
In static executable, since init_cpu_features is called early from
__libc_start_main, there is no need to call it again in dl_platform_init.

[BZ #20072]
* sysdeps/i386/dl-machine.h (dl_platform_init): Call
init_cpu_features only if SHARED is defined.
* sysdeps/x86_64/dl-machine.h (dl_platform_init): Likewise.

ChangeLog
sysdeps/i386/dl-machine.h
sysdeps/x86_64/dl-machine.h

index 05d0fe7..8ccf928 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2016-05-13  H.J. Lu  <hongjiu.lu@intel.com>
 
+       [BZ #20072]
+       * sysdeps/i386/dl-machine.h (dl_platform_init): Call
+       init_cpu_features only if SHARED is defined.
+       * sysdeps/x86_64/dl-machine.h (dl_platform_init): Likewise.
+
+2016-05-13  H.J. Lu  <hongjiu.lu@intel.com>
+
        * sysdeps/x86/cacheinfo.c (init_cacheinfo): Check and support
        non-inclusive caches on Intel processors.
 
index 130bcf5..4e3968a 100644 (file)
@@ -237,7 +237,11 @@ dl_platform_init (void)
     /* Avoid an empty string which would disturb us.  */
     GLRO(dl_platform) = NULL;
 
+#ifdef SHARED
+  /* init_cpu_features has been called early from __libc_start_main in
+     static executable.  */
   init_cpu_features (&GLRO(dl_x86_cpu_features));
+#endif
 }
 
 static inline Elf32_Addr
index 980ca73..ed0c1a8 100644 (file)
@@ -224,7 +224,11 @@ dl_platform_init (void)
     /* Avoid an empty string which would disturb us.  */
     GLRO(dl_platform) = NULL;
 
+#ifdef SHARED
+  /* init_cpu_features has been called early from __libc_start_main in
+     static executable.  */
   init_cpu_features (&GLRO(dl_x86_cpu_features));
+#endif
 }
 
 static inline ElfW(Addr)