Fix a few nits in RenamingAction.

* Add missing override keyword.
* avoid unnecessary copy of std::string.

llvm-svn: 316152

diff --git a/clang/lib/Tooling/Refactoring/Rename/RenamingAction.cpp b/clang/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
index fdff6fd636ad5bcebc52c60c103362680990a124..28912c3e139fe181d5fd99bf108f225e0ea465d9 100644 (file)
--- a/clang/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
+++ b/clang/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
@@ -77,10 +77,10 @@ private:
 class RenameOccurrences final : public SourceChangeRefactoringRule {
 public:
   RenameOccurrences(const NamedDecl *ND, std::string NewName)
-      : Finder(ND), NewName(NewName) {}
+      : Finder(ND), NewName(std::move(NewName)) {}
 
   Expected<AtomicChanges>
-  createSourceReplacements(RefactoringRuleContext &Context) {
+  createSourceReplacements(RefactoringRuleContext &Context) override {
     Expected<SymbolOccurrences> Occurrences =
         Finder.findSymbolOccurrences(Context);
     if (!Occurrences)