media: exynos4-is: Fix runtime PM imbalance in fimc_is_probe
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Sun, 24 May 2020 02:59:02 +0000 (04:59 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 23 Jun 2020 11:20:48 +0000 (13:20 +0200)
pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced. For all error
paths after pm_runtime_get_sync(), things are the same.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/exynos4-is/fimc-is.c

index 64148b7..a474014 100644 (file)
@@ -871,6 +871,7 @@ err_dfs:
 err_sd:
        fimc_is_unregister_subdevs(is);
 err_pm:
+       pm_runtime_put_noidle(dev);
        if (!pm_runtime_enabled(dev))
                fimc_is_runtime_suspend(dev);
 err_irq: