spi: tegra114: Add missing IRQ check in tegra_spi_probe

This func misses checking for platform_get_irq()'s call and may passes the
negative error codes to request_threaded_irq(), which takes unsigned IRQ #,
causing it to fail with -EINVAL, overriding an original error code.
Stop calling request_threaded_irq() with invalid IRQ #s.

Fixes: f333a331adfa ("spi/tegra114: add spi driver")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220128165238.25615-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
index e9de1d958bbd2a0cb595450b5d3ad3fae23e30c8..8f345247a8c3221417c2f9df498b4d39a2727a40 100644 (file)
--- a/drivers/spi/spi-tegra114.c
+++ b/drivers/spi/spi-tegra114.c
@@ -1352,6 +1352,10 @@ static int tegra_spi_probe(struct platform_device *pdev)
        tspi->phys = r->start;
 
        spi_irq = platform_get_irq(pdev, 0);
+       if (spi_irq < 0) {
+               ret = spi_irq;
+               goto exit_free_master;
+       }
        tspi->irq = spi_irq;
 
        tspi->clk = devm_clk_get(&pdev->dev, "spi");