Revert "[Tizen] Implement partial update"
authorJoogab Yun <joogab.yun@samsung.com>
Mon, 2 Sep 2019 06:56:03 +0000 (15:56 +0900)
committerJoogab Yun <joogab.yun@samsung.com>
Mon, 2 Sep 2019 06:56:03 +0000 (15:56 +0900)
This reverts commit 55827866fcb8c7ee47581ac4335a3390472090e8.

39 files changed:
automated-tests/src/dali/dali-test-suite-utils/test-application.cpp [changed mode: 0755->0644]
automated-tests/src/dali/dali-test-suite-utils/test-render-surface.cpp [changed mode: 0755->0644]
automated-tests/src/dali/dali-test-suite-utils/test-render-surface.h [changed mode: 0755->0644]
dali/devel-api/actors/actor-devel.h [changed mode: 0755->0644]
dali/integration-api/core-enumerations.h [changed mode: 0755->0644]
dali/integration-api/core.cpp [changed mode: 0755->0644]
dali/integration-api/core.h [changed mode: 0755->0644]
dali/integration-api/render-surface.h [changed mode: 0755->0644]
dali/internal/common/core-impl.cpp [changed mode: 0755->0644]
dali/internal/common/core-impl.h [changed mode: 0755->0644]
dali/internal/event/actors/actor-impl.cpp [changed mode: 0755->0644]
dali/internal/event/actors/actor-impl.h
dali/internal/event/common/scene-impl.cpp [changed mode: 0755->0644]
dali/internal/event/rendering/frame-buffer-impl.cpp [changed mode: 0755->0644]
dali/internal/event/rendering/frame-buffer-impl.h [changed mode: 0755->0644]
dali/internal/render/common/render-algorithms.cpp [changed mode: 0755->0644]
dali/internal/render/common/render-algorithms.h [changed mode: 0755->0644]
dali/internal/render/common/render-item.cpp [changed mode: 0755->0644]
dali/internal/render/common/render-item.h [changed mode: 0755->0644]
dali/internal/render/common/render-list.h [changed mode: 0755->0644]
dali/internal/render/common/render-manager.cpp [changed mode: 0755->0644]
dali/internal/render/common/render-manager.h [changed mode: 0755->0644]
dali/internal/render/renderers/render-surface-frame-buffer.cpp [changed mode: 0755->0644]
dali/internal/render/renderers/render-surface-frame-buffer.h [changed mode: 0755->0644]
dali/internal/update/animation/scene-graph-animator.h [changed mode: 0755->0644]
dali/internal/update/common/property-owner-messages.h [changed mode: 0755->0644]
dali/internal/update/common/property-owner.cpp [changed mode: 0755->0644]
dali/internal/update/common/property-owner.h [changed mode: 0755->0644]
dali/internal/update/manager/render-instruction-processor.cpp [changed mode: 0755->0644]
dali/internal/update/manager/transform-manager.cpp [changed mode: 0755->0644]
dali/internal/update/manager/transform-manager.h [changed mode: 0755->0644]
dali/internal/update/manager/update-manager.cpp [changed mode: 0755->0644]
dali/internal/update/nodes/node-declarations.h [changed mode: 0755->0644]
dali/internal/update/nodes/node-messages.h [changed mode: 0755->0644]
dali/internal/update/nodes/node.cpp
dali/internal/update/nodes/node.h
dali/internal/update/nodes/scene-graph-layer.cpp
dali/internal/update/rendering/scene-graph-renderer.cpp [changed mode: 0755->0644]
dali/internal/update/rendering/scene-graph-renderer.h

old mode 100755 (executable)
new mode 100644 (file)
index b766fda..f3029fa
@@ -62,8 +62,7 @@ void TestApplication::CreateCore()
                                         mDataRetentionPolicy,
                                         Integration::RenderToFrameBuffer::FALSE,
                                         Integration::DepthBufferAvailable::TRUE,
-                                        Integration::StencilBufferAvailable::TRUE,
-                                        Integration::PartialUpdateAvailable::FALSE );
+                                        Integration::StencilBufferAvailable::TRUE );
 
   mCore->ContextCreated();
 
old mode 100755 (executable)
new mode 100644 (file)
index f3633d0..066b37e
@@ -117,15 +117,4 @@ Vector4 TestRenderSurface::GetBackgroundColor()
   return mBackgroundColor;
 }
 
-Rect<int32_t> TestRenderSurface::SetDamagedRect( Rect<int32_t> damagedRectArray )
-{
-  return damagedRectArray;
-}
-
-int32_t TestRenderSurface::GetBufferAge()
-{
-  return 0;
-}
-
-
 } // Namespace dali
old mode 100755 (executable)
new mode 100644 (file)
index 711ca60..be38d00
@@ -137,16 +137,6 @@ public:
    */
   virtual Vector4 GetBackgroundColor();
 
-  /**
-   * @copydoc Dali::Integration::RenderSurface::SetDamagedRect
-   */
-  virtual Rect<int32_t> SetDamagedRect( Rect<int32_t> damagedRectArray );
-
-  /**
-   * @copydoc Dali::Integration::RenderSurface::GetBufferAge
-   */
-  virtual int32_t GetBufferAge();
-
 private:
 
   /**
old mode 100755 (executable)
new mode 100644 (file)
index 2d11f0c..f5fe5d3
@@ -127,13 +127,6 @@ enum Type
    * @note True means that the actor is out of the view frustum.
    */
   CULLED = INHERIT_LAYOUT_DIRECTION + 5,
-
-  /**
-   * @brief Sets the update size hint of the actor.
-   * @details Name "updateSizeHint", type Property::VECTOR2.
-   * @note When this value is set, the update area is determined by this value when a partial update.
-   */
-  UPDATE_SIZE_HINT = INHERIT_LAYOUT_DIRECTION + 6,
 };
 
 } // namespace Property
old mode 100755 (executable)
new mode 100644 (file)
index 92ab037..24299f4
@@ -56,15 +56,6 @@ enum class StencilBufferAvailable
   TRUE
 };
 
-/**
- * @brief Enumerations to specify whether the partial update is available.
- */
-enum class PartialUpdateAvailable
-{
-  FALSE = 0,
-  TRUE
-};
-
 } // namespace Integration
 
 } // namespace Dali
old mode 100755 (executable)
new mode 100644 (file)
index f3bb7ad..1f664e4
@@ -43,8 +43,7 @@ Core* Core::New( RenderController& renderController,
                  ResourcePolicy::DataRetention policy,
                  RenderToFrameBuffer renderToFboEnabled,
                  DepthBufferAvailable depthBufferAvailable,
-                 StencilBufferAvailable stencilBufferAvailable,
-                 PartialUpdateAvailable partialUpdateAvailable )
+                 StencilBufferAvailable stencilBufferAvailable )
 {
   Core* instance = new Core;
   instance->mImpl = new Internal::Core( renderController,
@@ -55,8 +54,7 @@ Core* Core::New( RenderController& renderController,
                                         policy,
                                         renderToFboEnabled,
                                         depthBufferAvailable,
-                                        stencilBufferAvailable,
-                                        partialUpdateAvailable );
+                                        stencilBufferAvailable );
 
   return instance;
 }
old mode 100755 (executable)
new mode 100644 (file)
index 7ae6d62..2e57a76
@@ -232,7 +232,6 @@ public:
    * @param[in] renderToFboEnabled Whether rendering into the Frame Buffer Object is enabled.
    * @param[in] depthBufferAvailable Whether the depth buffer is available
    * @param[in] stencilBufferAvailable Whether the stencil buffer is available
-   * @param[in] partialUpdateAvailble whether the partial update is available
    * @return A newly allocated Core.
    */
   static Core* New( RenderController& renderController,
@@ -243,8 +242,7 @@ public:
                     ResourcePolicy::DataRetention policy,
                     RenderToFrameBuffer renderToFboEnabled,
                     DepthBufferAvailable depthBufferAvailable,
-                    StencilBufferAvailable stencilBufferAvailable,
-                    PartialUpdateAvailable partialUpdateAvailable );
+                    StencilBufferAvailable stencilBufferAvailable );
 
   /**
    * Non-virtual destructor. Core is not intended as a base class.
old mode 100755 (executable)
new mode 100644 (file)
index 6b71036..b0a3b37
@@ -24,7 +24,6 @@
 #include <dali/public-api/object/any.h>
 #include <dali/public-api/common/view-mode.h>
 #include <dali/integration-api/core-enumerations.h>
-#include <vector>
 
 namespace Dali
 {
@@ -190,18 +189,6 @@ public:
    */
   virtual Integration::StencilBufferAvailable GetStencilBufferRequired() = 0;
 
-  /**
-   * @brief Sets currentframe updated/damaged rects
-   * @return
-   */
-  virtual Rect<int32_t> SetDamagedRect( Rect<int32_t> damagedRectArray ) = 0;
-
-  /**
-   * @brief Gets buffer age
-   * @return current buffer age
-   */
-  virtual int32_t GetBufferAge() = 0;
-
 private:
 
   /**
old mode 100755 (executable)
new mode 100644 (file)
index 863c7e5..75e373b
@@ -89,8 +89,7 @@ Core::Core( RenderController& renderController,
             ResourcePolicy::DataRetention dataRetentionPolicy,
             Integration::RenderToFrameBuffer renderToFboEnabled,
             Integration::DepthBufferAvailable depthBufferAvailable,
-            Integration::StencilBufferAvailable stencilBufferAvailable,
-            Integration::PartialUpdateAvailable partialUpdateAvailable )
+            Integration::StencilBufferAvailable stencilBufferAvailable )
 : mRenderController( renderController ),
   mPlatform(platform),
   mProcessingEvent(false),
@@ -110,7 +109,7 @@ Core::Core( RenderController& renderController,
 
   mRenderTaskProcessor = new SceneGraph::RenderTaskProcessor();
 
-  mRenderManager = RenderManager::New( glAbstraction, glSyncAbstraction, glContextHelperAbstraction, depthBufferAvailable, stencilBufferAvailable, partialUpdateAvailable );
+  mRenderManager = RenderManager::New( glAbstraction, glSyncAbstraction, glContextHelperAbstraction, depthBufferAvailable, stencilBufferAvailable );
 
   RenderQueue& renderQueue = mRenderManager->GetRenderQueue();
 
old mode 100755 (executable)
new mode 100644 (file)
index 6e02bb4..b37e454
@@ -88,8 +88,7 @@ public:
         ResourcePolicy::DataRetention dataRetentionPolicy,
         Integration::RenderToFrameBuffer renderToFboEnabled,
         Integration::DepthBufferAvailable depthBufferAvailable,
-        Integration::StencilBufferAvailable stencilBufferAvailable,
-        Integration::PartialUpdateAvailable partialUpdateAvailable );
+        Integration::StencilBufferAvailable stencilBufferAvailable );
 
   /**
    * Destructor
old mode 100755 (executable)
new mode 100644 (file)
index 50c744e..324ff45
@@ -214,7 +214,6 @@ DALI_PROPERTY( "opacity",                   FLOAT,    true,  true,  true,  Dali:
 DALI_PROPERTY( "screenPosition",            VECTOR2,  false, false, false, Dali::DevelActor::Property::SCREEN_POSITION )
 DALI_PROPERTY( "positionUsesAnchorPoint",   BOOLEAN,  true,  false, false, Dali::DevelActor::Property::POSITION_USES_ANCHOR_POINT )
 DALI_PROPERTY( "culled",                    BOOLEAN,  false, false, true, Dali::DevelActor::Property::CULLED )
-DALI_PROPERTY( "updateSizeHint",            VECTOR2,  true, true, true, Dali::DevelActor::Property::UPDATE_SIZE_HINT )
 DALI_PROPERTY_TABLE_END( DEFAULT_ACTOR_PROPERTY_START_INDEX, ActorDefaultProperties )
 
 // Signals
@@ -2719,12 +2718,6 @@ void Actor::SetDefaultProperty( Property::Index index, const Property::Value& pr
       break;
     }
 
-    case Dali::DevelActor::Property::UPDATE_SIZE_HINT:
-    {
-      SetUpdateSizeHint( property.Get< Vector2 >() );
-      break;
-    }
-
     default:
     {
       // this can happen in the case of a non-animatable default property so just do nothing
@@ -3974,12 +3967,6 @@ bool Actor::GetCurrentPropertyValue( Property::Index index, Property::Value& val
       break;
     }
 
-    case Dali::DevelActor::Property::UPDATE_SIZE_HINT:
-    {
-      value = GetUpdateSizeHint();
-      break;
-    }
-
     default:
     {
       // Must be an event-side only property
@@ -4729,19 +4716,6 @@ float Actor::GetMaximumSize( Dimension::Type dimension ) const
   return FLT_MAX;  // Default
 }
 
-void Actor::SetUpdateSizeHint( const Vector2& updateSizeHint )
-{
-  // node is being used in a separate thread; queue a message to set the value & base value
-  SceneGraph::NodeTransformPropertyMessage<Vector3>::Send( GetEventThreadServices(), &GetNode(), &GetNode().mUpdateSizeHint, &SceneGraph::TransformManagerPropertyHandler<Vector3>::Bake, Vector3(updateSizeHint.width, updateSizeHint.height, 0.f ) );
-}
-
-const Vector2 Actor::GetUpdateSizeHint() const
-{
-  // node is being used in a separate thread; copy the value from the previous update
-  Vector3 updateSizeHint = GetNode().GetUpdateSizeHint( GetEventThreadServices().GetEventBufferIndex() );
-  return Vector2( updateSizeHint.width, updateSizeHint.height );
-}
-
 Object* Actor::GetParentObject() const
 {
   return mParent;
index b233dec..9a27d81 100755 (executable)
@@ -1221,18 +1221,6 @@ public:
   float GetMaximumSize( Dimension::Type dimension ) const;
 
   /**
-   * @brief Sets the update size hint of an actor for partial update.
-   * @param [in] updateSizeHint The new updateSizeHint.
-   */
-  void SetUpdateSizeHint( const Vector2& updateSizeHint );
-
-  /**
-   * @brief Return the update size hint of actor
-   * @return Return the update size hint
-   */
-  const Vector2 GetUpdateSizeHint() const;
-
-  /**
    * @copydoc Dali::Actor::AddRenderer()
    */
   uint32_t AddRenderer( Renderer& renderer );
old mode 100755 (executable)
new mode 100644 (file)
index 82f5196..917f76a
@@ -149,10 +149,6 @@ void Scene::Add(Actor& actor)
 void Scene::Remove(Actor& actor)
 {
   mRootLayer->Remove( actor );
-  if( mSurface )
-  {
-    mRenderTaskList->GetTask( 0u )->GetFrameBuffer()->SetPartialUpdateEnabled( false );
-  }
 }
 
 Size Scene::GetSize() const
old mode 100755 (executable)
new mode 100644 (file)
index fe94b5b..33afe35
@@ -134,15 +134,6 @@ void FrameBuffer::MarkSurfaceAsInvalid()
   }
 }
 
-void FrameBuffer::SetPartialUpdateEnabled( bool value )
-{
-  if( mRenderObject->IsSurfaceBacked() )
-  {
-    SetFrameBufferPartialUpdateMessage( mEventThreadServices.GetUpdateManager(), static_cast<Render::SurfaceFrameBuffer*>( mRenderObject ), value );
-  }
-}
-
-
 FrameBuffer::~FrameBuffer()
 {
   if( EventThreadServices::IsCoreRunning() && mRenderObject )
old mode 100755 (executable)
new mode 100644 (file)
index 16c61f5..8484948
@@ -114,12 +114,6 @@ public:
    */
   void MarkSurfaceAsInvalid();
 
-  /**
-   * @brief Sets whether partial update is required for partial update
-   * @param[in] value whether partial update or not
-   */
-  void SetPartialUpdateEnabled( bool value );
-
 private: // implementation
 
   /**
old mode 100755 (executable)
new mode 100644 (file)
index 610496d..a8d2162
@@ -415,8 +415,7 @@ inline void RenderAlgorithms::ProcessRenderList( const RenderList& renderList,
                                                  Integration::DepthBufferAvailable depthBufferAvailable,
                                                  Integration::StencilBufferAvailable stencilBufferAvailable,
                                                  Vector<GLuint>& boundTextures,
-                                                 int orientation,
-                                                 Dali::ClippingBox& scissorBox )
+                                                 int orientation )
 {
   DALI_PRINT_RENDER_LIST( renderList );
 
@@ -475,12 +474,6 @@ inline void RenderAlgorithms::ProcessRenderList( const RenderList& renderList,
     mScissorStack.push_back( layerScissorBox );
     mHasLayerScissor = true;
   }
-  else if ( !scissorBox.IsEmpty() )
-  {
-    context.SetScissorTest( true );
-    context.Scissor( scissorBox.x, scissorBox.y, scissorBox.width, scissorBox.height );
-    mScissorStack.push_back( scissorBox );
-  }
   else
   {
     // We are not performing a layer clip. Add the viewport as the root scissor rectangle.
@@ -529,8 +522,7 @@ void RenderAlgorithms::ProcessRenderInstruction( const RenderInstruction& instru
                                                  Integration::DepthBufferAvailable depthBufferAvailable,
                                                  Integration::StencilBufferAvailable stencilBufferAvailable,
                                                  Vector<GLuint>& boundTextures,
-                                                 int orientation,
-                                                 Dali::ClippingBox& scissorBox )
+                                                 int orientation )
 {
   DALI_PRINT_RENDER_INSTRUCTION( instruction, bufferIndex );
 
@@ -560,8 +552,7 @@ void RenderAlgorithms::ProcessRenderInstruction( const RenderInstruction& instru
                             depthBufferAvailable,
                             stencilBufferAvailable,
                             boundTextures,
-                            orientation,
-                            scissorBox );
+                            orientation );
       }
     }
   }
old mode 100755 (executable)
new mode 100644 (file)
index bb5e066..98c219b
@@ -59,7 +59,6 @@ class RenderAlgorithms
      * @param[in] depthBufferAvailable   Whether the depth buffer is available
      * @param[in] stencilBufferAvailable Whether the stencil buffer is available
      * @param[in] boundTextures          The textures bound for rendering
-     * @param[in] scissorBox             The damaged rect for partial update
      */
     void ProcessRenderInstruction( const SceneGraph::RenderInstruction& instruction,
                                    Context& context,
@@ -67,8 +66,7 @@ class RenderAlgorithms
                                    Integration::DepthBufferAvailable depthBufferAvailable,
                                    Integration::StencilBufferAvailable stencilBufferAvailable,
                                    Vector<GLuint>& boundTextures,
-                                   int orientation,
-                                   Dali::ClippingBox& scissorBox );
+                                   int orientation);
 
   private:
 
@@ -120,7 +118,6 @@ class RenderAlgorithms
      * @param[in] depthBufferAvailable   Whether the depth buffer is available
      * @param[in] stencilBufferAvailable Whether the stencil buffer is available
      * @param[in] boundTextures          The textures bound for rendering
-     * @param[in] scissorBox             The damaged rect for partial update
      */
     inline void ProcessRenderList( const Dali::Internal::SceneGraph::RenderList& renderList,
                                    Context& context,
@@ -130,8 +127,7 @@ class RenderAlgorithms
                                    Integration::DepthBufferAvailable depthBufferAvailable,
                                    Integration::StencilBufferAvailable stencilBufferAvailable,
                                    Vector<GLuint>& boundTextures,
-                                   int orientation,
-                                   Dali::ClippingBox& scissorBox );
+                                   int orientation );
 
     // Prevent copying:
     RenderAlgorithms( RenderAlgorithms& rhs );
old mode 100755 (executable)
new mode 100644 (file)
index e562036..d47f808
@@ -46,13 +46,11 @@ RenderItem::RenderItem()
 : mModelMatrix( false ),
   mModelViewMatrix( false ),
   mSize(),
-  mUpdateSizeHint(),
   mRenderer( NULL ),
   mNode( NULL ),
   mTextureSet( NULL ),
   mDepthIndex( 0 ),
-  mIsOpaque( true ),
-  mPartialUpdateEnabled( false )
+  mIsOpaque( true )
 {
 }
 
@@ -61,22 +59,11 @@ RenderItem::~RenderItem()
 }
 
 
-ClippingBox RenderItem::CalculateViewportSpaceAABB( const int viewportWidth, const int viewportHeight, const bool useUpdateSizeHint ) const
+ClippingBox RenderItem::CalculateViewportSpaceAABB( const int viewportWidth, const int viewportHeight ) const
 {
   // Calculate extent vector of the AABB:
-  float halfActorX;
-  float halfActorY;
-  if( useUpdateSizeHint )
-  {
-    halfActorX = mUpdateSizeHint.x * 0.5f;
-    halfActorY = mUpdateSizeHint.y * 0.5f;
-  }
-  else
-  {
-    halfActorX = mSize.x * 0.5f;
-    halfActorY = mSize.y * 0.5f;
-  }
-
+  const float halfActorX = mSize.x * 0.5f;
+  const float halfActorY = mSize.y * 0.5f;
 
   // To transform the actor bounds to screen-space, We do a fast, 2D version of a matrix multiply optimized for 2D quads.
   // This reduces float multiplications from 64 (16 * 4) to 12 (4 * 3).
old mode 100755 (executable)
new mode 100644 (file)
index 96a6130..7dbd3fb
@@ -65,10 +65,9 @@ struct RenderItem
    *
    * @param[in]    viewportWidth     The width of the viewport to calculate for
    * @param[in]    viewportHeight    The height of the viewport to calculate for
-   * @param[in]    useUpdateSizeHint Set to true if you want to use update size hint instead of item size
    * @return                         The AABB coordinates in viewport-space (x, y, width, height)
    */
-  ClippingBox CalculateViewportSpaceAABB( const int viewportWidth, const int viewportHeight, const bool useUpdateSizeHint = false ) const;
+  ClippingBox CalculateViewportSpaceAABB( const int viewportWidth, const int viewportHeight ) const;
 
   /**
    * Overriden delete operator.
@@ -80,13 +79,11 @@ struct RenderItem
   Matrix            mModelMatrix;
   Matrix            mModelViewMatrix;
   Vector3           mSize;
-  Vector3           mUpdateSizeHint;
   Render::Renderer* mRenderer;
   Node*             mNode;
   const void*       mTextureSet;        //< Used for sorting only
   int               mDepthIndex;
   bool              mIsOpaque:1;
-  bool              mPartialUpdateEnabled:1;
 
 private:
 
old mode 100755 (executable)
new mode 100644 (file)
index 90925eb..41af19f
@@ -63,8 +63,7 @@ public:
   : mNextFree( 0 ),
     mClippingBox( NULL ),
     mSourceLayer( NULL ),
-    mHasColorRenderItems( false ),
-    mPartialUpdateEnabled( false )
+    mHasColorRenderItems( false )
   {
   }
 
@@ -259,24 +258,6 @@ public:
     return mHasColorRenderItems;
   }
 
-  /**
-   * Enable/Disable Partial update dirty flag
-   * @param[in] true to mark dirty else false
-   */
-  void SetPartialUpdateEnabled( bool value )
-  {
-    mPartialUpdateEnabled = value;
-  }
-
-  /**
-   * Get Partial update dirty flag
-   * @return true if dirty else false
-   */
-  bool IsPartialUpdateEnabled() const
-  {
-    return mPartialUpdateEnabled;
-  }
-
 private:
 
   /*
@@ -291,7 +272,6 @@ private:
   ClippingBox* mClippingBox;               ///< The clipping box, in window coordinates, when clipping is enabled
   Layer*       mSourceLayer;              ///< The originating layer where the renderers are from
   bool         mHasColorRenderItems : 1;  ///< True if list contains color render items
-  bool         mPartialUpdateEnabled : 1; //< True if partial update is needed.
 
 };
 
old mode 100755 (executable)
new mode 100644 (file)
index 630f870..d9c2ea0
@@ -62,9 +62,6 @@ Debug::Filter* gLogFilter = Debug::Filter::New(Debug::NoLogging, false, "LOG_REN
 } // unnamed namespace
 #endif
 
-const int partialUpdateMargin = 4u;
-const float partialUpdateRatio = 0.8f; // If the partial update area exceeds 80%, change to full update.
-
 /**
  * Structure to contain internal data
  */
@@ -74,8 +71,7 @@ struct RenderManager::Impl
         Integration::GlSyncAbstraction& glSyncAbstraction,
         Integration::GlContextHelperAbstraction& glContextHelperAbstraction,
         Integration::DepthBufferAvailable depthBufferAvailableParam,
-        Integration::StencilBufferAvailable stencilBufferAvailableParam,
-        Integration::PartialUpdateAvailable partialUpdateAvailableParam )
+        Integration::StencilBufferAvailable stencilBufferAvailableParam )
   : context( glAbstraction, &surfaceContextContainer ),
     currentContext( &context ),
     glAbstraction( glAbstraction ),
@@ -96,7 +92,6 @@ struct RenderManager::Impl
     programController( glAbstraction ),
     depthBufferAvailable( depthBufferAvailableParam ),
     stencilBufferAvailable( stencilBufferAvailableParam ),
-    partialUpdateAvailable( partialUpdateAvailableParam ),
     defaultSurfaceOrientation( 0 )
   {
      // Create thread pool with just one thread ( there may be a need to create more threads in the future ).
@@ -176,7 +171,6 @@ struct RenderManager::Impl
 
   Integration::DepthBufferAvailable         depthBufferAvailable;     ///< Whether the depth buffer is available
   Integration::StencilBufferAvailable       stencilBufferAvailable;   ///< Whether the stencil buffer is available
-  Integration::PartialUpdateAvailable       partialUpdateAvailable;   ///< Whether the partial update is available
 
   std::unique_ptr<Dali::ThreadPool>         threadPool;               ///< The thread pool
   Vector<GLuint>                            boundTextures;            ///< The textures bound for rendering
@@ -189,16 +183,14 @@ RenderManager* RenderManager::New( Integration::GlAbstraction& glAbstraction,
                                    Integration::GlSyncAbstraction& glSyncAbstraction,
                                    Integration::GlContextHelperAbstraction& glContextHelperAbstraction,
                                    Integration::DepthBufferAvailable depthBufferAvailable,
-                                   Integration::StencilBufferAvailable stencilBufferAvailable,
-                                   Integration::PartialUpdateAvailable partialUpdateAvailable )
+                                   Integration::StencilBufferAvailable stencilBufferAvailable )
 {
   RenderManager* manager = new RenderManager;
   manager->mImpl = new Impl( glAbstraction,
                              glSyncAbstraction,
                              glContextHelperAbstraction,
                              depthBufferAvailable,
-                             stencilBufferAvailable,
-                             partialUpdateAvailable );
+                             stencilBufferAvailable );
   return manager;
 }
 
@@ -600,69 +592,10 @@ void RenderManager::Render( Integration::RenderStatus& status, bool forceClear )
   DALI_PRINT_RENDER_END();
 }
 
-bool GetDamagedRect( Rect<int32_t> &viewportRect, RenderInstruction& instruction, Rect<int32_t> &damagedRect )
-{
-  // merge bounding
-  int dx1 = viewportRect.width, dx2 = 0, dy1 = viewportRect.height, dy2 = 0;
-  int checkWidth = static_cast<int>( static_cast<float>( viewportRect.width ) * partialUpdateRatio );
-  int checkHeight = static_cast<int>( static_cast<float>( viewportRect.height ) * partialUpdateRatio );
-  Rect<int32_t> screenRect;
-
-  bool isPartialUpdate = false;
-
-  const RenderListContainer::SizeType renderListCount = instruction.RenderListCount();
-  // Iterate through each render list.
-
-  for( RenderListContainer::SizeType index = 0; index < renderListCount; ++index )
-  {
-    const RenderList* renderList = instruction.GetRenderList( index );
-
-    if( renderList && !renderList->IsEmpty() && renderList->IsPartialUpdateEnabled() )
-    {
-      const std::size_t itemCount = renderList->Count();
-      for( uint32_t itemIndex = 0u; itemIndex < itemCount; ++itemIndex )
-      {
-        const RenderItem& item = renderList->GetItem( itemIndex );
-
-        if( item.mPartialUpdateEnabled )
-        {
-          isPartialUpdate = true;
-
-          screenRect = item.CalculateViewportSpaceAABB( viewportRect.width, viewportRect.height, true );
-
-          dx1 = std::min( screenRect.x, dx1 );
-          dx2 = std::max( screenRect.x + screenRect.width, dx2);
-          dy1 = std::min( screenRect.y, dy1 );
-          dy2 = std::max( screenRect.y + screenRect.height, dy2 );
-
-          if( ( dx2 - dx1 )  > checkWidth && ( dy2 - dy1 ) > checkHeight )
-          {
-            return false;
-          }
-        }
-      }
-    }
-  }
-
-  if( isPartialUpdate )
-  {
-    damagedRect.x = dx1 - partialUpdateMargin;
-    damagedRect.y = dy1 - partialUpdateMargin;
-    damagedRect.width = dx2 - dx1 + ( 2 * partialUpdateMargin );
-    damagedRect.height = dy2 - dy1 + ( 2 * partialUpdateMargin );
-  }
-
-  return isPartialUpdate;
-}
-
 void RenderManager::DoRender( RenderInstruction& instruction )
 {
   Rect<int32_t> viewportRect;
   Vector4   clearColor;
-  bool isPartialUpdate = false;
-  Rect<int32_t> damagedRect;
-  Rect<int32_t> mergedRect;
-  Dali::ClippingBox scissorBox;
 
   if ( instruction.mIsClearColorSet )
   {
@@ -678,7 +611,6 @@ void RenderManager::DoRender( RenderInstruction& instruction )
   Vector4 backgroundColor = mImpl->backgroundColor;
   Integration::DepthBufferAvailable depthBufferAvailable = mImpl->depthBufferAvailable;
   Integration::StencilBufferAvailable stencilBufferAvailable = mImpl->stencilBufferAvailable;
-  Integration::PartialUpdateAvailable partialUpdateAvailable = mImpl->partialUpdateAvailable;
 
   Render::SurfaceFrameBuffer* surfaceFrameBuffer = nullptr;
   if ( instruction.mFrameBuffer != 0 )
@@ -744,62 +676,25 @@ void RenderManager::DoRender( RenderInstruction& instruction )
     mImpl->currentContext->BindFramebuffer( GL_FRAMEBUFFER, 0u );
   }
 
-
-  if( surfaceFrameBuffer &&
-      partialUpdateAvailable == Integration::PartialUpdateAvailable::TRUE )
-  {
-    const RenderListContainer::SizeType renderListCount = instruction.RenderListCount();
-    // Iterate through each render list.
-    if( surfaceFrameBuffer->IsPartialUpdateEnabled() )
-    {
-      isPartialUpdate = GetDamagedRect( surfaceRect, instruction, damagedRect ) ;
-    }
-
-    if( !isPartialUpdate )
-    {
-      damagedRect = surfaceRect;
-    }
-
-    mergedRect = surfaceFrameBuffer->SetDamagedRect( damagedRect );
-
-    if( mergedRect.IsEmpty() )
-    {
-      isPartialUpdate = false;
-    }
-    else
-    {
-      scissorBox.x = mergedRect.x;
-      scissorBox.y = mergedRect.y;
-      scissorBox.width = mergedRect.width;
-      scissorBox.height = mergedRect.height;
-    }
-  }
-
   if ( surfaceFrameBuffer )
   {
-      mImpl->currentContext->Viewport( surfaceRect.x,
-                                surfaceRect.y,
-                                surfaceRect.width,
-                                surfaceRect.height );
-
+    mImpl->currentContext->Viewport( surfaceRect.x,
+                              surfaceRect.y,
+                              surfaceRect.width,
+                              surfaceRect.height );
 
-      mImpl->currentContext->ClearColor( backgroundColor.r,
-                                  backgroundColor.g,
-                                  backgroundColor.b,
-                                  backgroundColor.a );
+    mImpl->currentContext->ClearColor( backgroundColor.r,
+                                backgroundColor.g,
+                                backgroundColor.b,
+                                backgroundColor.a );
   }
 
   // Clear the entire color, depth and stencil buffers for the default framebuffer, if required.
   // It is important to clear all 3 buffers when they are being used, for performance on deferred renderers
   // e.g. previously when the depth & stencil buffers were NOT cleared, it caused the DDK to exceed a "vertex count limit",
   // and then stall. That problem is only noticeable when rendering a large number of vertices per frame.
-  mImpl->currentContext->SetScissorTest( false );
 
-  if( isPartialUpdate )
-  {
-    mImpl->currentContext->SetScissorTest( true );
-    mImpl->currentContext->Scissor( scissorBox.x, scissorBox.y, scissorBox.width, scissorBox.height );
-  }
+  mImpl->currentContext->SetScissorTest( false );
 
   GLbitfield clearMask = GL_COLOR_BUFFER_BIT;
 
@@ -820,12 +715,6 @@ void RenderManager::DoRender( RenderInstruction& instruction )
 
   mImpl->currentContext->Clear( clearMask, Context::FORCE_CLEAR );
 
-  if( isPartialUpdate )
-  {
-    mImpl->currentContext->SetScissorTest( false );
-  }
-
-
   if( !instruction.mIgnoreRenderToFbo && ( instruction.mFrameBuffer != 0 ) )
   {
     if ( instruction.mFrameBuffer->IsSurfaceBacked() ) // Surface rendering
@@ -897,14 +786,7 @@ void RenderManager::DoRender( RenderInstruction& instruction )
 
     // Clear the viewport area only
     mImpl->currentContext->SetScissorTest( true );
-    if( isPartialUpdate )
-    {
-      mImpl->currentContext->Scissor( scissorBox.x, scissorBox.y, scissorBox.width, scissorBox.height );
-    }
-    else
-    {
-      mImpl->currentContext->Scissor( viewportRect.x, viewportRect.y, viewportRect.width, viewportRect.height );
-    }
+    mImpl->currentContext->Scissor( viewportRect.x, viewportRect.y, viewportRect.width, viewportRect.height );
     mImpl->currentContext->ColorMask( true );
     mImpl->currentContext->Clear( GL_COLOR_BUFFER_BIT , Context::CHECK_CACHED_VALUES );
     mImpl->currentContext->SetScissorTest( false );
@@ -920,8 +802,7 @@ void RenderManager::DoRender( RenderInstruction& instruction )
       depthBufferAvailable,
       stencilBufferAvailable,
       mImpl->boundTextures,
-      surfaceOrientation,
-      scissorBox );
+      surfaceOrientation );
 
   // Synchronise the FBO/Texture access when there are multiple contexts
   if ( mImpl->currentContext->IsSurfacelessContextSupported() )
old mode 100755 (executable)
new mode 100644 (file)
index 3d064b2..248c9fd
@@ -83,8 +83,7 @@ public:
                              Integration::GlSyncAbstraction& glSyncAbstraction,
                              Integration::GlContextHelperAbstraction& glContextHelperAbstraction,
                              Integration::DepthBufferAvailable depthBufferAvailable,
-                             Integration::StencilBufferAvailable stencilBufferAvailable,
-                             Integration::PartialUpdateAvailable partialUpdateAvailable );
+                             Integration::StencilBufferAvailable stencilBufferAvailable );
 
   /**
    * Non-virtual destructor; not intended as a base class
old mode 100755 (executable)
new mode 100644 (file)
index c62251e..7154ff6
@@ -35,9 +35,7 @@ SurfaceFrameBuffer::SurfaceFrameBuffer( Integration::RenderSurface* surface )
   mHeight( mSurface->GetPositionSize().height ),
   mBackgroundColor( 0.f, 0.f, 0.f, 1.f ),
   mSizeChanged( false ),
-  mBackgroundColorChanged( false ),
-  mIsSurfaceInvalid( false ),
-  mPartialUpdateEnabled( true )
+  mIsSurfaceInvalid( false )
 {
 }
 
@@ -106,18 +104,6 @@ void SurfaceFrameBuffer::PostRender()
   }
 
   mSizeChanged = false;
-  mBackgroundColorChanged = false;
-  mPartialUpdateEnabled = true;
-}
-
-Rect<int32_t> SurfaceFrameBuffer::SetDamagedRect( Rect<int32_t> damagedRect )
-{
-  Rect<int32_t> ret;
-  if ( IsSurfaceValid() )
-  {
-    ret = mSurface->SetDamagedRect( damagedRect );
-  }
-  return ret;
 }
 
 Context* SurfaceFrameBuffer::GetContext()
@@ -148,7 +134,6 @@ void SurfaceFrameBuffer::SetSize( uint32_t width, uint32_t height )
 void SurfaceFrameBuffer::SetBackgroundColor( const Vector4& color )
 {
   mBackgroundColor = color;
-  mBackgroundColorChanged = true;
 }
 
 bool SurfaceFrameBuffer::IsSurfaceValid() const
@@ -156,21 +141,6 @@ bool SurfaceFrameBuffer::IsSurfaceValid() const
   return mSurface && !mIsSurfaceInvalid;
 }
 
-bool SurfaceFrameBuffer::IsPartialUpdateEnabled() const
-{
-  bool ret = false;
-  if ( IsSurfaceValid() )
-  {
-    ret = mSurface->GetBufferAge() && ( mPartialUpdateEnabled && !( mSizeChanged || mBackgroundColorChanged ) );
-  }
-  return ret;
-}
-
-void SurfaceFrameBuffer::SetPartialUpdateEnabled( bool value )
-{
-  mPartialUpdateEnabled = value;
-}
-
 } //Render
 
 } //Internal
old mode 100755 (executable)
new mode 100644 (file)
index 0ca0bcd..edd667d
@@ -135,24 +135,6 @@ public:
    */
   Vector4 GetBackgroundColor();
 
-  /**
-   * @brief Sets currentframe updated/damaged rects
-   * @return merged update rects
-   */
-  Rect<int32_t> SetDamagedRect( Rect<int32_t> damagedRect );
-
-  /**
-   * @brief Gets whether partial update is required for partial update
-   * @return whether partial update or not
-   */
-  bool IsPartialUpdateEnabled() const;
-
-  /**
-   * @brief Sets whether partial update is required for partial update
-   * @param[in] value whether partial update or not
-   */
-  void SetPartialUpdateEnabled( bool value );
-
 private:
 
   Integration::RenderSurface* mSurface;   ///< The render surface
@@ -162,9 +144,7 @@ private:
   uint32_t                    mHeight;
   Vector4                     mBackgroundColor;
   bool                        mSizeChanged;
-  bool                        mBackgroundColorChanged;
   std::atomic<bool>           mIsSurfaceInvalid; ///< This is set only from the event thread and read only from the render thread
-  bool                        mPartialUpdateEnabled; ///< This value is whether partial update is required
 };
 
 // Messages for FrameBuffer
@@ -190,17 +170,6 @@ inline void SetFrameBufferBackgroundColorMessage( SceneGraph::UpdateManager& upd
   new (slot) LocalType( surfaceFrameBuffer, &SurfaceFrameBuffer::SetBackgroundColor, color );
 }
 
-inline void SetFrameBufferPartialUpdateMessage( SceneGraph::UpdateManager& updateManager, SurfaceFrameBuffer* surfaceFrameBuffer, bool value )
-{
-  typedef MessageValue1< SurfaceFrameBuffer, bool > LocalType;
-
-  // Reserve some memory inside the message queue
-  uint32_t* slot = updateManager.ReserveMessageSlot( sizeof( LocalType ) );
-
-  // Construct message in the message queue memory; note that delete should not be called on the return value
-  new (slot) LocalType( surfaceFrameBuffer, &SurfaceFrameBuffer::SetPartialUpdateEnabled, value );
-}
-
 } // namespace Render
 
 } // namespace Internal
old mode 100755 (executable)
new mode 100644 (file)
index cbf0842..0b3ff50
@@ -519,11 +519,6 @@ public:
       progress = SetProgress( progress );
     }
 
-    if( mPropertyOwner )
-    {
-      mPropertyOwner->SetPropertyDirty( true );
-    }
-
     float alpha = ApplyAlphaFunction( progress );
 
     // PropertyType specific part
old mode 100755 (executable)
new mode 100644 (file)
index 8668e4e..1e31299
@@ -108,7 +108,6 @@ public:
    */
   virtual void Process( BufferIndex updateBufferIndex )
   {
-    mSceneObject->SetPropertyDirty( true );
     (mProperty->*mMemberFunction)( updateBufferIndex, mParam );
   }
 
@@ -188,7 +187,6 @@ public:
    */
   virtual void Process( BufferIndex updateBufferIndex )
   {
-    mSceneObject->SetPropertyDirty( true );
     (mProperty->*mMemberFunction)( updateBufferIndex, mParam );
   }
 
old mode 100755 (executable)
new mode 100644 (file)
index 81ca85c..fb655e3
@@ -171,15 +171,7 @@ void PropertyOwner::RemoveUniformMapObserver( UniformMap::Observer& observer )
   mUniformMaps.RemoveObserver( observer );
 }
 
-void PropertyOwner::SetPropertyDirty( bool value )
-{
-  mPropertyDirty = value;
-}
 
-bool PropertyOwner::IsPropertyDirty() const
-{
-  return mPropertyDirty;
-}
 
 } // namespace SceneGraph
 
old mode 100755 (executable)
new mode 100644 (file)
index 637d82b..843a19b
@@ -206,18 +206,6 @@ public:
    */
   void RemoveUniformMapObserver( UniformMap::Observer& observer );
 
-  /**
-   * Set whether property has changed to run following a render.
-   * @param[in] value Set to true if the property has changed
-   */
-  virtual void SetPropertyDirty( bool value );
-
-  /**
-   * Query the property status following rendering of a frame.
-   * @return True if the property has changed
-   */
-  virtual bool IsPropertyDirty() const;
-
 
 protected:
 
@@ -238,7 +226,6 @@ protected:
 
   OwnedPropertyContainer mCustomProperties; ///< Properties provided with InstallCustomProperty()
   UniformMap mUniformMaps; ///< Container of owned uniform maps
-  bool mPropertyDirty:1; ///< Required for marking it dirty in case of partial update.
 
 private:
 
old mode 100755 (executable)
new mode 100644 (file)
index a76632e..204a472
@@ -33,7 +33,6 @@
 #include <dali/internal/render/renderers/render-renderer.h>
 #include <dali/internal/render/renderers/render-property-buffer.h>
 #include <dali/internal/update/nodes/scene-graph-layer.h>
-#include <dali/internal/common/math.h>
 
 namespace
 {
@@ -162,8 +161,8 @@ inline void AddRendererToRenderList( BufferIndex updateBufferIndex,
 {
   bool inside( true );
   Node* node = renderable.mNode;
-  bool isModifiesGeometryHint = false;
-  if( cull && renderable.mRenderer && !( isModifiesGeometryHint = renderable.mRenderer->GetShader().HintEnabled( Dali::Shader::Hint::MODIFIES_GEOMETRY ) ) )
+
+  if( cull && renderable.mRenderer && !renderable.mRenderer->GetShader().HintEnabled( Dali::Shader::Hint::MODIFIES_GEOMETRY ) )
   {
     const Vector4& boundingSphere = node->GetBoundingSphere();
     inside = ( boundingSphere.w > Math::MACHINE_EPSILON_1000 ) &&
@@ -181,27 +180,17 @@ inline void AddRendererToRenderList( BufferIndex updateBufferIndex,
       item.mNode = renderable.mNode;
       item.mIsOpaque = ( opacityType == Renderer::OPAQUE );
       item.mDepthIndex = 0;
-      item.mPartialUpdateEnabled = false;
 
-      if( !isLayer3d )
+      if(!isLayer3d)
       {
         item.mDepthIndex = renderable.mNode->GetDepthIndex();
       }
-      if( isLayer3d || isModifiesGeometryHint )
-      {
-        renderList.SetPartialUpdateEnabled( false );
-      }
 
       if( DALI_LIKELY( renderable.mRenderer ) )
       {
         item.mRenderer =   &renderable.mRenderer->GetRenderer();
         item.mTextureSet =  renderable.mRenderer->GetTextures();
         item.mDepthIndex += renderable.mRenderer->GetDepthIndex();
-
-        if( FaceCullingMode::NONE != renderable.mRenderer->GetFaceCullingMode() )
-        {
-          renderList.SetPartialUpdateEnabled( false );
-        }
       }
       else
       {
@@ -212,27 +201,13 @@ inline void AddRendererToRenderList( BufferIndex updateBufferIndex,
       node->GetWorldMatrixAndSize( item.mModelMatrix, item.mSize );
 
       Matrix::Multiply( item.mModelViewMatrix, item.mModelMatrix, viewMatrix );
-
-      if( DALI_LIKELY( item.mRenderer ) && renderList.IsPartialUpdateEnabled() )
-      {
-        if( node->IsPropertyDirty() || node->IsComponentChanged() )
-        {
-          item.mPartialUpdateEnabled = true;
-
-          item.mUpdateSizeHint = item.mSize;
-          Vector3 updateSizeHint = node->GetUpdateSizeHint( updateBufferIndex );
-          if( updateSizeHint != Vector3::ZERO )
-          {
-            item.mUpdateSizeHint = updateSizeHint;
-          }
-        }
-      }
     }
-    node->SetCulled( updateBufferIndex, false );
+
+     node->SetCulled( updateBufferIndex, false );
   }
   else
   {
-    node->SetCulled( updateBufferIndex, true );
+     node->SetCulled( updateBufferIndex, true );
   }
 }
 
@@ -459,10 +434,6 @@ void RenderInstructionProcessor::Prepare( BufferIndex updateBufferIndex,
       if( !SetupRenderList( renderables, layer, instruction, tryReuseRenderList, &renderList ) )
       {
         renderList->SetHasColorRenderItems( true );
-        if( !isLayer3D )
-        {
-          renderList->SetPartialUpdateEnabled( true );
-        }
         AddRenderersToRenderList( updateBufferIndex,
                                   *renderList,
                                   renderables,
@@ -485,10 +456,6 @@ void RenderInstructionProcessor::Prepare( BufferIndex updateBufferIndex,
       if( !SetupRenderList( renderables, layer, instruction, tryReuseRenderList, &renderList ) )
       {
         renderList->SetHasColorRenderItems( false );
-        if( !isLayer3D )
-        {
-          renderList->SetPartialUpdateEnabled( true );
-        }
         AddRenderersToRenderList( updateBufferIndex,
                                   *renderList,
                                   renderables,
old mode 100755 (executable)
new mode 100644 (file)
index 651d230..c2cc4bb
@@ -106,10 +106,6 @@ TransformId TransformManager::CreateTransform()
     mSizeBase.PushBack(Vector3(0.0f,0.0f,0.0f));
     mComponentDirty.PushBack(false);
     mLocalMatrixDirty.PushBack(false);
-    mComponentChanged.PushBack(false);
-    mPrevWorld.PushBack(Matrix::IDENTITY);
-    mUpdateSizeHint.PushBack(Vector3(0.0f,0.0f,0.0f));
-    mUpdateSizeHintBase.PushBack(Vector3(0.0f,0.0f,0.0f));
   }
   else
   {
@@ -127,10 +123,6 @@ TransformId TransformManager::CreateTransform()
     mSizeBase[mComponentCount] = Vector3(0.0f,0.0f,0.0f);
     mComponentDirty[mComponentCount] = false;
     mLocalMatrixDirty[mComponentCount] = false;
-    mComponentChanged[mComponentCount] = false;
-    mPrevWorld[mComponentCount].SetIdentity();
-    mUpdateSizeHint[mComponentCount] = Vector3(0.0f,0.0f,0.0f);
-    mUpdateSizeHintBase[mComponentCount] = Vector3(0.0f,0.0f,0.0f);
   }
 
   mComponentCount++;
@@ -154,10 +146,6 @@ void TransformManager::RemoveTransform(TransformId id)
   mComponentDirty[index] = mComponentDirty[mComponentCount];
   mLocalMatrixDirty[index] = mLocalMatrixDirty[mComponentCount];
   mBoundingSpheres[index] = mBoundingSpheres[mComponentCount];
-  mComponentChanged[index] = mComponentChanged[mComponentCount];
-  mPrevWorld[index] = mPrevWorld[mComponentCount];
-  mUpdateSizeHint[index] = mUpdateSizeHint[mComponentCount];
-  mUpdateSizeHintBase[index] = mUpdateSizeHintBase[mComponentCount];
 
   TransformId lastItemId = mComponentId[mComponentCount];
   mIds[ lastItemId ] = index;
@@ -227,6 +215,7 @@ void TransformManager::SetInheritOrientation( TransformId id, bool inherit )
   {
     mInheritanceMode[ index ] &= ~INHERIT_ORIENTATION;
   }
+
   mComponentDirty[index] = true;
 }
 
@@ -237,7 +226,6 @@ void TransformManager::ResetToBaseValue()
     memcpy( &mTxComponentAnimatable[0], &mTxComponentAnimatableBaseValue[0], sizeof(TransformComponentAnimatable)*mComponentCount );
     memcpy( &mSize[0], &mSizeBase[0], sizeof(Vector3)*mComponentCount );
     memset( &mLocalMatrixDirty[0], false, sizeof(bool)*mComponentCount );
-    memcpy( &mUpdateSizeHint[0], &mUpdateSizeHintBase[0], sizeof(Vector3)*mComponentCount );
   }
 }
 
@@ -258,8 +246,6 @@ void TransformManager::Update()
   const Vector3 topLeft( 0.0f, 0.0f, 0.5f );
   for( unsigned int i(0); i<mComponentCount; ++i )
   {
-    mPrevWorld[i] = mWorld[i];
-
     if( DALI_LIKELY( mInheritanceMode[i] != DONT_INHERIT_TRANSFORM && mParent[i] != INVALID_TRANSFORM_ID ) )
     {
       const TransformId& parentIndex = mIds[mParent[i] ];
@@ -336,17 +322,7 @@ void TransformManager::Update()
     mBoundingSpheres[i] = mWorld[i].GetTranslation();
     mBoundingSpheres[i].w = Length( centerToEdgeWorldSpace );
 
-    mComponentChanged[i] = false;
-
-    // Due to parent transformation child transformation could be changed
-    if( mComponentDirty[i] ||
-        mPrevWorld[i] != mWorld[i] )
-    {
-      mComponentChanged[i] = true;
-    }
-
     mComponentDirty[i] = false;
-
   }
 }
 
@@ -364,10 +340,6 @@ void TransformManager::SwapComponents( unsigned int i, unsigned int j )
   std::swap( mComponentDirty[i], mComponentDirty[j] );
   std::swap( mBoundingSpheres[i], mBoundingSpheres[j] );
   std::swap( mWorld[i], mWorld[j] );
-  std::swap( mComponentChanged[i], mComponentChanged[j] );
-  std::swap( mPrevWorld[i], mPrevWorld[j] );
-  std::swap( mUpdateSizeHint[i], mUpdateSizeHint[j] );
-  std::swap( mUpdateSizeHintBase[i], mUpdateSizeHintBase[j] );
 
   mIds[ mComponentId[i] ] = i;
   mIds[ mComponentId[j] ] = j;
@@ -437,12 +409,6 @@ Vector3& TransformManager::GetVector3PropertyValue( TransformId id, TransformMan
       mComponentDirty[ index ] = true;
       return mSize[ index ];
     }
-    case TRANSFORM_PROPERTY_UPDATE_SIZE_HINT:
-    {
-      TransformId index( mIds[id] );
-      mComponentDirty[ index ] = true;
-      return mUpdateSizeHint[ index ];
-    }
     default:
     {
       DALI_ASSERT_ALWAYS(false);
@@ -475,10 +441,6 @@ const Vector3& TransformManager::GetVector3PropertyValue( TransformId id, Transf
     {
       return mSize[ mIds[id] ];
     }
-    case TRANSFORM_PROPERTY_UPDATE_SIZE_HINT:
-    {
-      return mUpdateSizeHint[ mIds[id] ];
-    }
     default:
     {
       DALI_ASSERT_ALWAYS(false);
@@ -511,10 +473,6 @@ const float& TransformManager::GetVector3PropertyComponentValue(TransformId id,
     {
       return mSize[ mIds[id] ][component];
     }
-    case TRANSFORM_PROPERTY_UPDATE_SIZE_HINT:
-    {
-      return mUpdateSizeHint[ mIds[id] ][component];
-    }
     default:
     {
       DALI_ASSERT_ALWAYS(false);
@@ -555,11 +513,6 @@ void TransformManager::SetVector3PropertyValue( TransformId id, TransformManager
       mSize[ index ] = value;
       break;
     }
-    case TRANSFORM_PROPERTY_UPDATE_SIZE_HINT:
-    {
-      mUpdateSizeHint[ index ] = value;
-      break;
-    }
     default:
     {
       DALI_ASSERT_ALWAYS(false);
@@ -599,11 +552,6 @@ void TransformManager::SetVector3PropertyComponentValue( TransformId id, Transfo
       mSize[ index ][component] = value;
       break;
     }
-    case TRANSFORM_PROPERTY_UPDATE_SIZE_HINT:
-    {
-      mUpdateSizeHint[ index ][component] = value;
-      break;
-    }
     default:
     {
       DALI_ASSERT_ALWAYS(false);
@@ -643,11 +591,6 @@ void TransformManager::BakeVector3PropertyValue( TransformId id, TransformManage
       mSize[ index ] = mSizeBase[index] = value;
       break;
     }
-    case TRANSFORM_PROPERTY_UPDATE_SIZE_HINT:
-    {
-      mUpdateSizeHint[ index ] = mUpdateSizeHintBase[index] = value;
-      break;
-    }
     default:
     {
       DALI_ASSERT_ALWAYS(false);
@@ -687,11 +630,6 @@ void TransformManager::BakeRelativeVector3PropertyValue( TransformId id, Transfo
       mSize[ index ] = mSizeBase[index] = mSize[ index ] + value;
       break;
     }
-    case TRANSFORM_PROPERTY_UPDATE_SIZE_HINT:
-    {
-      mUpdateSizeHint[ index ] = mUpdateSizeHintBase[index] = mUpdateSizeHint[ index ] + value;
-      break;
-    }
     default:
     {
       DALI_ASSERT_ALWAYS(false);
@@ -731,11 +669,6 @@ void TransformManager::BakeMultiplyVector3PropertyValue( TransformId id, Transfo
       mSize[ index ] = mSizeBase[index] = mSize[ index ] * value;
       break;
     }
-    case TRANSFORM_PROPERTY_UPDATE_SIZE_HINT:
-    {
-      mUpdateSizeHint[ index ] = mUpdateSizeHintBase[index] = mUpdateSizeHint[ index ] * value;
-      break;
-    }
     default:
     {
       DALI_ASSERT_ALWAYS(false);
@@ -775,11 +708,6 @@ void TransformManager::BakeVector3PropertyComponentValue( TransformId id, Transf
       mSize[ index ][component] = mSizeBase[index][component] = value;
       break;
     }
-    case TRANSFORM_PROPERTY_UPDATE_SIZE_HINT:
-    {
-      mUpdateSizeHint[ index ][component] = mUpdateSizeHintBase[index][component] = value;
-      break;
-    }
     default:
     {
       DALI_ASSERT_ALWAYS(false);
@@ -819,11 +747,6 @@ void TransformManager::BakeXVector3PropertyValue( TransformId id, TransformManag
       mSize[ index ].x = mSizeBase[index].x = value;
       break;
     }
-    case TRANSFORM_PROPERTY_UPDATE_SIZE_HINT:
-    {
-      mUpdateSizeHint[ index ].x = mUpdateSizeHintBase[index].x = value;
-      break;
-    }
     default:
     {
       DALI_ASSERT_ALWAYS(false);
@@ -863,11 +786,6 @@ void TransformManager::BakeYVector3PropertyValue( TransformId id, TransformManag
       mSize[ index ].y = mSizeBase[index].y = value;
       break;
     }
-    case TRANSFORM_PROPERTY_UPDATE_SIZE_HINT:
-    {
-      mUpdateSizeHint[ index ].y = mUpdateSizeHintBase[index].y = value;
-      break;
-    }
     default:
     {
       DALI_ASSERT_ALWAYS(false);
@@ -907,11 +825,6 @@ void TransformManager::BakeZVector3PropertyValue( TransformId id, TransformManag
       mSize[ index ].z = mSizeBase[index].z = value;
       break;
     }
-    case TRANSFORM_PROPERTY_UPDATE_SIZE_HINT:
-    {
-      mUpdateSizeHint[ index ].z = mUpdateSizeHintBase[index].z = value;
-      break;
-    }
     default:
     {
       DALI_ASSERT_ALWAYS(false);
@@ -957,11 +870,6 @@ const Vector4& TransformManager::GetBoundingSphere( TransformId id ) const
   return mBoundingSpheres[ mIds[id] ];
 }
 
-bool TransformManager::IsComponentChanged( TransformId id )
-{
-  return mComponentChanged[ mIds[id]];
-}
-
 void TransformManager::GetWorldMatrixAndSize( TransformId id, Matrix& worldMatrix, Vector3& size ) const
 {
   TransformId index = mIds[id];
@@ -969,11 +877,6 @@ void TransformManager::GetWorldMatrixAndSize( TransformId id, Matrix& worldMatri
   size = mSize[index];
 }
 
-const Vector3& TransformManager::GetUpdateSizeHint( TransformId id ) const
-{
-  return mUpdateSizeHint[ mIds[id] ];
-}
-
 void TransformManager::SetPositionUsesAnchorPoint( TransformId id, bool value )
 {
   TransformId index( mIds[ id ] );
old mode 100755 (executable)
new mode 100644 (file)
index 30b253b..6bf9bda
@@ -89,7 +89,6 @@ enum TransformManagerProperty
   TRANSFORM_PROPERTY_WORLD_SCALE,
   TRANSFORM_PROPERTY_WORLD_ORIENTATION,
   TRANSFORM_PROPERTY_WORLD_MATRIX,
-  TRANSFORM_PROPERTY_UPDATE_SIZE_HINT,
   TRANSFORM_PROPERTY_COUNT,
 };
 
@@ -337,13 +336,6 @@ public:
   const Vector4& GetBoundingSphere( TransformId id ) const;
 
   /**
-   * Component of node is changed or not
-   * @param[in] id Id of the transform component
-   * @return true if Component box is changed else false.
-   */
-  bool IsComponentChanged( TransformId id );
-
-  /**
    * Get the world matrix and size of a given component
    * @param[in] id Id of the transform component
    * @param[out] The world matrix of the component
@@ -352,14 +344,6 @@ public:
   void GetWorldMatrixAndSize( TransformId id, Matrix& worldMatrix, Vector3& size ) const;
 
   /**
-   * Get the update size hint,
-   * @param[in] id Id of the transform component
-   * @return The update size hint of the component
-   */
-  const Vector3& GetUpdateSizeHint( TransformId id ) const;
-
-
-  /**
    * @brief Sets the boolean which states whether the position should use the anchor-point on the given transform component.
    * @param[in] id Id of the transform component
    * @param[in] value True if the position should use the anchor-point
@@ -399,7 +383,6 @@ private:
   Vector< Vector3 > mSize;                                                ///< Size of the components
   Vector< TransformId > mParent;                                          ///< Parent of the components
   Vector< Matrix > mWorld;                                                ///< Local to world transform of the components
-  Vector< Matrix > mPrevWorld;                                            ///< Local to world transform of the components in last frame
   Vector< Matrix > mLocal;                                                ///< Local to parent space transform of the components
   Vector< Vector4 > mBoundingSpheres;                                     ///< Bounding spheres. xyz is the center and w is the radius
   Vector< TransformComponentAnimatable > mTxComponentAnimatableBaseValue; ///< Base values for the animatable part of the components
@@ -407,9 +390,6 @@ private:
   Vector< bool > mComponentDirty;                                         ///< 1u if some of the parts of the component has changed in this frame, 0 otherwise
   Vector< bool > mLocalMatrixDirty;                                       ///< 1u if the local matrix has been updated in this frame, 0 otherwise
   Vector< SOrderItem > mOrderedComponents;                                ///< Used to reorder components when hierarchy changes
-  Vector< bool> mComponentChanged;                                        ///< Component is changed or not
-  Vector< Vector3 > mUpdateSizeHint;                                      ///< BoundingBox of the components
-  Vector< Vector3 > mUpdateSizeHintBase;                                     ///< Base value for the boundingBox of the components
   bool mReorder;                                                          ///< Flag to determine if the components have to reordered in the next Update
 };
 
old mode 100755 (executable)
new mode 100644 (file)
index 4d1842e..571e8b3
@@ -426,8 +426,6 @@ void UpdateManager::ConnectNode( Node* parent, Node* node )
 
   parent->ConnectChild( node );
 
-  parent->SetPropertyDirty( true );
-
   // Inform the frame-callback-processor, if set, about the node-hierarchy changing
   if( mImpl->frameCallbackProcessor )
   {
@@ -635,8 +633,6 @@ void UpdateManager::RemoveRenderer( Renderer* renderer )
 {
   DALI_LOG_INFO( gLogFilter, Debug::General, "[%x] RemoveRenderer\n", renderer );
 
-  renderer->SetDirty( true );
-
   // Find the renderer and destroy it
   EraseUsingDiscardQueue( mImpl->renderers, renderer, mImpl->discardQueue, mSceneGraphBuffers.GetUpdateBufferIndex() );
   // Need to remove the render object as well
old mode 100755 (executable)
new mode 100644 (file)
old mode 100755 (executable)
new mode 100644 (file)
index a005dd3..3fdb2e2
@@ -105,7 +105,6 @@ public:
    */
   virtual void Process( BufferIndex updateBufferIndex )
   {
-    mNode->SetPropertyDirty( true );
     (mProperty->*mMemberFunction)( updateBufferIndex, mParam );
   }
 
@@ -187,7 +186,6 @@ public:
    */
   virtual void Process( BufferIndex updateBufferIndex )
   {
-    mNode->SetPropertyDirty( true );
     (mProperty->*mMemberFunction)( updateBufferIndex, mParam );
   }
 
@@ -267,7 +265,6 @@ public:
    */
   virtual void Process( BufferIndex updateBufferIndex )
   {
-    mNode->SetPropertyDirty( true );
     (mProperty->*mMemberFunction)( updateBufferIndex, mParam );
   }
 
@@ -347,7 +344,6 @@ public:
    */
   virtual void Process( BufferIndex updateBufferIndex )
   {
-    mNode->SetPropertyDirty( true );
     (mProperty->*mMemberFunction)( updateBufferIndex, mParam );
   }
 
index 68ffe7e..d80d7c4 100755 (executable)
@@ -87,7 +87,6 @@ Node::Node()
   mPosition( TRANSFORM_PROPERTY_POSITION ),                                       // Zero initialized by default
   mOrientation(),                                                                 // Initialized to identity by default
   mScale( TRANSFORM_PROPERTY_SCALE ),
-  mUpdateSizeHint( TRANSFORM_PROPERTY_UPDATE_SIZE_HINT ),
   mVisible( true ),
   mCulled( false ),
   mColor( Color::WHITE ),
@@ -115,7 +114,6 @@ Node::Node()
 {
   mUniformMapChanged[0] = 0u;
   mUniformMapChanged[1] = 0u;
-  mPropertyDirty = false;
 
 #ifdef DEBUG_ENABLED
   gNodeCount++;
@@ -155,7 +153,6 @@ void Node::CreateTransform( SceneGraph::TransformManager* transformManager )
   //Initialize all the animatable properties
   mPosition.Initialize( transformManager, mTransformId );
   mScale.Initialize( transformManager, mTransformId );
-  mUpdateSizeHint.Initialize( transformManager, mTransformId );
   mOrientation.Initialize( transformManager, mTransformId );
   mSize.Initialize( transformManager, mTransformId );
   mParentOrigin.Initialize( transformManager, mTransformId );
@@ -286,7 +283,6 @@ void Node::AddRenderer( Renderer* renderer )
   }
 
   mRenderer.PushBack( renderer );
-  SetPropertyDirty( true );
 }
 
 void Node::RemoveRenderer( const Renderer* renderer )
@@ -296,7 +292,6 @@ void Node::RemoveRenderer( const Renderer* renderer )
   {
     if( mRenderer[i] == renderer )
     {
-      SetPropertyDirty( true );
       mRenderer.Erase( mRenderer.Begin()+i);
       return;
     }
@@ -336,14 +331,6 @@ NodePropertyFlags Node::GetInheritedDirtyFlags( NodePropertyFlags parentFlags )
 void Node::ResetDirtyFlags( BufferIndex updateBufferIndex )
 {
   mDirtyFlags = NodePropertyFlags::NOTHING;
-
-  SetPropertyDirty( false );
-
-  for( auto&& existingRenderer : mRenderer )
-  {
-    existingRenderer->SetDirty( false );
-  }
-
 }
 
 void Node::SetParent( Node& parentNode )
@@ -386,31 +373,6 @@ void Node::RecursiveDisconnectFromSceneGraph( BufferIndex updateBufferIndex )
   }
 }
 
-void Node::SetPropertyDirty( bool value )
-{
-  mPropertyDirty = value;
-
-  const NodeIter endIter = mChildren.End();
-  for ( NodeIter iter = mChildren.Begin(); iter != endIter; ++iter )
-  {
-    Node* current = *iter;
-    current->SetPropertyDirty( value );
-  }
-}
-
-bool Node::IsPropertyDirty() const
-{
-  for( auto&& existingRenderer : mRenderer )
-  {
-    if( existingRenderer->IsDirty() )
-    {
-      return true;
-    }
-  }
-
-  return mPropertyDirty;
-}
-
 } // namespace SceneGraph
 
 } // namespace Internal
index 5600523..5cd6073 100755 (executable)
@@ -182,7 +182,6 @@ public:
    */
   void SetClippingMode( const ClippingMode::Type clippingMode )
   {
-    SetPropertyDirty( true );
     mClippingMode = clippingMode;
   }
 
@@ -314,7 +313,6 @@ public:
    */
   void SetDirtyFlag( NodePropertyFlags flag )
   {
-    SetPropertyDirty( true );
     mDirtyFlags |= flag;
   }
 
@@ -323,7 +321,6 @@ public:
    */
   void SetAllDirtyFlags()
   {
-    SetPropertyDirty( true );
     mDirtyFlags = NodePropertyFlags::ALL;
   }
 
@@ -687,7 +684,6 @@ public:
    */
   void SetDrawMode( const DrawMode::Type& drawMode )
   {
-    SetPropertyDirty( true );
     mDrawMode = drawMode;
   }
 
@@ -724,7 +720,6 @@ public:
    */
   void SetDepthIndex( uint32_t depthIndex )
   {
-    SetPropertyDirty( true );
     mDepthIndex = depthIndex;
   }
 
@@ -770,42 +765,6 @@ public:
     return mCulled[bufferIndex];
   }
 
-  /**
- * @Is component changed
- * @Return true if component is changed else false
- */
-  bool IsComponentChanged()
-  {
-    return (mTransformId != INVALID_TRANSFORM_ID) &&
-           (mTransformManager->IsComponentChanged( mTransformId ));
-  }
-
-  /**
-   * Retrieve the update size hint of the node
-   * @return A vector3 describing the update size hint
-   */
-  const Vector3& GetUpdateSizeHint( BufferIndex bufferIndex ) const
-  {
-    if( mTransformId != INVALID_TRANSFORM_ID )
-    {
-      return mTransformManager->GetUpdateSizeHint( mTransformId );
-    }
-
-    return Vector3::ZERO;
-  }
-
-  /**
-   * Set whether partial update needs to run following a render.
-   * @param[in] value Set to true if an partial update is required to be run
-   */
-  virtual void SetPropertyDirty( bool value );
-
-  /**
-   * Query the property status following rendering of a frame.
-   * @return True if the property has changed
-   */
-  virtual bool IsPropertyDirty() const;
-
 public:
   /**
    * @copydoc UniformMap::Add
@@ -918,7 +877,6 @@ public: // Default properties
   TransformManagerPropertyVector3    mPosition;               ///< Local transform; distance between parent-origin & anchor-point
   TransformManagerPropertyQuaternion mOrientation;            ///< Local transform; rotation relative to parent node
   TransformManagerPropertyVector3    mScale;                  ///< Local transform; scale relative to parent node
-  TransformManagerPropertyVector3    mUpdateSizeHint;         ///< Local transform; update size hint is provided for partial update
 
   AnimatableProperty<bool>           mVisible;                ///< Visibility can be inherited from the Node hierachy
   AnimatableProperty<bool>           mCulled;                 ///< True if the node is culled. This is not animatable. It is just double-buffered.
index d23419c..8f9ff00 100755 (executable)
@@ -64,7 +64,6 @@ void Layer::SetSortFunction( Dali::Layer::SortFunctionType function )
 {
   if( mSortFunction != function )
   {
-    SetPropertyDirty( true );
     // is a custom sort function used
     if( function != Internal::Layer::ZValue )
     {
@@ -85,25 +84,21 @@ void Layer::SetSortFunction( Dali::Layer::SortFunctionType function )
 void Layer::SetClipping(bool enabled)
 {
   mIsClipping = enabled;
-  SetPropertyDirty( true );
 }
 
 void Layer::SetClippingBox(const Dali::ClippingBox& box)
 {
   mClippingBox.Set(box.x, box.y, box.width, box.height);
-  SetPropertyDirty( true );
 }
 
 void Layer::SetBehavior( Dali::Layer::Behavior behavior )
 {
   mBehavior = behavior;
-  SetPropertyDirty( true );
 }
 
 void Layer::SetDepthTestDisabled( bool disable )
 {
   mDepthTestDisabled = disable;
-  SetPropertyDirty( true );
 }
 
 bool Layer::IsDepthTestDisabled() const
old mode 100755 (executable)
new mode 100644 (file)
index 98f81ef..169be5c
@@ -143,7 +143,6 @@ Renderer::Renderer()
   mDepthTestMode( DepthTestMode::AUTO ),
   mRenderingBehavior( DevelRenderer::Rendering::IF_REQUIRED ),
   mPremultipledAlphaEnabled( false ),
-  mDirty( false ),
   mOpacity( 1.0f ),
   mDepthIndex( 0 )
 {
@@ -182,7 +181,6 @@ void Renderer::PrepareRender( BufferIndex updateBufferIndex )
   }
   else
   {
-    mDirty = true;
     if( mRegenerateUniformMap == REGENERATE_UNIFORM_MAP)
     {
       CollectedUniformMap& localMap = mCollectedUniformMap[ updateBufferIndex ];
@@ -217,7 +215,6 @@ void Renderer::PrepareRender( BufferIndex updateBufferIndex )
 
   if( mResendFlag != 0 )
   {
-    mDirty = true;
     if( mResendFlag & RESEND_GEOMETRY )
     {
       typedef MessageValue1< Render::Renderer, Render::Geometry* > DerivedType;
@@ -398,7 +395,6 @@ void Renderer::SetGeometry( Render::Geometry* geometry )
 void Renderer::SetDepthIndex( int depthIndex )
 {
   mDepthIndex = depthIndex;
-  mDirty = true;
 }
 
 void Renderer::SetFaceCullingMode( FaceCullingMode::Type faceCullingMode )
@@ -415,7 +411,6 @@ FaceCullingMode::Type Renderer::GetFaceCullingMode() const
 void Renderer::SetBlendMode( BlendMode::Type blendingMode )
 {
   mBlendMode = blendingMode;
-  mDirty = true;
 }
 
 BlendMode::Type Renderer::GetBlendMode() const
@@ -588,7 +583,6 @@ const Render::Renderer::StencilParameters& Renderer::GetStencilParameters() cons
 
 void Renderer::BakeOpacity( BufferIndex updateBufferIndex, float opacity )
 {
-  mDirty = true;
   mOpacity.Bake( updateBufferIndex, opacity );
 }
 
@@ -600,7 +594,6 @@ float Renderer::GetOpacity( BufferIndex updateBufferIndex ) const
 void Renderer::SetRenderingBehavior( DevelRenderer::Rendering::Type renderingBehavior )
 {
   mRenderingBehavior = renderingBehavior;
-  mDirty = true;
 }
 
 DevelRenderer::Rendering::Type Renderer::GetRenderingBehavior() const
@@ -619,6 +612,7 @@ void Renderer::ConnectToSceneGraph( SceneController& sceneController, BufferInde
 
   mRenderer = Render::Renderer::New( mRenderDataProvider, mGeometry, mBlendBitmask, GetBlendColor(), static_cast< FaceCullingMode::Type >( mFaceCullingMode ),
                                          mPremultipledAlphaEnabled, mDepthWriteMode, mDepthTestMode, mDepthFunction, mStencilParameters );
+
   OwnerPointer< Render::Renderer > transferOwnership( mRenderer );
   mSceneController->GetRenderMessageDispatcher().AddRenderer( transferOwnership );
 }
@@ -656,7 +650,6 @@ void Renderer::UpdateTextureSet()
       mRenderDataProvider->mTextures.clear();
       mRenderDataProvider->mSamplers.clear();
     }
-    mDirty = true;
   }
 }
 
@@ -762,46 +755,6 @@ void Renderer::ObservedObjectDestroyed(PropertyOwner& owner)
   }
 }
 
-void Renderer::SetDirty( bool value )
-{
-  mDirty = value;
-  if( mShader )
-  {
-    mShader->SetPropertyDirty( value );
-  }
-}
-
-bool Renderer::IsDirty() const
-{
-  bool ret = false;
-  if( mShader )
-  {
-    ret = mShader->IsPropertyDirty();
-  }
-
-  // check native image
-  if( mTextureSet )
-  {
-    uint32_t textureCount = mTextureSet->GetTextureCount();
-
-    if(textureCount > 0)
-    {
-      Dali::Internal::Render::Texture* texture;
-      for( uint32_t i = 0; i<textureCount; ++i )
-      {
-        texture = const_cast<Dali::Internal::SceneGraph::TextureSet *>(mTextureSet)->GetTexture(i);
-        if( texture && texture->IsNativeImage() )
-        {
-          ret = true;
-          break;
-        }
-      }
-    }
-  }
-
-  return ret | mDirty;
-}
-
 } // namespace SceneGraph
 } // namespace Internal
 } // namespace Dali
index 3dda873..7051e44 100755 (executable)
@@ -380,18 +380,6 @@ public:
    */
   void DisconnectFromSceneGraph( SceneController& sceneController, BufferIndex bufferIndex );
 
-  /**
-   * Enable/Disable Partial update dirty flag
-   * @param[in] true to mark dirty else false
-   */
-  void SetDirty( bool value );
-
-  /**
-   * Get Partial update dirty flag
-   * @return true if dirty else false
-   */
-  bool IsDirty() const;
-
 public: // Implementation of ConnectionChangePropagator
   /**
    * @copydoc ConnectionChangePropagator::AddObserver
@@ -485,7 +473,6 @@ private:
 
   bool                         mUniformMapChanged[2];             ///< Records if the uniform map has been altered this frame
   bool                         mPremultipledAlphaEnabled:1;       ///< Flag indicating whether the Pre-multiplied Alpha Blending is required
-  bool                         mDirty:1;                          ///< Required for marking it dirty in case of partial update.
 
 public: