scsi: ufs: wb: Modify messages
authorJinyoung Choi <j-young.choi@samsung.com>
Thu, 4 Aug 2022 07:55:19 +0000 (16:55 +0900)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 23 Aug 2022 03:16:50 +0000 (23:16 -0400)
Modify messages to fit the format of others.

Link: https://lore.kernel.org/r/20220804075519epcms2p148b6ae956b172925b26304b50d6a0da9@epcms2p1
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Jinyoung Choi <j-young.choi@samsung.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/core/ufs-sysfs.c
drivers/ufs/core/ufshcd.c

index e2cf49dcc17a593a3b1333c501dffe21ca5c1ccc..600abcc535e338a441e4a2470b19827cdf3cbb70 100644 (file)
@@ -231,7 +231,7 @@ static ssize_t wb_on_store(struct device *dev, struct device_attribute *attr,
                 * If the platform supports UFSHCD_CAP_CLK_SCALING, turn WB
                 * on/off will be done while clock scaling up/down.
                 */
-               dev_warn(dev, "To control WB through wb_on is not allowed!\n");
+               dev_warn(dev, "It is not allowed to configure WB!\n");
                return -EOPNOTSUPP;
        }
 
index e7c55d50a2e692c6bc187746bb4f265e1f622c76..7c15cbc737b44dc6414f8c85c04f6ddc0a0d5215 100644 (file)
@@ -5765,13 +5765,13 @@ int ufshcd_wb_toggle(struct ufs_hba *hba, bool enable)
 
        ret = __ufshcd_wb_toggle(hba, enable, QUERY_FLAG_IDN_WB_EN);
        if (ret) {
-               dev_err(hba->dev, "%s Write Booster %s failed %d\n",
-                       __func__, enable ? "enable" : "disable", ret);
+               dev_err(hba->dev, "%s: Write Booster %s failed %d\n",
+                       __func__, enable ? "enabling" : "disabling", ret);
                return ret;
        }
 
        hba->dev_info.wb_enabled = enable;
-       dev_dbg(hba->dev, "%s Write Booster %s\n",
+       dev_dbg(hba->dev, "%s: Write Booster %s\n",
                        __func__, enable ? "enabled" : "disabled");
 
        return ret;
@@ -5785,11 +5785,11 @@ static void ufshcd_wb_toggle_buf_flush_during_h8(struct ufs_hba *hba,
        ret = __ufshcd_wb_toggle(hba, enable,
                        QUERY_FLAG_IDN_WB_BUFF_FLUSH_DURING_HIBERN8);
        if (ret) {
-               dev_err(hba->dev, "%s: WB-Buf Flush during H8 %s failed: %d\n",
-                       __func__, enable ? "enable" : "disable", ret);
+               dev_err(hba->dev, "%s: WB-Buf Flush during H8 %s failed %d\n",
+                       __func__, enable ? "enabling" : "disabling", ret);
                return;
        }
-       dev_dbg(hba->dev, "%s WB-Buf Flush during H8 %s\n",
+       dev_dbg(hba->dev, "%s: WB-Buf Flush during H8 %s\n",
                        __func__, enable ? "enabled" : "disabled");
 }
 
@@ -5803,14 +5803,13 @@ int ufshcd_wb_toggle_buf_flush(struct ufs_hba *hba, bool enable)
 
        ret = __ufshcd_wb_toggle(hba, enable, QUERY_FLAG_IDN_WB_BUFF_FLUSH_EN);
        if (ret) {
-               dev_err(hba->dev, "%s WB-Buf Flush %s failed %d\n", __func__,
-                       enable ? "enable" : "disable", ret);
+               dev_err(hba->dev, "%s: WB-Buf Flush %s failed %d\n",
+                       __func__, enable ? "enabling" : "disabling", ret);
                return ret;
        }
 
        hba->dev_info.wb_buf_flush_enabled = enable;
-
-       dev_dbg(hba->dev, "%s WB-Buf Flush %s\n",
+       dev_dbg(hba->dev, "%s: WB-Buf Flush %s\n",
                        __func__, enable ? "enabled" : "disabled");
 
        return ret;
@@ -5828,7 +5827,7 @@ static bool ufshcd_wb_presrv_usrspc_keep_vcc_on(struct ufs_hba *hba,
                                              QUERY_ATTR_IDN_CURR_WB_BUFF_SIZE,
                                              index, 0, &cur_buf);
        if (ret) {
-               dev_err(hba->dev, "%s dCurWriteBoosterBufferSize read failed %d\n",
+               dev_err(hba->dev, "%s: dCurWriteBoosterBufferSize read failed %d\n",
                        __func__, ret);
                return false;
        }
@@ -5913,7 +5912,7 @@ static bool ufshcd_wb_need_flush(struct ufs_hba *hba)
                                      QUERY_ATTR_IDN_AVAIL_WB_BUFF_SIZE,
                                      index, 0, &avail_buf);
        if (ret) {
-               dev_warn(hba->dev, "%s dAvailableWriteBoosterBufferSize read failed %d\n",
+               dev_warn(hba->dev, "%s: dAvailableWriteBoosterBufferSize read failed %d\n",
                         __func__, ret);
                return false;
        }