lib: Fix the unchecked return value
authorTedd Ho-Jeong An <hj.tedd.an@gmail.com>
Fri, 20 Nov 2020 20:07:12 +0000 (12:07 -0800)
committerAyush Garg <ayush.garg@samsung.com>
Fri, 11 Mar 2022 13:38:34 +0000 (19:08 +0530)
This patch fixes the unchecked return value.

Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
lib/hci.c
lib/sdp.c

index 587716c..6593763 100755 (executable)
--- a/lib/hci.c
+++ b/lib/hci.c
@@ -1287,12 +1287,14 @@ int hci_send_req(int dd, struct hci_request *r, int to)
 
 failed:
        err = errno;
-       setsockopt(dd, SOL_HCI, HCI_FILTER, &of, sizeof(of));
+       if (setsockopt(dd, SOL_HCI, HCI_FILTER, &of, sizeof(of)) < 0)
+               err = errno;
        errno = err;
        return -1;
 
 done:
-       setsockopt(dd, SOL_HCI, HCI_FILTER, &of, sizeof(of));
+       if (setsockopt(dd, SOL_HCI, HCI_FILTER, &of, sizeof(of)) < 0)
+               return -1;
        return 0;
 }
 
index ebaed3e..844ae0d 100755 (executable)
--- a/lib/sdp.c
+++ b/lib/sdp.c
@@ -4705,7 +4705,8 @@ static int sdp_connect_l2cap(const bdaddr_t *src,
 
        if (flags & SDP_WAIT_ON_CLOSE) {
                struct linger l = { .l_onoff = 1, .l_linger = 1 };
-               setsockopt(sk, SOL_SOCKET, SO_LINGER, &l, sizeof(l));
+               if (setsockopt(sk, SOL_SOCKET, SO_LINGER, &l, sizeof(l)) < 0)
+                       return -1;
        }
 
        if ((flags & SDP_LARGE_MTU) &&