Revert "Fix for enabling self-broadcast-signal subscription" 77/92977/2
authorKarol Lewandowski <k.lewandowsk@samsung.com>
Wed, 19 Oct 2016 15:53:52 +0000 (17:53 +0200)
committerSeung-Woo Kim <sw0312.kim@samsung.com>
Fri, 28 Oct 2016 06:07:00 +0000 (23:07 -0700)
This reverts commit 8ebcf6b29cbc2838841b4eb5875a59c70f187b68.

Original fix is no longer needed - proper one has been applied
to systemd, which now does not forward broadcasts to itself
when kdbus is used.

Reference: https://github.com/systemd/systemd/commit/0a069ce62de904ae9cbaf23d026ac380b02e50e4

    core: harden cgroups-agent forwarding
    Author: David Herrmann <dh.herrmann@gmail.com>

    Furthermore, never forward broadcasts we sent ourself. This might happen
    on kdbus, as we forward the message on the same bus we received it on,
    thus ending up in an endless loop.

Change-Id: Ic81e519669603a839f863b931908e45c064501d8
Signed-off-by: Karol Lewandowski <k.lewandowsk@samsung.com>
ipc/kdbus/bus.c

index 485243cab57954fcf0a56fe9baf9acab40dfe92b..a67f825bdeaf02fb7e76187750ed28417db79e18 100644 (file)
@@ -263,9 +263,6 @@ void kdbus_bus_broadcast(struct kdbus_bus *bus,
 
        down_read(&bus->conn_rwlock);
        hash_for_each(bus->conn_hash, i, conn_dst, hentry) {
-               if ((conn_dst->id == staging->msg->src_id) && (current->tgid == 1))
-                       continue;
-
                if (!kdbus_conn_is_ordinary(conn_dst))
                        continue;