drm/amd/display: fix psp return condition for hdcp module
authorBhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Thu, 12 Dec 2019 16:44:18 +0000 (11:44 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 7 Jan 2020 17:13:05 +0000 (12:13 -0500)
We are returning SUCCESS when hdcp_status != Success. Fix it.

Signed-off-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c

index ef4eb55..03476bb 100644 (file)
@@ -794,7 +794,7 @@ enum mod_hdcp_status mod_hdcp_hdcp2_validate_stream_ready(struct mod_hdcp *hdcp)
        hdcp_cmd->cmd_id = TA_HDCP_COMMAND__HDCP2_PREPARE_PROCESS_AUTHENTICATION_MSG_V2;
        psp_hdcp_invoke(psp, hdcp_cmd->cmd_id);
 
-       return (hdcp_cmd->hdcp_status != TA_HDCP_STATUS__SUCCESS) &&
+       return (hdcp_cmd->hdcp_status == TA_HDCP_STATUS__SUCCESS) &&
                               (msg_out->process.msg1_status == TA_HDCP2_MSG_AUTHENTICATION_STATUS__SUCCESS)
                       ? MOD_HDCP_STATUS_SUCCESS
                       : MOD_HDCP_STATUS_HDCP2_VALIDATE_STREAM_READY_FAILURE;