habanalabs: failure to open device due to reset is debug level
authorOded Gabbay <ogabbay@kernel.org>
Mon, 19 Sep 2022 08:30:03 +0000 (11:30 +0300)
committerOded Gabbay <ogabbay@kernel.org>
Mon, 19 Sep 2022 12:09:04 +0000 (15:09 +0300)
If the user wants to open the device, and the device is currently in
reset, the user will get an error from the open().

We don't need to display an error in the dmesg for that as it is
not a real error and we can spam the kernel log with this message.

Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/misc/habanalabs/common/habanalabs_drv.c

index 5250bfb..112632a 100644 (file)
@@ -161,7 +161,7 @@ int hl_device_open(struct inode *inode, struct file *filp)
        mutex_lock(&hdev->fpriv_list_lock);
 
        if (!hl_device_operational(hdev, &status)) {
-               dev_err_ratelimited(hdev->dev,
+               dev_dbg_ratelimited(hdev->dev,
                        "Can't open %s because it is %s\n",
                        dev_name(hdev->dev), hdev->status[status]);
 
@@ -271,7 +271,7 @@ int hl_device_open_ctrl(struct inode *inode, struct file *filp)
        mutex_lock(&hdev->fpriv_ctrl_list_lock);
 
        if (!hl_device_operational(hdev, NULL)) {
-               dev_err_ratelimited(hdev->dev_ctrl,
+               dev_dbg_ratelimited(hdev->dev_ctrl,
                        "Can't open %s because it is disabled or in reset\n",
                        dev_name(hdev->dev_ctrl));
                rc = -EPERM;