Input: adp5588-keys - use new PM macros
authorNuno Sá <nuno.sa@analog.com>
Wed, 31 Aug 2022 04:15:03 +0000 (21:15 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 31 Aug 2022 04:16:35 +0000 (21:16 -0700)
With the new PM macros (DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr()), the
compiler has visibility to see that the functions are not used when
!CONFIG_PM and hence, remove the dead code. As such, there's no need
for '__maybe_unused'.

Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20220829131553.690063-11-nuno.sa@analog.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/adp5588-keys.c

index 1db6b28..7cd83c8 100644 (file)
@@ -827,7 +827,7 @@ static void adp5588_remove(struct i2c_client *client)
        /* all resources will be freed by devm */
 }
 
-static int __maybe_unused adp5588_suspend(struct device *dev)
+static int adp5588_suspend(struct device *dev)
 {
        struct i2c_client *client = to_i2c_client(dev);
 
@@ -836,7 +836,7 @@ static int __maybe_unused adp5588_suspend(struct device *dev)
        return 0;
 }
 
-static int __maybe_unused adp5588_resume(struct device *dev)
+static int adp5588_resume(struct device *dev)
 {
        struct i2c_client *client = to_i2c_client(dev);
 
@@ -845,7 +845,7 @@ static int __maybe_unused adp5588_resume(struct device *dev)
        return 0;
 }
 
-static SIMPLE_DEV_PM_OPS(adp5588_dev_pm_ops, adp5588_suspend, adp5588_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(adp5588_dev_pm_ops, adp5588_suspend, adp5588_resume);
 
 static const struct i2c_device_id adp5588_id[] = {
        { "adp5588-keys", 0 },
@@ -865,7 +865,7 @@ static struct i2c_driver adp5588_driver = {
        .driver = {
                .name = KBUILD_MODNAME,
                .of_match_table = adp5588_of_match,
-               .pm   = &adp5588_dev_pm_ops,
+               .pm   = pm_sleep_ptr(&adp5588_dev_pm_ops),
        },
        .probe    = adp5588_probe,
        .remove   = adp5588_remove,