gpio: dwapb: Drop bogus BUG_ON()s

There is no case when no context is provided in the ->suspend() and
->resume() hooks. Moreover, BUG_ON() is harmful to user and makes kernel
inoperable after the crash. Drop the BUG_ON()s for good.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Serge Semin <fancer.lancer@gmail.com>
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Link: https://lore.kernel.org/r/20200415141534.31240-11-andriy.shevchenko@linux.intel.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index 0b073cb..ae4c4db 100644 (file)
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -723,8 +723,6 @@ static int dwapb_gpio_suspend(struct device *dev)
                unsigned int idx = gpio->ports[i].idx;
                struct dwapb_context *ctx = gpio->ports[i].ctx;
 
-               BUG_ON(!ctx);
-
                offset = GPIO_SWPORTA_DDR + idx * GPIO_SWPORT_DDR_STRIDE;
                ctx->dir = dwapb_read(gpio, offset);
 
@@ -773,8 +771,6 @@ static int dwapb_gpio_resume(struct device *dev)
                unsigned int idx = gpio->ports[i].idx;
                struct dwapb_context *ctx = gpio->ports[i].ctx;
 
-               BUG_ON(!ctx);
-
                offset = GPIO_SWPORTA_DR + idx * GPIO_SWPORT_DR_STRIDE;
                dwapb_write(gpio, offset, ctx->data);