Fix buffer.slice(0, 0)

diff --git a/lib/buffer.js b/lib/buffer.js
index d2b87ecdb96e13f2897834c36559c45f136d733d..b777bf0725f42ddcb563982d2507e0ebb3bfcd16 100644 (file)
--- a/lib/buffer.js
+++ b/lib/buffer.js
@@ -322,7 +322,7 @@ Buffer.prototype.copy = function copy (target, target_start, start, end) {
 
 // slice(start, end)
 Buffer.prototype.slice = function (start, end) {
-  if (!end) end = this.length;
+  if (end === undefined) end = this.length;
   if (end > this.length) throw new Error("oob");
   if (start > end) throw new Error("oob");
 

diff --git a/test/simple/test-buffer.js b/test/simple/test-buffer.js
index 26ebd4798a23f2b2ce56114718874ef56f7c5229..d98da04ed909232ea749e381c0dc7864941de523 100644 (file)
--- a/test/simple/test-buffer.js
+++ b/test/simple/test-buffer.js
@@ -353,3 +353,7 @@ assert.equal(14, Buffer.byteLength("Il était tué"));
 assert.equal(14, Buffer.byteLength("Il était tué", "utf8"));
 assert.equal(12, Buffer.byteLength("Il était tué", "ascii"));
 assert.equal(12, Buffer.byteLength("Il était tué", "binary"));
+
+
+// slice(0,0).length === 0
+assert.equal(0, Buffer('hello').slice(0, 0).length)