Input: elantech - make arrays debounce_packet static, reduces object code size
authorColin Ian King <colin.king@canonical.com>
Thu, 7 Sep 2017 21:27:26 +0000 (14:27 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 11 Sep 2017 21:23:40 +0000 (14:23 -0700)
Don't populate the arrays debounce_packet on the stack, instead make
them static.  Makes the object code smaller by over 870 bytes:

Before:
   text    data     bss     dec     hex filename
  30553    9152       0   39705    9b19 drivers/input/mouse/elantech.o

After:
   text    data     bss     dec     hex filename
  29521    9312       0   38833    97b1 drivers/input/mouse/elantech.o

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/mouse/elantech.c

index 6428d6f..b84cd97 100644 (file)
@@ -700,7 +700,9 @@ static int elantech_debounce_check_v2(struct psmouse *psmouse)
          * When we encounter packet that matches this exactly, it means the
          * hardware is in debounce status. Just ignore the whole packet.
          */
-        const u8 debounce_packet[] = { 0x84, 0xff, 0xff, 0x02, 0xff, 0xff };
+       static const u8 debounce_packet[] = {
+               0x84, 0xff, 0xff, 0x02, 0xff, 0xff
+       };
         unsigned char *packet = psmouse->packet;
 
         return !memcmp(packet, debounce_packet, sizeof(debounce_packet));
@@ -741,7 +743,9 @@ static int elantech_packet_check_v2(struct psmouse *psmouse)
 static int elantech_packet_check_v3(struct psmouse *psmouse)
 {
        struct elantech_data *etd = psmouse->private;
-       const u8 debounce_packet[] = { 0xc4, 0xff, 0xff, 0x02, 0xff, 0xff };
+       static const u8 debounce_packet[] = {
+               0xc4, 0xff, 0xff, 0x02, 0xff, 0xff
+       };
        unsigned char *packet = psmouse->packet;
 
        /*