soundwire: qcom: Use IRQF_ONESHOT
authorSamuel Zou <zou_wei@huawei.com>
Wed, 6 May 2020 03:25:53 +0000 (11:25 +0800)
committerVinod Koul <vkoul@kernel.org>
Mon, 11 May 2020 06:09:54 +0000 (11:39 +0530)
Fixes coccicheck error:

drivers/soundwire/qcom.c:815:7-32: ERROR: Threaded IRQ with
no primary handler requested without IRQF_ONESHOT

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Samuel Zou <zou_wei@huawei.com>
Link: https://lore.kernel.org/r/1588735553-34219-1-git-send-email-zou_wei@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/qcom.c

index e08a17c..a2a35f7 100644 (file)
@@ -814,7 +814,8 @@ static int qcom_swrm_probe(struct platform_device *pdev)
 
        ret = devm_request_threaded_irq(dev, ctrl->irq, NULL,
                                        qcom_swrm_irq_handler,
-                                       IRQF_TRIGGER_RISING,
+                                       IRQF_TRIGGER_RISING |
+                                       IRQF_ONESHOT,
                                        "soundwire", ctrl);
        if (ret) {
                dev_err(dev, "Failed to request soundwire irq\n");