staging: comedi: cb_pcidas: check for failure of subdev_8255_init
authorH Hartley Sweeten <hartleys@visionengravers.com>
Wed, 27 Jun 2012 01:03:34 +0000 (18:03 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Jul 2012 22:23:53 +0000 (15:23 -0700)
It's possible for subdev_8255_init() to fail due to its kzalloc().
Make sure to check for this failure and pass on the error code.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/cb_pcidas.c

index 9379d25..a033071 100644 (file)
@@ -1640,7 +1640,10 @@ static int cb_pcidas_attach(struct comedi_device *dev,
 
        /* 8255 */
        s = dev->subdevices + 2;
-       subdev_8255_init(dev, s, NULL, devpriv->pacer_counter_dio + DIO_8255);
+       ret = subdev_8255_init(dev, s, NULL,
+                              devpriv->pacer_counter_dio + DIO_8255);
+       if (ret)
+               return ret;
 
        /*  serial EEPROM, */
        s = dev->subdevices + 3;