example: Fix build warnings of customer_database.
authorAndreas Schneider <asn@cryptomilk.org>
Tue, 31 May 2011 20:02:33 +0000 (22:02 +0200)
committerAndreas Schneider <asn@cryptomilk.org>
Tue, 31 May 2011 20:02:33 +0000 (22:02 +0200)
src/example/customer_database.c
src/example/customer_database_test.c

index fc0e3a2..d280de2 100644 (file)
 #define snprintf _snprintf
 #endif // _WIN32
 
+DatabaseConnection* connect_to_customer_database(void);
+unsigned int get_customer_id_by_name(
+        DatabaseConnection * const connection,
+        const char * const customer_name);
+
 // Connect to the database containing customer information.
-DatabaseConnection* connect_to_customer_database() {
+DatabaseConnection* connect_to_customer_database(void) {
     return connect_to_database("customers.abcd.org", 321);
 }
 
index 202037e..d8cc6ca 100644 (file)
@@ -24,7 +24,7 @@ extern unsigned int get_customer_id_by_name(
     DatabaseConnection * const connection, const char * const customer_name);
 
 // Mock query database function.
-unsigned int mock_query_database(
+static unsigned int mock_query_database(
         DatabaseConnection* const connection, const char * const query_string,
         void *** const results) {
     *results = (void**)((unsigned)mock());
@@ -37,19 +37,19 @@ DatabaseConnection* connect_to_database(const char * const database_url,
     return (DatabaseConnection*)((unsigned)mock());
 }
 
-void test_connect_to_customer_database(void **state) {
+static void test_connect_to_customer_database(void **state) {
     will_return(connect_to_database, 0x0DA7ABA53);
     assert_int_equal((int)connect_to_customer_database(), 0x0DA7ABA53);
 }
 
 /* This test fails as the mock function connect_to_database() will have no
  * value to return. */
-void fail_connect_to_customer_database(void **state) {
+static void fail_connect_to_customer_database(void **state) {
     assert_true(connect_to_customer_database() ==
                 (DatabaseConnection*)0x0DA7ABA53);
 }
 
-void test_get_customer_id_by_name(void **state) {
+static void test_get_customer_id_by_name(void **state) {
     DatabaseConnection connection = {
         "somedatabase.somewhere.com", 12345678, mock_query_database
     };
@@ -60,7 +60,7 @@ void test_get_customer_id_by_name(void **state) {
     assert_int_equal(get_customer_id_by_name(&connection, "john doe"), 543);
 }
 
-int main(int argc, char* argv[]) {
+int main(void) {
     const UnitTest tests[] = {
         unit_test(test_connect_to_customer_database),
         unit_test(test_get_customer_id_by_name),