media: rkisp1: make a few const arrays static
authorColin Ian King <colin.i.king@gmail.com>
Thu, 5 Jan 2023 18:44:03 +0000 (19:44 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Wed, 8 Feb 2023 06:29:23 +0000 (07:29 +0100)
Don't populate the const arrays on the stack, instead make them
static. Also makes the object code smaller.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c

index d454068..d1d1fdc 100644 (file)
@@ -1131,10 +1131,12 @@ static void rkisp1_try_fmt(const struct rkisp1_capture *cap,
        const struct rkisp1_capture_config *config = cap->config;
        const struct rkisp1_capture_fmt_cfg *fmt;
        const struct v4l2_format_info *info;
-       const unsigned int max_widths[] = { RKISP1_RSZ_MP_SRC_MAX_WIDTH,
-                                           RKISP1_RSZ_SP_SRC_MAX_WIDTH };
-       const unsigned int max_heights[] = { RKISP1_RSZ_MP_SRC_MAX_HEIGHT,
-                                            RKISP1_RSZ_SP_SRC_MAX_HEIGHT};
+       static const unsigned int max_widths[] = {
+               RKISP1_RSZ_MP_SRC_MAX_WIDTH, RKISP1_RSZ_SP_SRC_MAX_WIDTH
+       };
+       static const unsigned int max_heights[] = {
+               RKISP1_RSZ_MP_SRC_MAX_HEIGHT, RKISP1_RSZ_SP_SRC_MAX_HEIGHT
+       };
 
        fmt = rkisp1_find_fmt_cfg(cap, pixm->pixelformat);
        if (!fmt) {
@@ -1336,8 +1338,9 @@ void rkisp1_capture_devs_unregister(struct rkisp1_device *rkisp1)
 
 static int rkisp1_register_capture(struct rkisp1_capture *cap)
 {
-       const char * const dev_names[] = {RKISP1_MP_DEV_NAME,
-                                         RKISP1_SP_DEV_NAME};
+       static const char * const dev_names[] = {
+               RKISP1_MP_DEV_NAME, RKISP1_SP_DEV_NAME
+       };
        struct v4l2_device *v4l2_dev = &cap->rkisp1->v4l2_dev;
        struct video_device *vdev = &cap->vnode.vdev;
        struct rkisp1_vdev_node *node;