io_uring: check non-sync defer_list carefully
authorPavel Begunkov <asml.silence@gmail.com>
Fri, 1 May 2020 14:09:37 +0000 (17:09 +0300)
committerJens Axboe <axboe@kernel.dk>
Fri, 1 May 2020 14:50:30 +0000 (08:50 -0600)
io_req_defer() do double-checked locking. Use proper helpers for that,
i.e. list_empty_careful().

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c

index 7f10af0..91ddc27 100644 (file)
@@ -5031,7 +5031,7 @@ static int io_req_defer(struct io_kiocb *req, const struct io_uring_sqe *sqe)
        int ret;
 
        /* Still need defer if there is pending req in defer list. */
-       if (!req_need_defer(req) && list_empty(&ctx->defer_list))
+       if (!req_need_defer(req) && list_empty_careful(&ctx->defer_list))
                return 0;
 
        if (!req->io && io_alloc_async_ctx(req))