cifs: fix error handling when cifscreds key payload is an error
authorJeff Layton <jlayton@redhat.com>
Tue, 7 Feb 2012 11:30:51 +0000 (06:30 -0500)
committerSteve French <smfrench@gmail.com>
Wed, 8 Feb 2012 04:25:26 +0000 (22:25 -0600)
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <smfrench@gmail.com>
fs/cifs/connect.c

index 9c28865..940189b 100644 (file)
@@ -2125,7 +2125,7 @@ cifs_set_cifscreds(struct smb_vol *vol, struct cifs_ses *ses)
        down_read(&key->sem);
        upayload = key->payload.data;
        if (IS_ERR_OR_NULL(upayload)) {
-               rc = PTR_ERR(key);
+               rc = upayload ? PTR_ERR(upayload) : -EINVAL;
                goto out_key_put;
        }