re PR libfortran/54736 (GFORTRAN_CONVERT_UNIT causes malloc error on several platforms)

2012-10-06  Thomas König  <tkoenig@gcc.gnu.org>

	PR libfortran/54736
	* runtime/environ.c (search_unit):  Correct logic
	for binary search.
	(mark_single):  Fix index errors.

From-SVN: r192158

diff --git a/libgfortran/ChangeLog b/libgfortran/ChangeLog
index feeb10a41462f5fd068e16a87a096de59f619fce..de915f8a78e9a28648aa6ee6274827dea946ecad 100644 (file)
--- a/libgfortran/ChangeLog
+++ b/libgfortran/ChangeLog
@@ -1,3 +1,10 @@
+2012-10-06  Thomas König  <tkoenig@gcc.gnu.org>
+
+       PR libfortran/54736
+       * runtime/environ.c (search_unit):  Correct logic
+       for binary search.
+       (mark_single):  Fix index errors.
+
 2012-09-29  Thomas König  <tkoenig@gcc.gnu.org>
 
        PR fortran/52724

diff --git a/libgfortran/runtime/environ.c b/libgfortran/runtime/environ.c
index bcb91f44613a8103b798b3bc9f72727fce10242a..1f73397703d34112979fc43eba4a6ce6b451e16a 100644 (file)
--- a/libgfortran/runtime/environ.c
+++ b/libgfortran/runtime/environ.c
@@ -459,21 +459,35 @@ search_unit (int unit, int *ip)
 {
   int low, high, mid;
 
-  low = -1;
-  high = n_elist;
-  while (high - low > 1)
+  if (n_elist == 0)
+    {
+      *ip = 0;
+      return 0;
+    }
+
+  low = 0;
+  high = n_elist - 1;
+
+  do 
     {
       mid = (low + high) / 2;
-      if (unit <= elist[mid].unit)
-       high = mid;
+      if (unit == elist[mid].unit)
+       {
+         *ip = mid;
+         return 1;
+       }
+      else if (unit > elist[mid].unit)
+       low = mid + 1;
       else
-       low = mid;
-    }
-  *ip = high;
-  if (elist[high].unit == unit)
-    return 1;
+       high = mid - 1;
+    } while (low <= high);
+
+  if (unit > elist[mid].unit)
+    *ip = mid + 1;
   else
-    return 0;
+    *ip = mid;
+
+  return 0;
 }
 
 /* This matches a keyword.  If it is found, return the token supplied,
@@ -588,13 +602,13 @@ mark_single (int unit)
     }
   if (search_unit (unit, &i))
     {
-      elist[unit].conv = endian;
+      elist[i].conv = endian;
     }
   else
     {
-      for (j=n_elist; j>=i; j--)
+      for (j=n_elist-1; j>=i; j--)
        elist[j+1] = elist[j];
-    
+
       n_elist += 1;
       elist[i].unit = unit;
       elist[i].conv = endian;