thermal: thermal_hwmon: Fix a kernel NULL pointer dereference
authorZhang Rui <rui.zhang@intel.com>
Wed, 29 Mar 2023 09:00:55 +0000 (17:00 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 29 Mar 2023 16:07:14 +0000 (18:07 +0200)
When the hwmon device node of a thermal zone device is not found,
using hwmon->device causes a kernel NULL pointer dereference.

Fixes: dec07d399cc8 ("thermal: Don't use 'device' internal thermal zone structure field")
Reported-by: Preble Adam C <adam.c.preble@intel.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/thermal/thermal_hwmon.c

index c59db17..261743f 100644 (file)
@@ -229,7 +229,7 @@ void thermal_remove_hwmon_sysfs(struct thermal_zone_device *tz)
        hwmon = thermal_hwmon_lookup_by_type(tz);
        if (unlikely(!hwmon)) {
                /* Should never happen... */
-               dev_dbg(hwmon->device, "hwmon device lookup failed!\n");
+               dev_dbg(&tz->device, "hwmon device lookup failed!\n");
                return;
        }