Exclude symbol of mainloop/socket from common lib

Mainloop class and Socket class is used only as private member in other
classes in common lib so it could be hidden symbol.

Change-Id: Id32237cb00a9115fc84d95294e1846e3ddc341da
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>

diff --git a/src/framework/common/connection.cpp b/src/framework/common/connection.cpp
index a8c3ea8..19f4e32 100644 (file)
--- a/src/framework/common/connection.cpp
+++ b/src/framework/common/connection.cpp
@@ -35,6 +35,10 @@ Connection::Connection(Connection &&other) noexcept :
 {
 }
 
+Connection::~Connection()
+{
+}
+
 Connection &Connection::operator=(Connection &&other) noexcept
 {
        if (this == &other)

diff --git a/src/framework/common/connection.h b/src/framework/common/connection.h
index 842a511..2a31321 100644 (file)
--- a/src/framework/common/connection.h
+++ b/src/framework/common/connection.h
@@ -34,7 +34,7 @@ namespace Csr {
 class API Connection {
 public:
        explicit Connection(Socket &&socket) noexcept;
-       virtual ~Connection() = default;
+       virtual ~Connection();
 
        Connection(const Connection &) = delete;
        Connection &operator=(const Connection &) = delete;

diff --git a/src/framework/common/mainloop.h b/src/framework/common/mainloop.h
index 05b50cc..a4f438f 100644 (file)
--- a/src/framework/common/mainloop.h
+++ b/src/framework/common/mainloop.h
@@ -29,7 +29,7 @@
 
 namespace Csr {
 
-class API Mainloop {
+class Mainloop {
 public:
        using Callback = std::function<void(uint32_t event)>;
 

diff --git a/src/framework/common/service.cpp b/src/framework/common/service.cpp
index e8ab86f..a23aa01 100644 (file)
--- a/src/framework/common/service.cpp
+++ b/src/framework/common/service.cpp
@@ -30,6 +30,14 @@
 
 namespace Csr {
 
+Service::Service() noexcept
+{
+}
+
+Service::~Service()
+{
+}
+
 void Service::setIdleChecker(std::function<bool()> &&idleChecker)
 {
        this->m_loop.setIdleChecker(std::move(idleChecker));

diff --git a/src/framework/common/service.h b/src/framework/common/service.h
index 4b34894..a2d054b 100644 (file)
--- a/src/framework/common/service.h
+++ b/src/framework/common/service.h
@@ -35,8 +35,8 @@ namespace Csr {
 
 class API Service {
 public:
-       Service() = default;
-       virtual ~Service() = default;
+       Service() noexcept;
+       virtual ~Service();
 
        Service(const Service &) = delete;
        Service &operator=(const Service &) = delete;

diff --git a/src/framework/common/socket.h b/src/framework/common/socket.h
index c902902..52a6a8a 100644 (file)
--- a/src/framework/common/socket.h
+++ b/src/framework/common/socket.h
@@ -29,7 +29,7 @@
 
 namespace Csr {
 
-class API Socket {
+class Socket {
 public:
        enum class Type : int {
                SERVER = 0x01,

diff --git a/src/framework/ui/popup/popup-service.cpp b/src/framework/ui/popup/popup-service.cpp
index 6c86829..186b847 100644 (file)
--- a/src/framework/ui/popup/popup-service.cpp
+++ b/src/framework/ui/popup/popup-service.cpp
@@ -58,10 +58,6 @@ PopupService::PopupService() : Service()
        this->add(SockId::POPUP);
 }
 
-PopupService::~PopupService()
-{
-}
-
 RawBuffer PopupService::process(const ConnShPtr &, RawBuffer &data)
 {
        BinaryQueue q;

diff --git a/src/framework/ui/popup/popup-service.h b/src/framework/ui/popup/popup-service.h
index d3e569a..ee6d96a 100644 (file)
--- a/src/framework/ui/popup/popup-service.h
+++ b/src/framework/ui/popup/popup-service.h
@@ -33,7 +33,7 @@ namespace Ui {
 class PopupService : public Service {
 public:
        PopupService();
-       virtual ~PopupService();
+       virtual ~PopupService() = default;
 
 private:
        virtual void onMessageProcess(const ConnShPtr &) override;