i2c: qcom-geni: Add missing geni_icc_disable in geni_i2c_runtime_resume
authorAndi Shyti <andi.shyti@kernel.org>
Mon, 12 Aug 2024 19:40:28 +0000 (21:40 +0200)
committerAndi Shyti <andi.shyti@kernel.org>
Tue, 13 Aug 2024 22:58:04 +0000 (00:58 +0200)
Add the missing geni_icc_disable() call before returning in the
geni_i2c_runtime_resume() function.

Commit 9ba48db9f77c ("i2c: qcom-geni: Add missing
geni_icc_disable in geni_i2c_runtime_resume") by Gaosheng missed
disabling the interconnect in one case.

Fixes: bf225ed357c6 ("i2c: i2c-qcom-geni: Add interconnect support")
Cc: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: stable@vger.kernel.org # v5.9+
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-qcom-geni.c

index 365e37bba0f334554abd54fc0339aa5e9a57a129..06e836e3e877339233d5c514c63e8b66c09000ba 100644 (file)
@@ -986,8 +986,10 @@ static int __maybe_unused geni_i2c_runtime_resume(struct device *dev)
                return ret;
 
        ret = clk_prepare_enable(gi2c->core_clk);
-       if (ret)
+       if (ret) {
+               geni_icc_disable(&gi2c->se);
                return ret;
+       }
 
        ret = geni_se_resources_on(&gi2c->se);
        if (ret) {