gpio: omap: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 27 Aug 2020 20:08:24 +0000 (22:08 +0200)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Fri, 28 Aug 2020 18:15:23 +0000 (20:15 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Grygorii Strashko <grygorii.strashko@ti.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-omap.c

index 7fbe0c9..2dc12f4 100644 (file)
@@ -1394,10 +1394,7 @@ static int omap_gpio_probe(struct platform_device *pdev)
        if (bank->irq <= 0) {
                if (!bank->irq)
                        bank->irq = -ENXIO;
-               if (bank->irq != -EPROBE_DEFER)
-                       dev_err(dev,
-                               "can't get irq resource ret=%d\n", bank->irq);
-               return bank->irq;
+               return dev_err_probe(dev, bank->irq, "can't get irq resource\n");
        }
 
        bank->chip.parent = dev;