[Archive][Exif] Added checking return value of fseek 80/197780/2
authorPiotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Wed, 16 Jan 2019 08:45:10 +0000 (09:45 +0100)
committerPiotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Wed, 16 Jan 2019 08:55:46 +0000 (09:55 +0100)
SVACE issues: 246302, 246317

Change-Id: If4f803b9db18c352912290b25df706a21cd07853
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
src/archive/zip_add_request.cc
src/exif/jpeg_file.cc

index d6e862f358276eee399defe1045164ca38b297c9..583bfead420bb7d22f5bd6d9171d5ce3eea70e31 100644 (file)
@@ -358,9 +358,14 @@ PlatformResult ZipAddRequest::addToZipArchive(filesystem::NodePtr src_file_node)
     }
 
     // Get file length
-    fseek(m_input_file, 0, SEEK_END);
+    int res = fseek(m_input_file, 0, SEEK_END);
+    if (0 != res) {
+      return LogAndCreateResult(ErrorCode::UNKNOWN_ERR, "Reading input file failed",
+                                ("fseek failed with error! [%d]", res));
+    }
+
     const size_t in_file_size = ftell(m_input_file);
-    int res = fseek(m_input_file, 0, SEEK_SET);
+    res = fseek(m_input_file, 0, SEEK_SET);
     if (0 != res) {
       return LogAndCreateResult(ErrorCode::UNKNOWN_ERR, "Reading input file failed",
                                 ("fseek failed with error! [%d]", res));
index 39bf00c7ca1a723870bfb22e58371a192e15ef90..a391e73f933e3197ffb04820d399888653a4935b 100644 (file)
@@ -161,7 +161,12 @@ PlatformResult JpegFile::load(const std::string& path) {
   }
 
   const std::size_t in_file_size = static_cast<size_t>(ftell_val);
-  fseek(m_in_file, 0, SEEK_SET);
+  res = fseek(m_in_file, 0, SEEK_SET);
+  if (0 != res) {
+    return LogAndCreateResult(ErrorCode::UNKNOWN_ERR, "Reading JPEG file failed",
+                              ("fseek failed with error! [%d]", res));
+  }
+
   LoggerD("JPEG file: [%s] size:%d", path.c_str(), in_file_size);
   if (0 == in_file_size) {
     return LogAndCreateResult(ErrorCode::UNKNOWN_ERR, "JPEG file is invalid",