[sanitizers][windows] FIX: Rtl-Heap Interception and tests

   - Adds interceptors for Rtl[Allocate|Free|Size|ReAllocate]Heap
   - Adds unit tests for the new interceptors and expands HeapAlloc
     tests to demonstrate new functionality.
   Reviewed as D62927
   - adds fixes for ~win and x64 tests

> llvm-svn: 365381

llvm-svn: 365424

diff --git a/compiler-rt/lib/asan/asan_malloc_win.cc b/compiler-rt/lib/asan/asan_malloc_win.cc
index 4586beb..89d7003 100644 (file)
--- a/compiler-rt/lib/asan/asan_malloc_win.cc
+++ b/compiler-rt/lib/asan/asan_malloc_win.cc
@@ -12,6 +12,8 @@
 //===----------------------------------------------------------------------===//
 
 #include "sanitizer_common/sanitizer_allocator_interface.h"
+#include "sanitizer_common/sanitizer_platform.h"
+#if SANITIZER_WINDOWS
 // Need to include defintions for windows heap api functions,
 // these assume windows.h will also be included. This definition
 // fixes an error that's thrown if you only include heapapi.h
@@ -24,8 +26,6 @@
 #endif
 #include <heapapi.h>
 
-#include "sanitizer_common/sanitizer_platform.h"
-#if SANITIZER_WINDOWS
 // Intentionally not including windows.h here, to avoid the risk of
 // pulling in conflicting declarations of these functions. (With mingw-w64,
 // there's a risk of windows.h pulling in stdint.h.)

diff --git a/compiler-rt/test/asan/TestCases/Windows/heapalloc.cc b/compiler-rt/test/asan/TestCases/Windows/heapalloc.cc
index 66322a3..30e70c3 100644 (file)
--- a/compiler-rt/test/asan/TestCases/Windows/heapalloc.cc
+++ b/compiler-rt/test/asan/TestCases/Windows/heapalloc.cc
@@ -1,4 +1,4 @@
-// XFAIL: asan-64-bits
+// UNSUPPORTED: asan-64-bits
 // RUN: %clang_cl_asan -O0 %s -Fe%t
 // RUN: %env_asan_opts=windows_hook_rtl_allocators=true not %run %t 2>&1 | FileCheck %s
 

diff --git a/compiler-rt/test/asan/TestCases/Windows/heapalloc_doublefree.cc b/compiler-rt/test/asan/TestCases/Windows/heapalloc_doublefree.cc
index dcdf989..9ad5ecc 100644 (file)
--- a/compiler-rt/test/asan/TestCases/Windows/heapalloc_doublefree.cc
+++ b/compiler-rt/test/asan/TestCases/Windows/heapalloc_doublefree.cc
@@ -1,6 +1,6 @@
 // RUN: %clang_cl_asan -O0 %s -Fe%t
 // RUN: %env_asan_opts=windows_hook_rtl_allocators=true not %run %t 2>&1 | FileCheck %s
-// XFAIL: asan-64-bits
+// UNSUPPORTED: asan-64-bits
 #include <cassert>
 #include <windows.h>
 

diff --git a/compiler-rt/test/asan/TestCases/Windows/heapalloc_flags_fallback.cc b/compiler-rt/test/asan/TestCases/Windows/heapalloc_flags_fallback.cc
index eda94ac..d118e2d 100644 (file)
--- a/compiler-rt/test/asan/TestCases/Windows/heapalloc_flags_fallback.cc
+++ b/compiler-rt/test/asan/TestCases/Windows/heapalloc_flags_fallback.cc
@@ -1,7 +1,7 @@
 // RUN: %clang_cl_asan -O0 %s -Fe%t
 // RUN: %run %t 2>&1 | FileCheck %s
 // RUN: %env_asan_opts=windows_hook_rtl_allocators=true %run %t 2>&1 | FileCheck %s
-// XFAIL: asan-64-bits
+// UNSUPPORTED: asan-64-bits
 #include <assert.h>
 #include <stdio.h>
 #include <windows.h>

diff --git a/compiler-rt/test/asan/TestCases/Windows/heapalloc_huge.cc b/compiler-rt/test/asan/TestCases/Windows/heapalloc_huge.cc
index ce1fd65..3c0feff 100644 (file)
--- a/compiler-rt/test/asan/TestCases/Windows/heapalloc_huge.cc
+++ b/compiler-rt/test/asan/TestCases/Windows/heapalloc_huge.cc
@@ -1,7 +1,7 @@
 // RUN: %clang_cl_asan -O0 %s -Fe%t
 // RUN: %env_asan_opts=allocator_may_return_null=true %run %t
 // RUN: %env_asan_opts=allocator_may_return_null=true:windows_hook_rtl_allocators=true %run %t
-// XFAIL: asan-64-bits
+// UNSUPPORTED: asan-64-bits
 #include <windows.h>
 int main() {
   void *nope = HeapAlloc(GetProcessHeap(), 0, ((size_t)0) - 1);

diff --git a/compiler-rt/test/asan/TestCases/Windows/heapalloc_rtl_transfer.cc b/compiler-rt/test/asan/TestCases/Windows/heapalloc_rtl_transfer.cc
index b621270..a36e594 100644 (file)
--- a/compiler-rt/test/asan/TestCases/Windows/heapalloc_rtl_transfer.cc
+++ b/compiler-rt/test/asan/TestCases/Windows/heapalloc_rtl_transfer.cc
@@ -5,7 +5,7 @@
 
 // RUN: %clang_cl_asan %s -o%t
 // RUN: %env_asan_opts=windows_hook_rtl_allocators=true %run %t 2>&1 | FileCheck %s
-// XFAIL: asan-64-bits
+// UNSUPPORTED: asan-64-bits
 
 using AllocateFunctionPtr = PVOID(__stdcall *)(PVOID, ULONG, SIZE_T);
 using ReAllocateFunctionPtr = PVOID(__stdcall *)(PVOID, ULONG, PVOID, SIZE_T);

diff --git a/compiler-rt/test/asan/TestCases/Windows/heapalloc_transfer.cc b/compiler-rt/test/asan/TestCases/Windows/heapalloc_transfer.cc
index b3b5746..497d36b 100644 (file)
--- a/compiler-rt/test/asan/TestCases/Windows/heapalloc_transfer.cc
+++ b/compiler-rt/test/asan/TestCases/Windows/heapalloc_transfer.cc
@@ -4,7 +4,7 @@
 #include <windows.h>
 // RUN: %clang_cl_asan %s -o%t
 // RUN: %env_asan_opts=windows_hook_rtl_allocators=true %run %t 2>&1 | FileCheck %s
-// XFAIL: asan-64-bits
+// UNSUPPORTED: asan-64-bits
 
 int main() {
   //owned by rtl

diff --git a/compiler-rt/test/asan/TestCases/Windows/heapalloc_uaf.cc b/compiler-rt/test/asan/TestCases/Windows/heapalloc_uaf.cc
index 00fb3ab..9aee5bb 100644 (file)
--- a/compiler-rt/test/asan/TestCases/Windows/heapalloc_uaf.cc
+++ b/compiler-rt/test/asan/TestCases/Windows/heapalloc_uaf.cc
@@ -1,6 +1,6 @@
 // RUN: %clang_cl_asan -O0 %s -Fe%t
 // RUN: %env_asan_opts=windows_hook_rtl_allocators=true not %run %t 2>&1 | FileCheck %s
-// XFAIL: asan-64-bits
+// UNSUPPORTED: asan-64-bits
 #include <windows.h>
 
 int main() {

diff --git a/compiler-rt/test/asan/TestCases/Windows/heapalloc_zero_size.cc b/compiler-rt/test/asan/TestCases/Windows/heapalloc_zero_size.cc
index 23fc97b..40396ed 100644 (file)
--- a/compiler-rt/test/asan/TestCases/Windows/heapalloc_zero_size.cc
+++ b/compiler-rt/test/asan/TestCases/Windows/heapalloc_zero_size.cc
@@ -3,7 +3,7 @@
 // RUN: %env_asan_opts=windows_hook_rtl_allocators=false %run %t 2>&1 | FileCheck %s
 // RUN: %clang_cl /Od -o %t %s
 // RUN: %run %t 2>&1 | FileCheck %s
-// XFAIL: asan-64-bits
+// UNSUPPORTED: asan-64-bits
 #include <cassert>
 #include <stdio.h>
 #include <windows.h>

diff --git a/compiler-rt/test/asan/TestCases/Windows/heaprealloc.cc b/compiler-rt/test/asan/TestCases/Windows/heaprealloc.cc
index e6efb87..21589cf 100644 (file)
--- a/compiler-rt/test/asan/TestCases/Windows/heaprealloc.cc
+++ b/compiler-rt/test/asan/TestCases/Windows/heaprealloc.cc
@@ -1,6 +1,6 @@
 // RUN: %clang_cl_asan -O0 %s -Fe%t
 // RUN: %env_asan_opts=windows_hook_rtl_allocators=true not %run %t 2>&1 | FileCheck %s
-// XFAIL: asan-64-bits
+// UNSUPPORTED: asan-64-bits
 #include <stdio.h>
 #include <windows.h>
 

diff --git a/compiler-rt/test/asan/TestCases/Windows/heaprealloc_alloc_zero.cc b/compiler-rt/test/asan/TestCases/Windows/heaprealloc_alloc_zero.cc
index 76ae896..7b1272e 100644 (file)
--- a/compiler-rt/test/asan/TestCases/Windows/heaprealloc_alloc_zero.cc
+++ b/compiler-rt/test/asan/TestCases/Windows/heaprealloc_alloc_zero.cc
@@ -1,6 +1,6 @@
 // RUN: %clang_cl_asan /Od /MT -o %t %s
 // RUN: %env_asan_opts=windows_hook_rtl_allocators=true %run %t 2>&1 | FileCheck %s
-// XFAIL: asan-64-bits
+// UNSUPPORTED: asan-64-bits
 #include <cassert>
 #include <iostream>
 #include <windows.h>

diff --git a/compiler-rt/test/asan/TestCases/Windows/heaprealloc_zero_size.cc b/compiler-rt/test/asan/TestCases/Windows/heaprealloc_zero_size.cc
index ad2478b..96bc9b9 100644 (file)
--- a/compiler-rt/test/asan/TestCases/Windows/heaprealloc_zero_size.cc
+++ b/compiler-rt/test/asan/TestCases/Windows/heaprealloc_zero_size.cc
@@ -3,7 +3,7 @@
 // RUN: %env_asan_opts=windows_hook_rtl_allocators=false %run %t 2>&1 | FileCheck %s
 // RUN: %clang_cl /Od -o %t %s
 // RUN: %run %t 2>&1 | FileCheck %s
-// XFAIL: asan-64-bits
+// UNSUPPORTED: asan-64-bits
 #include <cassert>
 #include <stdio.h>
 #include<windows.h>

diff --git a/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap.cc b/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap.cc
index 5831fe2..27738e9 100644 (file)
--- a/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap.cc
+++ b/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap.cc
@@ -1,6 +1,6 @@
 // RUN: %clang_cl_asan -O0 %s -Fe%t /MD
 // RUN: %env_asan_opts=windows_hook_rtl_allocators=true not %run %t 2>&1 | FileCheck %s
-// XFAIL: asan-64-bits
+// UNSUPPORTED: asan-64-bits
 // REQUIRES: asan-rtl-heap-interception
 
 #include <stdio.h>

diff --git a/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_flags_fallback.cc b/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_flags_fallback.cc
index c377fe3..738bf0f 100644 (file)
--- a/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_flags_fallback.cc
+++ b/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_flags_fallback.cc
@@ -1,6 +1,6 @@
 // RUN: %clang_cl_asan -O0 %s -Fe%t /MD
 // RUN: %env_asan_opts=windows_hook_rtl_allocators=true %run %t 2>&1 | FileCheck %s
-// XFAIL: asan-64-bits
+// UNSUPPORTED: asan-64-bits
 // REQUIRES: asan-rtl-heap-interception
 
 #include <assert.h>

diff --git a/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_zero.cc b/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_zero.cc
index d4bde78..ef372a1 100644 (file)
--- a/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_zero.cc
+++ b/compiler-rt/test/asan/TestCases/Windows/rtlallocateheap_zero.cc
@@ -1,6 +1,6 @@
 // RUN: %clang_cl_asan -O0 %s -Fe%t /MD
 // RUN: %env_asan_opts=windows_hook_rtl_allocators=true not %run %t 2>&1 | FileCheck %s
-// XFAIL: asan-64-bits
+// UNSUPPORTED: asan-64-bits
 // REQUIRES: asan-rtl-heap-interception
 
 #include <assert.h>