Fix stringop-truncation warning 60/222160/2
authorSangwan Kwon <sangwan.kwon@samsung.com>
Fri, 10 Jan 2020 04:47:47 +0000 (13:47 +0900)
committerSangwan Kwon <sangwan.kwon@samsung.com>
Fri, 10 Jan 2020 05:02:47 +0000 (14:02 +0900)
Pathname sockets: The pathname in sun_path should be null-terminated.
ref: http://man7.org/linux/man-pages/man7/unix.7.html

Change-Id: Ie3cd95aff89e8f77e07acdac9e181a092b731bee
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
src/framework/common/socket.cpp

index 56dd9d7..9763982 100644 (file)
@@ -134,7 +134,8 @@ Socket Socket::connect(SockId sockId)
        sockaddr_un addr;
        addr.sun_family = AF_UNIX;
 
-       strncpy(addr.sun_path, path.c_str(), sizeof(addr.sun_path));
+       strncpy(addr.sun_path, path.c_str(), sizeof(addr.sun_path) - 1);
+       addr.sun_path[sizeof(sockaddr_un::sun_path) - 1] = '\0';
 
        if (::connect(fd, reinterpret_cast<sockaddr *>(&addr),
                                  sizeof(sockaddr_un)) == -1)