Kiss Gabor noticed that ping compiled without BB_FEATURE_FANCY_PING

would return 0 instead of EXIT_FAILURE when no response was received.

diff --git a/networking/ping.c b/networking/ping.c
index f21f2b1..044b547 100644 (file)
--- a/networking/ping.c
+++ b/networking/ping.c
@@ -1,6 +1,6 @@
 /* vi: set sw=4 ts=4: */
 /*
- * $Id: ping.c,v 1.52 2002/06/06 11:47:00 andersen Exp $
+ * $Id: ping.c,v 1.53 2003/01/12 06:08:33 andersen Exp $
  * Mini ping implementation for busybox
  *
  * Copyright (C) 1999 by Randolph Chung <tausq@debian.org>
@@ -179,7 +179,7 @@ static char *hostname = NULL;
 static void noresp(int ign)
 {
        printf("No response from %s\n", hostname);
-       exit(0);
+       exit(EXIT_FAILURE);
 }
 
 static void ping(const char *host)

diff --git a/networking/ping6.c b/networking/ping6.c
index 8e14647..f1ccff4 100644 (file)
--- a/networking/ping6.c
+++ b/networking/ping6.c
@@ -1,6 +1,6 @@
 /* vi: set sw=4 ts=4: */
 /*
- * $Id: ping6.c,v 1.2 2002/11/26 03:03:41 bug1 Exp $
+ * $Id: ping6.c,v 1.3 2003/01/12 06:08:33 andersen Exp $
  * Mini ping implementation for busybox
  *
  * Copyright (C) 1999 by Randolph Chung <tausq@debian.org>
@@ -77,6 +77,11 @@ static void ping(const char *host);
 
 /* simple version */
 #ifndef CONFIG_FEATURE_FANCY_PING6
+void noresp(int ign)
+{
+       printf("No response from %s\n", h->h_name);
+       exit(EXIT_FAILURE);
+}
 
 static void ping(const char *host)
 {
@@ -87,12 +92,6 @@ static void ping(const char *host)
        int sockopt;
        char packet[DEFDATALEN + MAXIPLEN + MAXICMPLEN];
 
-       void noresp(int ign)
-       {
-               printf("No response from %s\n", h->h_name);
-               exit(0);
-       }
-
        pingsock = create_icmp6_socket();
 
        memset(&pingaddr, 0, sizeof(struct sockaddr_in));