HSI: nokia-modem: Delete error messages for a failed memory allocation in two functions
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 25 Apr 2017 08:17:06 +0000 (10:17 +0200)
committerSebastian Reichel <sre@kernel.org>
Thu, 8 Jun 2017 11:21:43 +0000 (13:21 +0200)
The script "checkpatch.pl" pointed information out like the following.

WARNING: Possible unnecessary 'out of memory' message

Thus remove such statements here.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
drivers/hsi/clients/nokia-modem.c

index f6c97a0..a774ca7 100644 (file)
@@ -104,10 +104,8 @@ static int nokia_modem_gpio_probe(struct device *dev)
 
        modem->gpios = devm_kcalloc(dev, gpio_count, sizeof(*modem->gpios),
                                    GFP_KERNEL);
-       if (!modem->gpios) {
-               dev_err(dev, "Could not allocate memory for gpios\n");
+       if (!modem->gpios)
                return -ENOMEM;
-       }
 
        modem->gpio_amount = gpio_count;
 
@@ -156,10 +154,9 @@ static int nokia_modem_probe(struct device *dev)
        }
 
        modem = devm_kzalloc(dev, sizeof(*modem), GFP_KERNEL);
-       if (!modem) {
-               dev_err(dev, "Could not allocate memory for nokia_modem_device\n");
+       if (!modem)
                return -ENOMEM;
-       }
+
        dev_set_drvdata(dev, modem);
        modem->device = dev;