Drop globals.h include from platform.h
authorjochen@chromium.org <jochen@chromium.org@ce2b1a6d-e550-0410-aec6-3dcde31c8c00>
Wed, 11 Jun 2014 18:12:03 +0000 (18:12 +0000)
committerjochen@chromium.org <jochen@chromium.org@ce2b1a6d-e550-0410-aec6-3dcde31c8c00>
Wed, 11 Jun 2014 18:12:03 +0000 (18:12 +0000)
Also delete dead cpu-features-implied-by-platform code.

BUG=none
R=jkummerow@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/326333002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21779 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

src/arm/assembler-arm.cc
src/ia32/assembler-ia32.cc
src/mips/assembler-mips.cc
src/platform-posix.cc
src/platform-win32.cc
src/platform.h
src/x64/assembler-x64.cc
src/x87/assembler-x87.cc

index c3f9ab0..ca5aad3 100644 (file)
@@ -72,7 +72,6 @@ static unsigned CpuFeaturesImpliedByCompiler() {
 
 
 void CpuFeatures::ProbeImpl(bool cross_compile) {
-  supported_ |= OS::CpuFeaturesImpliedByPlatform();
   supported_ |= CpuFeaturesImpliedByCompiler();
   cache_line_size_ = 64;
 
index bc17b25..75cb6ed 100644 (file)
@@ -52,7 +52,6 @@ void CpuFeatures::ProbeImpl(bool cross_compile) {
   CPU cpu;
   CHECK(cpu.has_sse2());  // SSE2 support is mandatory.
   CHECK(cpu.has_cmov());  // CMOV support is mandatory.
-  supported_ |= OS::CpuFeaturesImpliedByPlatform();
 
   // Only use statically determined features for cross compile (snapshot).
   if (cross_compile) return;
index 97aed6b..e4bebfe 100644 (file)
@@ -87,7 +87,6 @@ const char* DoubleRegister::AllocationIndexToString(int index) {
 
 
 void CpuFeatures::ProbeImpl(bool cross_compile) {
-  supported_ |= OS::CpuFeaturesImpliedByPlatform();
   supported_ |= CpuFeaturesImpliedByCompiler();
 
   // Only use statically determined features for cross compile (snapshot).
index e9e4161..87b96e2 100644 (file)
@@ -56,11 +56,6 @@ namespace internal {
 static const pthread_t kNoThread = (pthread_t) 0;
 
 
-unsigned OS::CpuFeaturesImpliedByPlatform() {
-  return 0;  // Nothing special.
-}
-
-
 int OS::NumberOfProcessorsOnline() {
   return static_cast<int>(sysconf(_SC_NPROCESSORS_ONLN));
 }
index 03fb8b6..1caadbe 100644 (file)
@@ -1158,11 +1158,6 @@ void OS::SignalCodeMovingGC() { }
 #endif  // __MINGW32__
 
 
-unsigned OS::CpuFeaturesImpliedByPlatform() {
-  return 0;  // Windows runs on anything.
-}
-
-
 int OS::NumberOfProcessorsOnline() {
   SYSTEM_INFO info;
   GetSystemInfo(&info);
index 2d5101d..3cec113 100644 (file)
@@ -23,9 +23,9 @@
 
 #include <stdarg.h>
 
+#include "src/base/build_config.h"
 #include "src/platform/mutex.h"
 #include "src/platform/semaphore.h"
-#include "src/globals.h"
 #include "src/vector.h"
 
 #ifdef __sun
@@ -263,13 +263,6 @@ class OS {
   // using --never-compact) if accurate profiling is desired.
   static void SignalCodeMovingGC();
 
-  // The return value indicates the CPU features we are sure of because of the
-  // OS.
-  // This is a little messy because the interpretation is subject to the cross
-  // of the CPU and the OS.  The bits in the answer correspond to the bit
-  // positions indicated by the members of the CpuFeature enum from globals.h
-  static unsigned CpuFeaturesImpliedByPlatform();
-
   // Returns the number of processors online.
   static int NumberOfProcessorsOnline();
 
index e5855d3..59b027f 100644 (file)
@@ -20,8 +20,6 @@ void CpuFeatures::ProbeImpl(bool cross_compile) {
   CHECK(cpu.has_sse2());  // SSE2 support is mandatory.
   CHECK(cpu.has_cmov());  // CMOV support is mandatory.
 
-  supported_ |= OS::CpuFeaturesImpliedByPlatform();
-
   // Only use statically determined features for cross compile (snapshot).
   if (cross_compile) return;
 
index 3fbcff9..f2082c2 100644 (file)
@@ -50,7 +50,6 @@ namespace internal {
 
 void CpuFeatures::ProbeImpl(bool cross_compile) {
   CPU cpu;
-  supported_ |= OS::CpuFeaturesImpliedByPlatform();
 
   // Only use statically determined features for cross compile (snapshot).
   if (cross_compile) return;