ASoC: mediatek: mt8192-mt6359: fix device_node leak
authorTzung-Bi Shih <tzungbi@google.com>
Tue, 14 Dec 2021 04:00:28 +0000 (12:00 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 23 Dec 2021 17:36:44 +0000 (17:36 +0000)
The of_parse_phandle() document:
    >>> Use of_node_put() on it when done.

The driver didn't call of_node_put().  Fixes the leak.

Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
Link: https://lore.kernel.org/r/20211214040028.2992627-1-tzungbi@google.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c

index 1d16939..2552f30 100644 (file)
@@ -1172,7 +1172,11 @@ static int mt8192_mt6359_dev_probe(struct platform_device *pdev)
                return ret;
        }
 
-       return devm_snd_soc_register_card(&pdev->dev, card);
+       ret = devm_snd_soc_register_card(&pdev->dev, card);
+
+       of_node_put(platform_node);
+       of_node_put(hdmi_codec);
+       return ret;
 }
 
 #ifdef CONFIG_OF