Revert "avviddec: Unlock video decoder stream lock temporarily while finishing frames"
authorGuillaume Desmottes <guillaume.desmottes@onestream.live>
Tue, 19 Nov 2024 10:54:12 +0000 (11:54 +0100)
committerGuillaume Desmottes <guillaume.desmottes@onestream.live>
Tue, 19 Nov 2024 10:54:12 +0000 (11:54 +0100)
This reverts commit 6b18f0233900ae4ecdbcde0ce76ab55fd85286f4.

This commit introduced a regression, see
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/4032

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7921>

subprojects/gst-libav/ext/libav/gstavviddec.c

index ab77eee67e8d60324263a70873e547f501db71a0..fe51832d2350a18fe875596184c23bd7547a00c7 100644 (file)
@@ -2092,16 +2092,9 @@ gst_ffmpegviddec_video_frame (GstFFMpegVidDec * ffmpegdec,
           GST_VIDEO_BUFFER_FLAG_TFF);
     }
   }
-
-  /* Temporarily release the video decoder stream lock so that other
-   * threads can continue decoding (e.g. call get_frame()) while data
-   * is being pushed downstream.
-   */
-  GST_VIDEO_DECODER_STREAM_UNLOCK (ffmpegdec);
   *ret =
       gst_video_decoder_finish_frame (GST_VIDEO_DECODER (ffmpegdec),
       output_frame);
-  GST_VIDEO_DECODER_STREAM_LOCK (ffmpegdec);
 
 beach:
   GST_DEBUG_OBJECT (ffmpegdec, "return flow %s, got frame: %d",