mfd: ab8500-core: Fix invalid free of devm_ allocated data
authorTushar Behera <tushar.behera@linaro.org>
Fri, 23 Nov 2012 12:18:43 +0000 (17:48 +0530)
committerSamuel Ortiz <sameo@linux.intel.com>
Fri, 30 Nov 2012 10:51:30 +0000 (11:51 +0100)
The objects allocated by devm_* APIs are managed by devres and are
freed when the device is detached. Hence there is no need to remove
them explicitly in remove function.

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/mfd/ab8500-core.c

index 5b8a4de..660a09b 100644 (file)
@@ -1437,11 +1437,6 @@ static int __devexit ab8500_remove(struct platform_device *pdev)
                sysfs_remove_group(&ab8500->dev->kobj, &ab8500_attr_group);
 
        mfd_remove_devices(ab8500->dev);
-       free_irq(ab8500->irq, ab8500);
-
-       kfree(ab8500->oldmask);
-       kfree(ab8500->mask);
-       kfree(ab8500);
 
        return 0;
 }