scsi: snic: Remove unused 'xfer_len' variable
authorTom Rix <trix@redhat.com>
Tue, 28 Mar 2023 00:16:47 +0000 (20:16 -0400)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 3 Apr 2023 01:47:36 +0000 (21:47 -0400)
clang with W=1 reports:

drivers/scsi/snic/snic_scsi.c:490:6: error: variable
  'xfer_len' set but not used [-Werror,-Wunused-but-set-variable]
        u64 xfer_len = 0;
            ^
This variable is not used so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20230328001647.1778448-1-trix@redhat.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/snic/snic_scsi.c

index 961af6f..c50ede3 100644 (file)
@@ -487,7 +487,6 @@ snic_process_icmnd_cmpl_status(struct snic *snic,
                               struct scsi_cmnd *sc)
 {
        u8 scsi_stat = icmnd_cmpl->scsi_status;
-       u64 xfer_len = 0;
        int ret = 0;
 
        /* Mark the IO as complete */
@@ -496,15 +495,11 @@ snic_process_icmnd_cmpl_status(struct snic *snic,
        if (likely(cmpl_stat == SNIC_STAT_IO_SUCCESS)) {
                sc->result = (DID_OK << 16) | scsi_stat;
 
-               xfer_len = scsi_bufflen(sc);
-
                /* Update SCSI Cmd with resid value */
                scsi_set_resid(sc, le32_to_cpu(icmnd_cmpl->resid));
 
-               if (icmnd_cmpl->flags & SNIC_ICMND_CMPL_UNDR_RUN) {
-                       xfer_len -= le32_to_cpu(icmnd_cmpl->resid);
+               if (icmnd_cmpl->flags & SNIC_ICMND_CMPL_UNDR_RUN)
                        atomic64_inc(&snic->s_stats.misc.io_under_run);
-               }
 
                if (icmnd_cmpl->scsi_status == SAM_STAT_TASK_SET_FULL)
                        atomic64_inc(&snic->s_stats.misc.qfull);